Re: [PATCH 1/2] Revert "UBIFS: Fix potential integer overflow in allocation"

2018-07-02 Thread Kees Cook
On Mon, Jul 2, 2018 at 2:41 PM, Richard Weinberger wrote: > Am Montag, 2. Juli 2018, 20:27:00 CEST schrieb Kees Cook: >> > Let's queue another patch for the next merge window which converts >> > kmalloc() -> kmalloc_array(). >> >> I'd prefer to leave it as-is for 4.18 because it would be the only

Re: [PATCH 1/2] Revert "UBIFS: Fix potential integer overflow in allocation"

2018-07-02 Thread Kees Cook
On Mon, Jul 2, 2018 at 2:41 PM, Richard Weinberger wrote: > Am Montag, 2. Juli 2018, 20:27:00 CEST schrieb Kees Cook: >> > Let's queue another patch for the next merge window which converts >> > kmalloc() -> kmalloc_array(). >> >> I'd prefer to leave it as-is for 4.18 because it would be the only

Re: [PATCH 1/2] Revert "UBIFS: Fix potential integer overflow in allocation"

2018-07-02 Thread Richard Weinberger
Am Montag, 2. Juli 2018, 20:27:00 CEST schrieb Kees Cook: > > Let's queue another patch for the next merge window which converts > > kmalloc() -> kmalloc_array(). > > I'd prefer to leave it as-is for 4.18 because it would be the only > unconverted kmalloc()-with-multiplication in the entire tree.

Re: [PATCH 1/2] Revert "UBIFS: Fix potential integer overflow in allocation"

2018-07-02 Thread Richard Weinberger
Am Montag, 2. Juli 2018, 20:27:00 CEST schrieb Kees Cook: > > Let's queue another patch for the next merge window which converts > > kmalloc() -> kmalloc_array(). > > I'd prefer to leave it as-is for 4.18 because it would be the only > unconverted kmalloc()-with-multiplication in the entire tree.

Re: [PATCH 1/2] Revert "UBIFS: Fix potential integer overflow in allocation"

2018-07-02 Thread Kees Cook
On Mon, Jul 2, 2018 at 10:50 AM, Richard Weinberger wrote: > Am Montag, 2. Juli 2018, 18:00:05 CEST schrieb Kees Cook: >> On Sun, Jul 1, 2018 at 2:20 PM, Richard Weinberger wrote: >> > This reverts commit 353748a359f1821ee934afc579cf04572406b420. >> > It bypassed the linux-mtd review process and

Re: [PATCH 1/2] Revert "UBIFS: Fix potential integer overflow in allocation"

2018-07-02 Thread Kees Cook
On Mon, Jul 2, 2018 at 10:50 AM, Richard Weinberger wrote: > Am Montag, 2. Juli 2018, 18:00:05 CEST schrieb Kees Cook: >> On Sun, Jul 1, 2018 at 2:20 PM, Richard Weinberger wrote: >> > This reverts commit 353748a359f1821ee934afc579cf04572406b420. >> > It bypassed the linux-mtd review process and

Re: [PATCH 1/2] Revert "UBIFS: Fix potential integer overflow in allocation"

2018-07-02 Thread Richard Weinberger
Am Montag, 2. Juli 2018, 18:00:05 CEST schrieb Kees Cook: > On Sun, Jul 1, 2018 at 2:20 PM, Richard Weinberger wrote: > > This reverts commit 353748a359f1821ee934afc579cf04572406b420. > > It bypassed the linux-mtd review process and fixes the issue not as it > > should. > > Ah, sorry, I thought

Re: [PATCH 1/2] Revert "UBIFS: Fix potential integer overflow in allocation"

2018-07-02 Thread Richard Weinberger
Am Montag, 2. Juli 2018, 18:00:05 CEST schrieb Kees Cook: > On Sun, Jul 1, 2018 at 2:20 PM, Richard Weinberger wrote: > > This reverts commit 353748a359f1821ee934afc579cf04572406b420. > > It bypassed the linux-mtd review process and fixes the issue not as it > > should. > > Ah, sorry, I thought

Re: [PATCH 1/2] Revert "UBIFS: Fix potential integer overflow in allocation"

2018-07-02 Thread Kees Cook
On Sun, Jul 1, 2018 at 2:20 PM, Richard Weinberger wrote: > This reverts commit 353748a359f1821ee934afc579cf04572406b420. > It bypassed the linux-mtd review process and fixes the issue not as it > should. Ah, sorry, I thought you were CCed on the original report. > Cc: Kees Cook > Cc: Silvio

Re: [PATCH 1/2] Revert "UBIFS: Fix potential integer overflow in allocation"

2018-07-02 Thread Kees Cook
On Sun, Jul 1, 2018 at 2:20 PM, Richard Weinberger wrote: > This reverts commit 353748a359f1821ee934afc579cf04572406b420. > It bypassed the linux-mtd review process and fixes the issue not as it > should. Ah, sorry, I thought you were CCed on the original report. > Cc: Kees Cook > Cc: Silvio

[PATCH 1/2] Revert "UBIFS: Fix potential integer overflow in allocation"

2018-07-01 Thread Richard Weinberger
This reverts commit 353748a359f1821ee934afc579cf04572406b420. It bypassed the linux-mtd review process and fixes the issue not as it should. Cc: Kees Cook Cc: Silvio Cesare Cc: sta...@vger.kernel.org Signed-off-by: Richard Weinberger --- fs/ubifs/journal.c | 5 ++--- 1 file changed, 2

[PATCH 1/2] Revert "UBIFS: Fix potential integer overflow in allocation"

2018-07-01 Thread Richard Weinberger
This reverts commit 353748a359f1821ee934afc579cf04572406b420. It bypassed the linux-mtd review process and fixes the issue not as it should. Cc: Kees Cook Cc: Silvio Cesare Cc: sta...@vger.kernel.org Signed-off-by: Richard Weinberger --- fs/ubifs/journal.c | 5 ++--- 1 file changed, 2