Re: [PATCH 1/2] amba: Take device out of reset before reading pid and cid values

2019-03-28 Thread Linus Walleij
On Thu, Mar 21, 2019 at 12:17 PM Daniel Thompson wrote: > On Wed, Mar 20, 2019 at 05:29:56PM +, Russell King - ARM Linux admin > wrote: > > On Wed, Mar 20, 2019 at 12:26:58PM +0530, Manivannan Sadhasivam wrote: > > That said, if a reset line is shared between multiple devices, and a > >

Re: [PATCH 1/2] amba: Take device out of reset before reading pid and cid values

2019-03-21 Thread Daniel Thompson
On Wed, Mar 20, 2019 at 05:29:56PM +, Russell King - ARM Linux admin wrote: > On Wed, Mar 20, 2019 at 12:26:58PM +0530, Manivannan Sadhasivam wrote: > > Hi Daniel, > > > > On Tue, Mar 12, 2019 at 12:27:11PM +, Daniel Thompson wrote: > > > On Sat, Mar 09, 2019 at 07:26:34AM +0530,

Re: [PATCH 1/2] amba: Take device out of reset before reading pid and cid values

2019-03-20 Thread Russell King - ARM Linux admin
On Wed, Mar 20, 2019 at 12:26:58PM +0530, Manivannan Sadhasivam wrote: > Hi Daniel, > > On Tue, Mar 12, 2019 at 12:27:11PM +, Daniel Thompson wrote: > > On Sat, Mar 09, 2019 at 07:26:34AM +0530, Manivannan Sadhasivam wrote: > > > For the AMBA Primecell devices having the reset lines wired, it

Re: [PATCH 1/2] amba: Take device out of reset before reading pid and cid values

2019-03-20 Thread Daniel Thompson
On Wed, Mar 20, 2019 at 12:26:58PM +0530, Manivannan Sadhasivam wrote: > Hi Daniel, > > On Tue, Mar 12, 2019 at 12:27:11PM +, Daniel Thompson wrote: > > On Sat, Mar 09, 2019 at 07:26:34AM +0530, Manivannan Sadhasivam wrote: > > > For the AMBA Primecell devices having the reset lines wired, it

Re: [PATCH 1/2] amba: Take device out of reset before reading pid and cid values

2019-03-20 Thread Manivannan Sadhasivam
Hi Daniel, On Tue, Mar 12, 2019 at 12:27:11PM +, Daniel Thompson wrote: > On Sat, Mar 09, 2019 at 07:26:34AM +0530, Manivannan Sadhasivam wrote: > > For the AMBA Primecell devices having the reset lines wired, it is > > necessary to take them out of reset before reading the pid and cid

Re: [PATCH 1/2] amba: Take device out of reset before reading pid and cid values

2019-03-12 Thread Daniel Thompson
On Sat, Mar 09, 2019 at 07:26:34AM +0530, Manivannan Sadhasivam wrote: > For the AMBA Primecell devices having the reset lines wired, it is > necessary to take them out of reset before reading the pid and cid values. > Earlier we were dependent on the bootloader to do this but a more cleaner >

Re: [PATCH 1/2] amba: Take device out of reset before reading pid and cid values

2019-03-09 Thread Linus Walleij
On Sat, Mar 9, 2019 at 2:59 AM Manivannan Sadhasivam wrote: > For the AMBA Primecell devices having the reset lines wired, it is > necessary to take them out of reset before reading the pid and cid values. > Earlier we were dependent on the bootloader to do this but a more cleaner > approach

[PATCH 1/2] amba: Take device out of reset before reading pid and cid values

2019-03-08 Thread Manivannan Sadhasivam
For the AMBA Primecell devices having the reset lines wired, it is necessary to take them out of reset before reading the pid and cid values. Earlier we were dependent on the bootloader to do this but a more cleaner approach would be to do it in the kernel itself. Hence, this commit deasserts the