On Mon, 26 Oct 2015, Michal Marek wrote:
> Dne 18.10.2015 v 11:55 SF Markus Elfring napsal(a):
> >> Remove removal and re-addition of freeing functions.
> >
> > I find such a wording confusing for a commit message.
>
> It is also a bit confusing to use the same subject for two patches in a
>
Dne 18.10.2015 v 11:55 SF Markus Elfring napsal(a):
>> Remove removal and re-addition of freeing functions.
>
> I find such a wording confusing for a commit message.
It is also a bit confusing to use the same subject for two patches in a
series. How about
[PATCH 1/2] coccinelle: ifnullfree:
Dne 18.10.2015 v 11:55 SF Markus Elfring napsal(a):
>> Remove removal and re-addition of freeing functions.
>
> I find such a wording confusing for a commit message.
It is also a bit confusing to use the same subject for two patches in a
series. How about
[PATCH 1/2] coccinelle: ifnullfree:
On Mon, 26 Oct 2015, Michal Marek wrote:
> Dne 18.10.2015 v 11:55 SF Markus Elfring napsal(a):
> >> Remove removal and re-addition of freeing functions.
> >
> > I find such a wording confusing for a commit message.
>
> It is also a bit confusing to use the same subject for two patches in a
>
> Remove removal and re-addition of freeing functions.
I find such a wording confusing for a commit message.
> Add position variable on usb_free_urb in the non-patch case.
Is it interesting that this fix corresponds to a bug report from 2014-08-09?
https://lkml.org/lkml/2014/8/9/33
> Remove removal and re-addition of freeing functions.
I find such a wording confusing for a commit message.
> Add position variable on usb_free_urb in the non-patch case.
Is it interesting that this fix corresponds to a bug report from 2014-08-09?
https://lkml.org/lkml/2014/8/9/33
Adjust tests to compare against NULL, to match cases that explicitly make
that comparison.
Remove removal and re-addition of freeing functions.
Add position variable on usb_free_urb in the non-patch case.
Signed-off-by: Julia Lawall
---
scripts/coccinelle/free/ifnullfree.cocci | 18
Adjust tests to compare against NULL, to match cases that explicitly make
that comparison.
Remove removal and re-addition of freeing functions.
Add position variable on usb_free_urb in the non-patch case.
Signed-off-by: Julia Lawall
---
8 matches
Mail list logo