[PATCH 1/2] crypto: KEYS: convert public key to the akcipher api

This patch converts the module verification code to the new akcipher API. Signed-off-by: Tadeusz Struk --- crypto/asymmetric_keys/Kconfig|2 crypto/asymmetric_keys/Makefile |7 - crypto/asymmetric_keys/pkcs7_parser.c | 12 +-

[PATCH 1/2] crypto: KEYS: convert public key to the akcipher api

This patch converts the module verification code to the new akcipher API. Signed-off-by: Tadeusz Struk --- crypto/asymmetric_keys/Kconfig|2 crypto/asymmetric_keys/Makefile |7 - crypto/asymmetric_keys/pkcs7_parser.c | 12 +-

Re: [PATCH 1/2] crypto: KEYS: convert public key to the akcipher API

Hi Stephan, On 08/15/2015 11:08 AM, Stephan Mueller wrote: > Am Mittwoch, 12. August 2015, 20:54:39 schrieb Tadeusz Struk: > > Hi Tadeusz, > >> @@ -41,7 +41,7 @@ struct pkcs7_parse_context { >> static void pkcs7_free_signed_info(struct pkcs7_signed_info *sinfo) >> { >> if (sinfo) { >> -

Re: [PATCH 1/2] crypto: KEYS: convert public key to the akcipher API

Hi Stephan, On 08/15/2015 11:08 AM, Stephan Mueller wrote: Am Mittwoch, 12. August 2015, 20:54:39 schrieb Tadeusz Struk: Hi Tadeusz, @@ -41,7 +41,7 @@ struct pkcs7_parse_context { static void pkcs7_free_signed_info(struct pkcs7_signed_info *sinfo) { if (sinfo) { -

Re: [PATCH 1/2] crypto: KEYS: convert public key to the akcipher API

Am Mittwoch, 12. August 2015, 20:54:39 schrieb Tadeusz Struk: Hi Tadeusz, >@@ -41,7 +41,7 @@ struct pkcs7_parse_context { > static void pkcs7_free_signed_info(struct pkcs7_signed_info *sinfo) > { > if (sinfo) { >- mpi_free(sinfo->sig.mpi[0]); >+

Re: [PATCH 1/2] crypto: KEYS: convert public key to the akcipher API

Am Mittwoch, 12. August 2015, 20:54:39 schrieb Tadeusz Struk: Hi Tadeusz, @@ -41,7 +41,7 @@ struct pkcs7_parse_context { static void pkcs7_free_signed_info(struct pkcs7_signed_info *sinfo) { if (sinfo) { - mpi_free(sinfo-sig.mpi[0]); + kfree(sinfo-sig.s);

Re: [PATCH 1/2] crypto: KEYS: convert public key to the akcipher API

On Thu, Aug 13, 2015 at 03:23:16PM +0100, David Howells wrote: > > > - /* Decode the public key */ > > - ret = asn1_ber_decoder(_rsakey_decoder, ctx, > > - ctx->key, ctx->key_size); > > - if (ret < 0) > > + cert->pub->key = kmemdup(ctx->key, ctx->key_size,

Re: [PATCH 1/2] crypto: KEYS: convert public key to the akcipher API

On 08/13/2015 07:23 AM, David Howells wrote: > Tadeusz Struk wrote: > >> const char *const pkey_algo_name[PKEY_ALGO__LAST] = { >> -[PKEY_ALGO_DSA] = "DSA", >> -[PKEY_ALGO_RSA] = "RSA", >> +[PKEY_ALGO_DSA] = "dsa", >> +[PKEY_ALGO_RSA] = "rsa", >>

Re: [PATCH 1/2] crypto: KEYS: convert public key to the akcipher API

Tadeusz Struk wrote: > const char *const pkey_algo_name[PKEY_ALGO__LAST] = { > - [PKEY_ALGO_DSA] = "DSA", > - [PKEY_ALGO_RSA] = "RSA", > + [PKEY_ALGO_DSA] = "dsa", > + [PKEY_ALGO_RSA] = "rsa", > }; Be aware that these are exposed to userspace

Re: [PATCH 1/2] crypto: KEYS: convert public key to the akcipher API

Tadeusz Struk tadeusz.st...@intel.com wrote: const char *const pkey_algo_name[PKEY_ALGO__LAST] = { - [PKEY_ALGO_DSA] = DSA, - [PKEY_ALGO_RSA] = RSA, + [PKEY_ALGO_DSA] = dsa, + [PKEY_ALGO_RSA] = rsa, }; Be aware that these are exposed to

Re: [PATCH 1/2] crypto: KEYS: convert public key to the akcipher API

On 08/13/2015 07:23 AM, David Howells wrote: Tadeusz Struk tadeusz.st...@intel.com wrote: const char *const pkey_algo_name[PKEY_ALGO__LAST] = { -[PKEY_ALGO_DSA] = DSA, -[PKEY_ALGO_RSA] = RSA, +[PKEY_ALGO_DSA] = dsa, +[PKEY_ALGO_RSA] = rsa,

Re: [PATCH 1/2] crypto: KEYS: convert public key to the akcipher API

On Thu, Aug 13, 2015 at 03:23:16PM +0100, David Howells wrote: - /* Decode the public key */ - ret = asn1_ber_decoder(x509_rsakey_decoder, ctx, - ctx-key, ctx-key_size); - if (ret 0) + cert-pub-key = kmemdup(ctx-key, ctx-key_size, GFP_KERNEL); + if

[PATCH 1/2] crypto: KEYS: convert public key to the akcipher API

This patch converts the module verification code to the new akcipher API. RSA implementation from crypto/asymmetric_keys has been removed and the new API is used for cryptographic primitives. The signature verification has been moved into a new crypto/asymmetric_keys/rsa_pkcs1_v1_5.c file. There

[PATCH 1/2] crypto: KEYS: convert public key to the akcipher API

This patch converts the module verification code to the new akcipher API. RSA implementation from crypto/asymmetric_keys has been removed and the new API is used for cryptographic primitives. The signature verification has been moved into a new crypto/asymmetric_keys/rsa_pkcs1_v1_5.c file. There