Re: [PATCH 1/2] device.h: pack struct dev_links_info

2019-02-28 Thread Rafael J. Wysocki
On 2/28/2019 9:35 AM, Greg Kroah-Hartman wrote: On Wed, Feb 27, 2019 at 02:32:26PM +0100, Johan Hovold wrote: On Wed, Feb 27, 2019 at 01:06:45PM +0100, Greg Kroah-Hartman wrote: On Wed, Feb 27, 2019 at 11:59:51AM +0100, Johan Hovold wrote: Yeah, that is a good point, normally we use packed to

Re: [PATCH 1/2] device.h: pack struct dev_links_info

2019-02-28 Thread Greg Kroah-Hartman
On Wed, Feb 27, 2019 at 02:32:26PM +0100, Johan Hovold wrote: > On Wed, Feb 27, 2019 at 01:06:45PM +0100, Greg Kroah-Hartman wrote: > > On Wed, Feb 27, 2019 at 11:59:51AM +0100, Johan Hovold wrote: > > > Yeah, that is a good point, normally we use packed to keep padding from > > the middle of the

Re: [PATCH 1/2] device.h: pack struct dev_links_info

2019-02-27 Thread Johan Hovold
On Wed, Feb 27, 2019 at 01:06:45PM +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 27, 2019 at 11:59:51AM +0100, Johan Hovold wrote: > Yeah, that is a good point, normally we use packed to keep padding from > the middle of the structure from happening. > > I just don't like that 4 bytes sitting

Re: [PATCH 1/2] device.h: pack struct dev_links_info

2019-02-27 Thread Greg Kroah-Hartman
On Wed, Feb 27, 2019 at 11:59:51AM +0100, Johan Hovold wrote: > On Wed, Feb 27, 2019 at 10:54:24AM +0100, Greg Kroah-Hartman wrote: > > On Wed, Feb 27, 2019 at 10:40:21AM +0100, Johan Hovold wrote: > > > On Wed, Feb 27, 2019 at 10:31:04AM +0100, Greg Kroah-Hartman wrote: > > > > On Wed, Feb 27,

Re: [PATCH 1/2] device.h: pack struct dev_links_info

2019-02-27 Thread Johan Hovold
On Wed, Feb 27, 2019 at 10:54:24AM +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 27, 2019 at 10:40:21AM +0100, Johan Hovold wrote: > > On Wed, Feb 27, 2019 at 10:31:04AM +0100, Greg Kroah-Hartman wrote: > > > On Wed, Feb 27, 2019 at 10:23:18AM +0100, Johan Hovold wrote: > > > > On Tue, Feb 26,

Re: [PATCH 1/2] device.h: pack struct dev_links_info

2019-02-27 Thread Greg Kroah-Hartman
On Wed, Feb 27, 2019 at 10:40:21AM +0100, Johan Hovold wrote: > On Wed, Feb 27, 2019 at 10:31:04AM +0100, Greg Kroah-Hartman wrote: > > On Wed, Feb 27, 2019 at 10:23:18AM +0100, Johan Hovold wrote: > > > On Tue, Feb 26, 2019 at 03:41:07PM +0100, Greg Kroah-Hartman wrote: > > > > The dev_links_info

Re: [PATCH 1/2] device.h: pack struct dev_links_info

2019-02-27 Thread Johan Hovold
On Wed, Feb 27, 2019 at 10:31:04AM +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 27, 2019 at 10:23:18AM +0100, Johan Hovold wrote: > > On Tue, Feb 26, 2019 at 03:41:07PM +0100, Greg Kroah-Hartman wrote: > > > The dev_links_info structure has 4 bytes of padding at the end of it > > > when embedded

Re: [PATCH 1/2] device.h: pack struct dev_links_info

2019-02-27 Thread Greg Kroah-Hartman
On Wed, Feb 27, 2019 at 10:23:18AM +0100, Johan Hovold wrote: > On Tue, Feb 26, 2019 at 03:41:07PM +0100, Greg Kroah-Hartman wrote: > > The dev_links_info structure has 4 bytes of padding at the end of it > > when embedded in struct device (which is the only place it lives). To > > help reduce

Re: [PATCH 1/2] device.h: pack struct dev_links_info

2019-02-27 Thread Johan Hovold
On Tue, Feb 26, 2019 at 03:41:07PM +0100, Greg Kroah-Hartman wrote: > The dev_links_info structure has 4 bytes of padding at the end of it > when embedded in struct device (which is the only place it lives). To > help reduce the size of struct device pack this structure so we can take > advantage

Re: [PATCH 1/2] device.h: pack struct dev_links_info

2019-02-26 Thread Rafael J. Wysocki
On 2/26/2019 3:41 PM, Greg Kroah-Hartman wrote: The dev_links_info structure has 4 bytes of padding at the end of it when embedded in struct device (which is the only place it lives). To help reduce the size of struct device pack this structure so we can take advantage of the hole with later

[PATCH 1/2] device.h: pack struct dev_links_info

2019-02-26 Thread Greg Kroah-Hartman
The dev_links_info structure has 4 bytes of padding at the end of it when embedded in struct device (which is the only place it lives). To help reduce the size of struct device pack this structure so we can take advantage of the hole with later structure reorganizations. Cc: "Rafael J. Wysocki"