Re: [PATCH 1/2] devtmpfs: fix placement of complete() call

2021-03-18 Thread Greg Kroah-Hartman
On Thu, Mar 18, 2021 at 01:44:04PM +0100, Rasmus Villemoes wrote: > On 12/03/2021 11.30, Rasmus Villemoes wrote: > > Calling complete() from within the __init function is wrong - > > theoretically, the init process could proceed all the way to freeing > > the init mem before the devtmpfsd thread

Re: [PATCH 1/2] devtmpfs: fix placement of complete() call

2021-03-18 Thread Rasmus Villemoes
On 12/03/2021 11.30, Rasmus Villemoes wrote: > Calling complete() from within the __init function is wrong - > theoretically, the init process could proceed all the way to freeing > the init mem before the devtmpfsd thread gets to execute the return > instruction in devtmpfs_setup(). Greg, ping?

Re: [PATCH 1/2] devtmpfs: fix placement of complete() call

2021-03-12 Thread Christoph Hellwig
Looks fine: Reviewed-by: Christoph Hellwig

[PATCH 1/2] devtmpfs: fix placement of complete() call

2021-03-12 Thread Rasmus Villemoes
Calling complete() from within the __init function is wrong - theoretically, the init process could proceed all the way to freeing the init mem before the devtmpfsd thread gets to execute the return instruction in devtmpfs_setup(). In practice, it seems to be harmless as gcc inlines