Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 11/3/2015 7:42 AM, Arnd Bergmann wrote: You have a distinct "compatible" string for qemu, right? It sounds like this is not the same device if the dependencies are different, and you could just have two ways to probe the same device. No, it is the same dma channel object that gets probed

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

Arnd Bergmann wrote: If you change the order in the Makefile, the management driver should always get probed first if both are built-in. When the driver is a loadable module, the ordering should work because of the way that the modules are loaded. This sounds like something that should be

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Monday 02 November 2015 23:45:17 Sinan Kaya wrote: > On 11/2/2015 4:30 PM, Arnd Bergmann wrote: > > On Saturday 31 October 2015 02:51:46 Sinan Kaya wrote: > >> On 10/30/2015 5:34 AM, Arnd Bergmann wrote: > >>> On Thursday 29 October 2015 23:08:12 Sinan Kaya wrote: > >> This will be used by the

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Monday 02 November 2015 23:45:17 Sinan Kaya wrote: > On 11/2/2015 4:30 PM, Arnd Bergmann wrote: > > On Saturday 31 October 2015 02:51:46 Sinan Kaya wrote: > >> On 10/30/2015 5:34 AM, Arnd Bergmann wrote: > >>> On Thursday 29 October 2015 23:08:12 Sinan Kaya wrote: > >> This will be used by the

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 11/3/2015 7:42 AM, Arnd Bergmann wrote: You have a distinct "compatible" string for qemu, right? It sounds like this is not the same device if the dependencies are different, and you could just have two ways to probe the same device. No, it is the same dma channel object that gets probed

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

Arnd Bergmann wrote: If you change the order in the Makefile, the management driver should always get probed first if both are built-in. When the driver is a loadable module, the ordering should work because of the way that the modules are loaded. This sounds like something that should be

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 11/2/2015 4:30 PM, Arnd Bergmann wrote: On Saturday 31 October 2015 02:51:46 Sinan Kaya wrote: On 10/30/2015 5:34 AM, Arnd Bergmann wrote: On Thursday 29 October 2015 23:08:12 Sinan Kaya wrote: diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Saturday 31 October 2015 02:51:46 Sinan Kaya wrote: > On 10/30/2015 5:34 AM, Arnd Bergmann wrote: > > On Thursday 29 October 2015 23:08:12 Sinan Kaya wrote: > >> diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > >>

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Saturday 31 October 2015 02:51:46 Sinan Kaya wrote: > On 10/30/2015 5:34 AM, Arnd Bergmann wrote: > > On Thursday 29 October 2015 23:08:12 Sinan Kaya wrote: > >> diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > >>

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 11/2/2015 4:30 PM, Arnd Bergmann wrote: On Saturday 31 October 2015 02:51:46 Sinan Kaya wrote: On 10/30/2015 5:34 AM, Arnd Bergmann wrote: On Thursday 29 October 2015 23:08:12 Sinan Kaya wrote: diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 10/30/2015 11:33 PM, Jon Masters wrote: Hi Andy, On 10/30/2015 04:15 PM, Andy Shevchenko wrote: On Fri, Oct 30, 2015 at 10:08 PM, Al Stone wrote: On 10/30/2015 01:01 PM, Mark Rutland wrote: On Fri, Oct 30, 2015 at 02:48:06PM -0400, Sinan Kaya wrote: The CSRT is listed under "Want",

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 10/30/2015 11:00 AM, Mark Rutland wrote: On Thu, Oct 29, 2015 at 11:08:12PM -0400, Sinan Kaya wrote: The Qualcomm Technologies HIDMA device has been designed to support virtualization technology. The driver has been divided into two to follow the hardware design. The management driver is

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

Sinan Kaya wrote: I expect this driver to grow in functionality over time. Right now, it does the global init for the DMA. After that all channels execute on their own without depending on each other. Global init has to be done first before attempting to do any channel initialization. There is

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

Sinan Kaya wrote: I expect this driver to grow in functionality over time. Right now, it does the global init for the DMA. After that all channels execute on their own without depending on each other. Global init has to be done first before attempting to do any channel initialization. There is

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 10/30/2015 5:34 AM, Arnd Bergmann wrote: On Thursday 29 October 2015 23:08:12 Sinan Kaya wrote: diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt new file mode 100644 index 000..81674ab --- /dev/null +++

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 10/30/2015 5:34 AM, Arnd Bergmann wrote: On Thursday 29 October 2015 23:08:12 Sinan Kaya wrote: diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt new file mode 100644 index 000..81674ab --- /dev/null +++

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

Sinan Kaya wrote: I expect this driver to grow in functionality over time. Right now, it does the global init for the DMA. After that all channels execute on their own without depending on each other. Global init has to be done first before attempting to do any channel initialization. There is

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

Sinan Kaya wrote: I expect this driver to grow in functionality over time. Right now, it does the global init for the DMA. After that all channels execute on their own without depending on each other. Global init has to be done first before attempting to do any channel initialization. There is

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 10/30/2015 11:33 PM, Jon Masters wrote: Hi Andy, On 10/30/2015 04:15 PM, Andy Shevchenko wrote: On Fri, Oct 30, 2015 at 10:08 PM, Al Stone wrote: On 10/30/2015 01:01 PM, Mark Rutland wrote: On Fri, Oct 30, 2015 at 02:48:06PM -0400, Sinan Kaya wrote: The CSRT is

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 10/30/2015 11:00 AM, Mark Rutland wrote: On Thu, Oct 29, 2015 at 11:08:12PM -0400, Sinan Kaya wrote: The Qualcomm Technologies HIDMA device has been designed to support virtualization technology. The driver has been divided into two to follow the hardware design. The management driver is

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

Hi Andy, On 10/30/2015 04:15 PM, Andy Shevchenko wrote: > On Fri, Oct 30, 2015 at 10:08 PM, Al Stone wrote: >> On 10/30/2015 01:01 PM, Mark Rutland wrote: >>> On Fri, Oct 30, 2015 at 02:48:06PM -0400, Sinan Kaya wrote: > >>> The CSRT is listed under "Want", not "Never" or "Don't Care", so

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Fri, Oct 30, 2015 at 10:15:09PM +0200, Andy Shevchenko wrote: > On Fri, Oct 30, 2015 at 10:08 PM, Al Stone wrote: > > On 10/30/2015 01:01 PM, Mark Rutland wrote: > >> On Fri, Oct 30, 2015 at 02:48:06PM -0400, Sinan Kaya wrote: > > >> The CSRT is listed under "Want", not "Never" or "Don't

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Fri, Oct 30, 2015 at 10:08 PM, Al Stone wrote: > On 10/30/2015 01:01 PM, Mark Rutland wrote: >> On Fri, Oct 30, 2015 at 02:48:06PM -0400, Sinan Kaya wrote: >> The CSRT is listed under "Want", not "Never" or "Don't Care", so Linaro >> have certainly not said that CSRT will not be supported. If

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 10/30/2015 01:01 PM, Mark Rutland wrote: > On Fri, Oct 30, 2015 at 02:48:06PM -0400, Sinan Kaya wrote: >> It was decided by >> Linaro that CSRT will not be supported for ARM64. Hrm. I personally decided we didn't have to worry about using the CSRT (specifically, let's wait until

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 10/30/2015 2:25 PM, Mark Rutland wrote: It does appear that it's not relevant to this device and driver, given the lack of clients, unless I've misunderstood? You are right. Kernel and guest machine kernel are the only user of this DMA device. No other HW devices. -- Sinan Kaya

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Fri, Oct 30, 2015 at 02:48:06PM -0400, Sinan Kaya wrote: > It was decided by > Linaro that CSRT will not be supported for ARM64. > See this. > > https://wiki.linaro.org/LEG/Engineering/Kernel/ACPI/TablePriorities The CSRT is listed under "Want", not "Never" or "Don't Care", so Linaro

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 10/30/2015 2:40 PM, Andy Shevchenko wrote: On Fri, Oct 30, 2015 at 8:25 PM, Mark Rutland wrote: CSRT is an Intel specific ACPI table for slave devices. Wrong. It was designed by Microsoft to support multiple controllers, in particular DMACs. Have you read that document I posted link

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Fri, Oct 30, 2015 at 8:25 PM, Mark Rutland wrote: >> > CSRT is an Intel specific ACPI table for slave devices. >> >> Wrong. >> It was designed by Microsoft to support multiple controllers, in >> particular DMACs. >> Have you read that document I posted link to? >> >> > It was decided by >> >

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Fri, Oct 30, 2015 at 08:18:49PM +0200, Andy Shevchenko wrote: > On Fri, Oct 30, 2015 at 8:08 PM, Sinan Kaya wrote: > > >> The ACPI tables DSDT and CSRT (more info here: > >> http://www.acpi.info/links.htm) defines properties. > >> > >> DSDT: > >> per DMAC: the resources > >> per client:

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Fri, Oct 30, 2015 at 02:08:07PM -0400, Sinan Kaya wrote: > > > On 10/30/2015 1:59 PM, Andy Shevchenko wrote: > >On Fri, Oct 30, 2015 at 5:00 PM, Mark Rutland wrote: > >>On Thu, Oct 29, 2015 at 11:08:12PM -0400, Sinan Kaya wrote: > >>>The Qualcomm Technologies HIDMA device has been designed >

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Fri, Oct 30, 2015 at 8:08 PM, Sinan Kaya wrote: >> The ACPI tables DSDT and CSRT (more info here: >> http://www.acpi.info/links.htm) defines properties. >> >> DSDT: >> per DMAC: the resources >> per client: FixedDMA descriptor that contains channel / request line >> pair. >> >> CSRT: >>

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 10/30/2015 1:59 PM, Andy Shevchenko wrote: On Fri, Oct 30, 2015 at 5:00 PM, Mark Rutland wrote: On Thu, Oct 29, 2015 at 11:08:12PM -0400, Sinan Kaya wrote: The Qualcomm Technologies HIDMA device has been designed to support virtualization technology. The driver has been divided into two

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Fri, Oct 30, 2015 at 5:00 PM, Mark Rutland wrote: > On Thu, Oct 29, 2015 at 11:08:12PM -0400, Sinan Kaya wrote: >> The Qualcomm Technologies HIDMA device has been designed >> to support virtualization technology. The driver has been >> divided into two to follow the hardware design. The

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Thu, Oct 29, 2015 at 11:08:12PM -0400, Sinan Kaya wrote: > The Qualcomm Technologies HIDMA device has been designed > to support virtualization technology. The driver has been > divided into two to follow the hardware design. The management > driver is executed in hypervisor context and is the

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Thursday 29 October 2015 23:08:12 Sinan Kaya wrote: > diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > new file mode 100644 > index 000..81674ab > --- /dev/null > +++

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Fri, Oct 30, 2015 at 10:15:09PM +0200, Andy Shevchenko wrote: > On Fri, Oct 30, 2015 at 10:08 PM, Al Stone wrote: > > On 10/30/2015 01:01 PM, Mark Rutland wrote: > >> On Fri, Oct 30, 2015 at 02:48:06PM -0400, Sinan Kaya wrote: > > >> The CSRT is listed under "Want", not

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Thursday 29 October 2015 23:08:12 Sinan Kaya wrote: > diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > new file mode 100644 > index 000..81674ab > --- /dev/null > +++

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

Hi Andy, On 10/30/2015 04:15 PM, Andy Shevchenko wrote: > On Fri, Oct 30, 2015 at 10:08 PM, Al Stone wrote: >> On 10/30/2015 01:01 PM, Mark Rutland wrote: >>> On Fri, Oct 30, 2015 at 02:48:06PM -0400, Sinan Kaya wrote: > >>> The CSRT is listed under "Want", not "Never" or

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Thu, Oct 29, 2015 at 11:08:12PM -0400, Sinan Kaya wrote: > The Qualcomm Technologies HIDMA device has been designed > to support virtualization technology. The driver has been > divided into two to follow the hardware design. The management > driver is executed in hypervisor context and is the

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 10/30/2015 2:25 PM, Mark Rutland wrote: It does appear that it's not relevant to this device and driver, given the lack of clients, unless I've misunderstood? You are right. Kernel and guest machine kernel are the only user of this DMA device. No other HW devices. -- Sinan Kaya

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Fri, Oct 30, 2015 at 8:25 PM, Mark Rutland wrote: >> > CSRT is an Intel specific ACPI table for slave devices. >> >> Wrong. >> It was designed by Microsoft to support multiple controllers, in >> particular DMACs. >> Have you read that document I posted link to? >> >> >

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 10/30/2015 2:40 PM, Andy Shevchenko wrote: On Fri, Oct 30, 2015 at 8:25 PM, Mark Rutland wrote: CSRT is an Intel specific ACPI table for slave devices. Wrong. It was designed by Microsoft to support multiple controllers, in particular DMACs. Have you read that

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Fri, Oct 30, 2015 at 02:48:06PM -0400, Sinan Kaya wrote: > It was decided by > Linaro that CSRT will not be supported for ARM64. > See this. > > https://wiki.linaro.org/LEG/Engineering/Kernel/ACPI/TablePriorities The CSRT is listed under "Want", not "Never" or "Don't Care", so Linaro

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 10/30/2015 1:59 PM, Andy Shevchenko wrote: On Fri, Oct 30, 2015 at 5:00 PM, Mark Rutland wrote: On Thu, Oct 29, 2015 at 11:08:12PM -0400, Sinan Kaya wrote: The Qualcomm Technologies HIDMA device has been designed to support virtualization technology. The driver has

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Fri, Oct 30, 2015 at 08:18:49PM +0200, Andy Shevchenko wrote: > On Fri, Oct 30, 2015 at 8:08 PM, Sinan Kaya wrote: > > >> The ACPI tables DSDT and CSRT (more info here: > >> http://www.acpi.info/links.htm) defines properties. > >> > >> DSDT: > >> per DMAC: the

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Fri, Oct 30, 2015 at 5:00 PM, Mark Rutland wrote: > On Thu, Oct 29, 2015 at 11:08:12PM -0400, Sinan Kaya wrote: >> The Qualcomm Technologies HIDMA device has been designed >> to support virtualization technology. The driver has been >> divided into two to follow the

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Fri, Oct 30, 2015 at 02:08:07PM -0400, Sinan Kaya wrote: > > > On 10/30/2015 1:59 PM, Andy Shevchenko wrote: > >On Fri, Oct 30, 2015 at 5:00 PM, Mark Rutland wrote: > >>On Thu, Oct 29, 2015 at 11:08:12PM -0400, Sinan Kaya wrote: > >>>The Qualcomm Technologies HIDMA

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Fri, Oct 30, 2015 at 8:08 PM, Sinan Kaya wrote: >> The ACPI tables DSDT and CSRT (more info here: >> http://www.acpi.info/links.htm) defines properties. >> >> DSDT: >> per DMAC: the resources >> per client: FixedDMA descriptor that contains channel / request line >>

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On 10/30/2015 01:01 PM, Mark Rutland wrote: > On Fri, Oct 30, 2015 at 02:48:06PM -0400, Sinan Kaya wrote: >> It was decided by >> Linaro that CSRT will not be supported for ARM64. Hrm. I personally decided we didn't have to worry about using the CSRT (specifically, let's wait until

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

On Fri, Oct 30, 2015 at 10:08 PM, Al Stone wrote: > On 10/30/2015 01:01 PM, Mark Rutland wrote: >> On Fri, Oct 30, 2015 at 02:48:06PM -0400, Sinan Kaya wrote: >> The CSRT is listed under "Want", not "Never" or "Don't Care", so Linaro >> have certainly not said that CSRT will

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

Hi Sinan, [auto build test WARNING on lwn/docs-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Sinan-Kaya/dma-add-Qualcomm-Technologies-HIDMA-management-driver/20151030-111408 coccinelle warnings:

[PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

The Qualcomm Technologies HIDMA device has been designed to support virtualization technology. The driver has been divided into two to follow the hardware design. The management driver is executed in hypervisor context and is the main managment for all channels provided by the device. The channel

[PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

The Qualcomm Technologies HIDMA device has been designed to support virtualization technology. The driver has been divided into two to follow the hardware design. The management driver is executed in hypervisor context and is the main managment for all channels provided by the device. The channel

Re: [PATCH 1/2] dma: add Qualcomm Technologies HIDMA management driver

Hi Sinan, [auto build test WARNING on lwn/docs-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Sinan-Kaya/dma-add-Qualcomm-Technologies-HIDMA-management-driver/20151030-111408 coccinelle warnings: