Re: [PATCH 1/2] drivers/media/platform/soc_camera/pxa_camera.c: reposition free_irq to avoid access to invalid data

2013-01-07 Thread Julia Lawall
On Mon, 7 Jan 2013, Robert Jarzmik wrote: > Guennadi Liakhovetski writes: > > > (adding Robert to CC) > > I don't think any data is freed by pxa_free_dma(), it only disables DMA on > > a certain channel. Theoretically there could be a different problem: > > pxa_free_dma() deactivates DMA, wher

Re: [PATCH 1/2] drivers/media/platform/soc_camera/pxa_camera.c: reposition free_irq to avoid access to invalid data

2013-01-07 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > (adding Robert to CC) > I don't think any data is freed by pxa_free_dma(), it only disables DMA on > a certain channel. Theoretically there could be a different problem: > pxa_free_dma() deactivates DMA, whereas pxa_dma_start_channels() activates > it. But I thi

Re: [PATCH 1/2] drivers/media/platform/soc_camera/pxa_camera.c: reposition free_irq to avoid access to invalid data

2013-01-07 Thread Guennadi Liakhovetski
On Mon, 7 Jan 2013, Julia Lawall wrote: > On Mon, 7 Jan 2013, Guennadi Liakhovetski wrote: > > > (adding Robert to CC) > > > > Hi Julia > > > > Thanks for the patch. > > > > On Mon, 7 Jan 2013, Julia Lawall wrote: > > > > > From: Julia Lawall > > > > > > The data referenced by an interrupt handl

Re: [PATCH 1/2] drivers/media/platform/soc_camera/pxa_camera.c: reposition free_irq to avoid access to invalid data

2013-01-07 Thread Julia Lawall
On Mon, 7 Jan 2013, Guennadi Liakhovetski wrote: > (adding Robert to CC) > > Hi Julia > > Thanks for the patch. > > On Mon, 7 Jan 2013, Julia Lawall wrote: > > > From: Julia Lawall > > > > The data referenced by an interrupt handler should not be freed before the > > interrupt is ended. The hand

Re: [PATCH 1/2] drivers/media/platform/soc_camera/pxa_camera.c: reposition free_irq to avoid access to invalid data

2013-01-07 Thread Guennadi Liakhovetski
(adding Robert to CC) Hi Julia Thanks for the patch. On Mon, 7 Jan 2013, Julia Lawall wrote: > From: Julia Lawall > > The data referenced by an interrupt handler should not be freed before the > interrupt is ended. The handler is pxa_camera_irq. This handler may call > pxa_dma_start_channel

[PATCH 1/2] drivers/media/platform/soc_camera/pxa_camera.c: reposition free_irq to avoid access to invalid data

2013-01-07 Thread Julia Lawall
From: Julia Lawall The data referenced by an interrupt handler should not be freed before the interrupt is ended. The handler is pxa_camera_irq. This handler may call pxa_dma_start_channels, which references the channels that are freed on the lines before the call to free_irq. The semantic mat