Re: [PATCH 1/2] drm: Improve drm_of_component_probe() to correctly handle ports and remote ports.

2015-11-16 Thread Russell King - ARM Linux
On Mon, Nov 16, 2015 at 09:17:35PM +, Liviu Dudau wrote: > On Mon, Nov 16, 2015 at 05:22:48PM +, Russell King - ARM Linux wrote: > > Put those two sentences together and please think about it. If the > > pointer type is unknown to component_match_add(), how could it ever > > use of_node_ge

Re: [PATCH 1/2] drm: Improve drm_of_component_probe() to correctly handle ports and remote ports.

2015-11-16 Thread Liviu Dudau
On Mon, Nov 16, 2015 at 05:22:48PM +, Russell King - ARM Linux wrote: > Please sensibly wrap your messages. Your lines are longer than 80 characters > which makes it exceedingly difficult for some people to reply to your very > very very very very very very very very very very very very very

Re: [PATCH 1/2] drm: Improve drm_of_component_probe() to correctly handle ports and remote ports.

2015-11-16 Thread Russell King - ARM Linux
On Mon, Nov 16, 2015 at 05:48:32PM +, Daniel Stone wrote: > On 16 November 2015 at 17:43, Russell King - ARM Linux > wrote: > > On Mon, Nov 16, 2015 at 05:32:05PM +, Daniel Stone wrote: > >> On 16 November 2015 at 17:22, Russell King - ARM Linux > >> wrote: > >> > Please sensibly wrap you

Re: [PATCH 1/2] drm: Improve drm_of_component_probe() to correctly handle ports and remote ports.

2015-11-16 Thread Daniel Stone
On 16 November 2015 at 17:43, Russell King - ARM Linux wrote: > On Mon, Nov 16, 2015 at 05:32:05PM +, Daniel Stone wrote: >> On 16 November 2015 at 17:22, Russell King - ARM Linux >> wrote: >> > Please sensibly wrap your messages. Your lines are longer than 80 >> > characters which makes it

Re: [PATCH 1/2] drm: Improve drm_of_component_probe() to correctly handle ports and remote ports.

2015-11-16 Thread Russell King - ARM Linux
On Mon, Nov 16, 2015 at 05:32:05PM +, Daniel Stone wrote: > On 16 November 2015 at 17:22, Russell King - ARM Linux > wrote: > > Please sensibly wrap your messages. Your lines are longer than 80 > > characters which makes it exceedingly difficult for some people to reply > > to your very very

Re: [PATCH 1/2] drm: Improve drm_of_component_probe() to correctly handle ports and remote ports.

2015-11-16 Thread Daniel Stone
On 16 November 2015 at 17:22, Russell King - ARM Linux wrote: > Please sensibly wrap your messages. Your lines are longer than 80 > characters which makes it exceedingly difficult for some people to reply > to your very very very very very very very very very very very very > very very very very

Re: [PATCH 1/2] drm: Improve drm_of_component_probe() to correctly handle ports and remote ports.

2015-11-16 Thread Russell King - ARM Linux
Please sensibly wrap your messages. Your lines are longer than 80 characters which makes it exceedingly difficult for some people to reply to your very very very very very very very very very very very very very very very very very very very very very very very very very very very very very ver

Re: [PATCH 1/2] drm: Improve drm_of_component_probe() to correctly handle ports and remote ports.

2015-11-16 Thread Liviu Dudau
On Mon, Nov 16, 2015 at 04:22:41PM +, Russell King - ARM Linux wrote: > On Mon, Nov 16, 2015 at 02:44:52PM +, Liviu Dudau wrote: > > Rockchip DRM driver cannot use the same compare_of() function to match > > ports and remote ports (aka encoders) as their OF sub-trees look different. > > Add

Re: [PATCH 1/2] drm: Improve drm_of_component_probe() to correctly handle ports and remote ports.

2015-11-16 Thread Russell King - ARM Linux
On Mon, Nov 16, 2015 at 02:44:52PM +, Liviu Dudau wrote: > Rockchip DRM driver cannot use the same compare_of() function to match > ports and remote ports (aka encoders) as their OF sub-trees look different. > Add a second compare function to be used when encoders are added to the > component f

[PATCH 1/2] drm: Improve drm_of_component_probe() to correctly handle ports and remote ports.

2015-11-16 Thread Liviu Dudau
Rockchip DRM driver cannot use the same compare_of() function to match ports and remote ports (aka encoders) as their OF sub-trees look different. Add a second compare function to be used when encoders are added to the component framework and patch the existing users of the function accordingly. S