Re: [PATCH 1/2] extcon: ptn5150: Use defines for registers

2020-09-11 Thread Krzysztof Kozlowski
On Fri, Sep 11, 2020 at 05:03:02PM +0900, Chanwoo Choi wrote: > On 9/11/20 2:38 PM, Krzysztof Kozlowski wrote: > > On Fri, Sep 11, 2020 at 12:14:19PM +0900, Chanwoo Choi wrote: > >> On 9/10/20 12:01 AM, Krzysztof Kozlowski wrote: > >>> The register addresses are not continuous, so use simple

Re: [PATCH 1/2] extcon: ptn5150: Use defines for registers

2020-09-11 Thread Chanwoo Choi
On 9/11/20 2:38 PM, Krzysztof Kozlowski wrote: > On Fri, Sep 11, 2020 at 12:14:19PM +0900, Chanwoo Choi wrote: >> On 9/10/20 12:01 AM, Krzysztof Kozlowski wrote: >>> The register addresses are not continuous, so use simple defines for >>> them. This also makes it easier to find the address for

Re: [PATCH 1/2] extcon: ptn5150: Use defines for registers

2020-09-10 Thread Krzysztof Kozlowski
On Fri, Sep 11, 2020 at 12:14:19PM +0900, Chanwoo Choi wrote: > On 9/10/20 12:01 AM, Krzysztof Kozlowski wrote: > > The register addresses are not continuous, so use simple defines for > > them. This also makes it easier to find the address for register. > > > > No functional change. > > > >

Re: [PATCH 1/2] extcon: ptn5150: Use defines for registers

2020-09-10 Thread Chanwoo Choi
On 9/10/20 12:01 AM, Krzysztof Kozlowski wrote: > The register addresses are not continuous, so use simple defines for > them. This also makes it easier to find the address for register. > > No functional change. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/extcon/extcon-ptn5150.c |

[PATCH 1/2] extcon: ptn5150: Use defines for registers

2020-09-09 Thread Krzysztof Kozlowski
The register addresses are not continuous, so use simple defines for them. This also makes it easier to find the address for register. No functional change. Signed-off-by: Krzysztof Kozlowski --- drivers/extcon/extcon-ptn5150.c | 22 ++ 1 file changed, 10 insertions(+), 12