Re: [PATCH 1/2] fork: add clone6

2019-05-30 Thread Kees Cook
On Mon, May 27, 2019 at 09:36:18PM +0200, Jann Horn wrote: > +Kees > > On Mon, May 27, 2019 at 9:27 PM Linus Torvalds > wrote: > > On Mon, May 27, 2019 at 3:42 AM Christian Brauner > > wrote: > > > Hm, still pondering whether having one unsigned int argument passed > > > through registers that

Re: [PATCH 1/2] fork: add clone6

2019-05-28 Thread Eric W. Biederman
Christian Brauner writes: > This adds the clone6 system call. > > As mentioned several times already (cf. [7], [8]) here's the promised > patchset for clone6(). > > We recently merged the CLONE_PIDFD patchset (cf. [1]). It took the last > free flag from clone(). > > Independent of the

Re: [PATCH 1/2] fork: add clone6

2019-05-28 Thread Andy Lutomirski
On Tue, May 28, 2019 at 3:08 AM Christian Brauner wrote: > > On Mon, May 27, 2019 at 12:27:08PM -0700, Linus Torvalds wrote: > > On Mon, May 27, 2019 at 3:42 AM Christian Brauner > > wrote: > > > > > > Hm, still pondering whether having one unsigned int argument passed > > > through registers

Re: [PATCH 1/2] fork: add clone6

2019-05-28 Thread Christian Brauner
On Mon, May 27, 2019 at 12:27:08PM -0700, Linus Torvalds wrote: > On Mon, May 27, 2019 at 3:42 AM Christian Brauner > wrote: > > > > Hm, still pondering whether having one unsigned int argument passed > > through registers that captures all the flags from the old clone() would > > be a good

Re: [PATCH 1/2] fork: add clone6

2019-05-27 Thread Jann Horn
+Kees On Mon, May 27, 2019 at 9:27 PM Linus Torvalds wrote: > On Mon, May 27, 2019 at 3:42 AM Christian Brauner > wrote: > > Hm, still pondering whether having one unsigned int argument passed > > through registers that captures all the flags from the old clone() would > > be a good idea. > >

Re: [PATCH 1/2] fork: add clone6

2019-05-27 Thread Linus Torvalds
On Mon, May 27, 2019 at 3:42 AM Christian Brauner wrote: > > Hm, still pondering whether having one unsigned int argument passed > through registers that captures all the flags from the old clone() would > be a good idea. That sounds like a reasonable thing to do. Maybe we could continue to

Re: [PATCH 1/2] fork: add clone6

2019-05-27 Thread Christian Brauner
Moin, Wasn't near a computer yesterday so sorry for the late reply. :) I (I should note that this was supposed to be prefixed with RFC. But *shrug*.) On Sun, May 26, 2019 at 09:50:32AM -0700, Linus Torvalds wrote: > On Sun, May 26, 2019 at 3:27 AM Christian Brauner > wrote: > > > > This adds

Re: [PATCH 1/2] fork: add clone6

2019-05-26 Thread Linus Torvalds
On Sun, May 26, 2019 at 3:27 AM Christian Brauner wrote: > > This adds the clone6 system call. No, this is not acceptable. > + struct clone6_args args = { First of all, we don't pass in "clone6_args" to the actual implementation. Passing in lots of args as a structure is fine. But it

[PATCH 1/2] fork: add clone6

2019-05-26 Thread Christian Brauner
This adds the clone6 system call. As mentioned several times already (cf. [7], [8]) here's the promised patchset for clone6(). We recently merged the CLONE_PIDFD patchset (cf. [1]). It took the last free flag from clone(). Independent of the CLONE_PIDFD patchset a time namespace has been