Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-02-02 Thread Boris Brezillon
On Thu, 2 Feb 2017 11:53:17 +0100 Linus Walleij wrote: > On Mon, Jan 30, 2017 at 4:41 PM, Boris Brezillon > wrote: > > > Rename devm_get_gpiod_from_child() into > > devm_fwnode_get_gpiod_from_child() to reflect the fact that this > > function is operating on a fwnode object. > > > > Signed-off-

Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-02-02 Thread Linus Walleij
On Mon, Jan 30, 2017 at 4:41 PM, Boris Brezillon wrote: > Rename devm_get_gpiod_from_child() into > devm_fwnode_get_gpiod_from_child() to reflect the fact that this > function is operating on a fwnode object. > > Signed-off-by: Boris Brezillon All right! So we settled we're gonna merge this and

Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-02-02 Thread Mika Westerberg
On Wed, Feb 01, 2017 at 03:51:06PM +0100, Linus Walleij wrote: > fwnode_get_named_gpiod() > devm_get_gpiod_from_child() > > Both are taking a fwnode as argument and the naming is as > inconsistent as it can be. > > Some more churn should be expected as a side > effect of naming this function wron

Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-02-01 Thread Dmitry Torokhov
On Wed, Feb 01, 2017 at 03:51:06PM +0100, Linus Walleij wrote: > On Wed, Feb 1, 2017 at 2:22 PM, Boris Brezillon > wrote: > > On Wed, 1 Feb 2017 14:05:43 +0100 > > Linus Walleij wrote: > > >> > Linus, is this something you really care about? If that's the case, can > >> > you step in? > >> > >>

Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-02-01 Thread Dmitry Torokhov
On Mon, Jan 30, 2017 at 04:41:48PM +0100, Boris Brezillon wrote: > Rename devm_get_gpiod_from_child() into > devm_fwnode_get_gpiod_from_child() to reflect the fact that this > function is operating on a fwnode object. > > Signed-off-by: Boris Brezillon > --- > drivers/gpio/devres.c

Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-02-01 Thread Linus Walleij
On Wed, Feb 1, 2017 at 2:22 PM, Boris Brezillon wrote: > On Wed, 1 Feb 2017 14:05:43 +0100 > Linus Walleij wrote: >> > Linus, is this something you really care about? If that's the case, can >> > you step in? >> >> I can only throw up my hands... > > Sorry for forcing your hand like this, but th

Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-02-01 Thread Boris Brezillon
Hi Linus, On Wed, 1 Feb 2017 14:05:43 +0100 Linus Walleij wrote: > On Tue, Jan 31, 2017 at 8:42 PM, Boris Brezillon > wrote: > > On Tue, 31 Jan 2017 10:39:36 -0800 > > Dmitry Torokhov wrote: > > >> Hmm, yeah, I agree, that would be weird. Then let's leave > >> devm_get_gpiod_from_child() as

Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-02-01 Thread Linus Walleij
On Tue, Jan 31, 2017 at 8:42 PM, Boris Brezillon wrote: > On Tue, 31 Jan 2017 10:39:36 -0800 > Dmitry Torokhov wrote: >> Hmm, yeah, I agree, that would be weird. Then let's leave >> devm_get_gpiod_from_child() as is ;) > > Changing the internal implementation has never been the goal of this > pa

Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-01-31 Thread Boris Brezillon
On Tue, 31 Jan 2017 10:39:36 -0800 Dmitry Torokhov wrote: > On Tue, Jan 31, 2017 at 10:24:24AM +0100, Boris Brezillon wrote: > > On Tue, 31 Jan 2017 01:11:55 -0800 > > Dmitry Torokhov wrote: > > > > > On Tue, Jan 31, 2017 at 10:07:21AM +0100, Boris Brezillon wrote: > > > > On Tue, 31 Jan 20

Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-01-31 Thread Dmitry Torokhov
On Tue, Jan 31, 2017 at 10:24:24AM +0100, Boris Brezillon wrote: > On Tue, 31 Jan 2017 01:11:55 -0800 > Dmitry Torokhov wrote: > > > On Tue, Jan 31, 2017 at 10:07:21AM +0100, Boris Brezillon wrote: > > > On Tue, 31 Jan 2017 00:44:47 -0800 > > > Dmitry Torokhov wrote: > > > > > > > On Tue, Jan

Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-01-31 Thread Boris Brezillon
On Tue, 31 Jan 2017 01:11:55 -0800 Dmitry Torokhov wrote: > On Tue, Jan 31, 2017 at 10:07:21AM +0100, Boris Brezillon wrote: > > On Tue, 31 Jan 2017 00:44:47 -0800 > > Dmitry Torokhov wrote: > > > > > On Tue, Jan 31, 2017 at 09:04:32AM +0100, Boris Brezillon wrote: > > > > On Mon, 30 Jan 20

Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-01-31 Thread Dmitry Torokhov
On Tue, Jan 31, 2017 at 10:07:21AM +0100, Boris Brezillon wrote: > On Tue, 31 Jan 2017 00:44:47 -0800 > Dmitry Torokhov wrote: > > > On Tue, Jan 31, 2017 at 09:04:32AM +0100, Boris Brezillon wrote: > > > On Mon, 30 Jan 2017 17:06:07 -0800 > > > Dmitry Torokhov wrote: > > > > > > > On Mon, Jan

Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-01-31 Thread Boris Brezillon
On Tue, 31 Jan 2017 00:44:47 -0800 Dmitry Torokhov wrote: > On Tue, Jan 31, 2017 at 09:04:32AM +0100, Boris Brezillon wrote: > > On Mon, 30 Jan 2017 17:06:07 -0800 > > Dmitry Torokhov wrote: > > > > > On Mon, Jan 30, 2017 at 04:41:48PM +0100, Boris Brezillon wrote: > > > > Rename devm_get_g

Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-01-31 Thread Dmitry Torokhov
On Tue, Jan 31, 2017 at 09:04:32AM +0100, Boris Brezillon wrote: > On Mon, 30 Jan 2017 17:06:07 -0800 > Dmitry Torokhov wrote: > > > On Mon, Jan 30, 2017 at 04:41:48PM +0100, Boris Brezillon wrote: > > > Rename devm_get_gpiod_from_child() into > > > devm_fwnode_get_gpiod_from_child() to reflect t

Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-01-31 Thread Boris Brezillon
On Mon, 30 Jan 2017 17:06:07 -0800 Dmitry Torokhov wrote: > On Mon, Jan 30, 2017 at 04:41:48PM +0100, Boris Brezillon wrote: > > Rename devm_get_gpiod_from_child() into > > devm_fwnode_get_gpiod_from_child() to reflect the fact that this > > function is operating on a fwnode object. > > I beli

Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-01-30 Thread Dmitry Torokhov
On Mon, Jan 30, 2017 at 04:41:48PM +0100, Boris Brezillon wrote: > Rename devm_get_gpiod_from_child() into > devm_fwnode_get_gpiod_from_child() to reflect the fact that this > function is operating on a fwnode object. I believe this is completely pointless rename. Are you planning on adding devm_o

Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-01-30 Thread Jacek Anaszewski
On 01/30/2017 04:41 PM, Boris Brezillon wrote: > Rename devm_get_gpiod_from_child() into > devm_fwnode_get_gpiod_from_child() to reflect the fact that this > function is operating on a fwnode object. > > Signed-off-by: Boris Brezillon > --- > drivers/gpio/devres.c | 11 ++

[PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

2017-01-30 Thread Boris Brezillon
Rename devm_get_gpiod_from_child() into devm_fwnode_get_gpiod_from_child() to reflect the fact that this function is operating on a fwnode object. Signed-off-by: Boris Brezillon --- drivers/gpio/devres.c | 11 ++- drivers/input/keyboard/gpio_keys.c| 3 ++- dr