Re: [PATCH 1/2] gpio: don't override irq_*_resources() callbacks

2015-08-17 Thread Linus Walleij
On Mon, Aug 17, 2015 at 10:40 AM, Geert Uytterhoeven wrote: > On Mon, Aug 3, 2015 at 10:53 AM, Linus Walleij > wrote: >> On Fri, Jul 31, 2015 at 2:48 PM, Rabin Vincent wrote: >> >>> If the driver has specified its own irq_{request/release}_resources() >>> functions, don't override them. The gp

Re: [PATCH 1/2] gpio: don't override irq_*_resources() callbacks

2015-08-17 Thread Geert Uytterhoeven
On Mon, Aug 3, 2015 at 10:53 AM, Linus Walleij wrote: > On Fri, Jul 31, 2015 at 2:48 PM, Rabin Vincent wrote: > >> If the driver has specified its own irq_{request/release}_resources() >> functions, don't override them. The gpio-etraxfs driver will use this. >> >> Signed-off-by: Rabin Vincent >

Re: [PATCH 1/2] gpio: don't override irq_*_resources() callbacks

2015-08-03 Thread Linus Walleij
On Fri, Jul 31, 2015 at 4:54 PM, Grygorii Strashko wrote: > On 07/31/2015 03:48 PM, Rabin Vincent wrote: >> + if (!irqchip->irq_request_resources && >> + !irqchip->irq_release_resources) { >> + irqchip->irq_request_resources = gpiochip_irq_reqres; >> + irqchip-

Re: [PATCH 1/2] gpio: don't override irq_*_resources() callbacks

2015-08-03 Thread Linus Walleij
On Fri, Jul 31, 2015 at 2:48 PM, Rabin Vincent wrote: > If the driver has specified its own irq_{request/release}_resources() > functions, don't override them. The gpio-etraxfs driver will use this. > > Signed-off-by: Rabin Vincent Perfectly reasonable given the usecase in patch 2/2. Patch app

Re: [PATCH 1/2] gpio: don't override irq_*_resources() callbacks

2015-07-31 Thread Grygorii Strashko
On 07/31/2015 03:48 PM, Rabin Vincent wrote: > If the driver has specified its own irq_{request/release}_resources() > functions, don't override them. The gpio-etraxfs driver will use this. > > Signed-off-by: Rabin Vincent > --- > drivers/gpio/gpiolib.c | 8 ++-- > 1 file changed, 6 inser

[PATCH 1/2] gpio: don't override irq_*_resources() callbacks

2015-07-31 Thread Rabin Vincent
If the driver has specified its own irq_{request/release}_resources() functions, don't override them. The gpio-etraxfs driver will use this. Signed-off-by: Rabin Vincent --- drivers/gpio/gpiolib.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpiolib.c