Re: [PATCH 1/2] gpio: em: remove the gpiochip before removing the irq domain

2019-07-10 Thread Geert Uytterhoeven
Hi Phil, On Wed, Jul 10, 2019 at 11:37 AM Phil Reid wrote: > On 10/07/2019 17:08, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > In commit 8764c4ca5049 ("gpio: em: use the managed version of > > gpiochip_add_data()") we implicitly altered the ordering of resource > > freeing: s

Re: [PATCH 1/2] gpio: em: remove the gpiochip before removing the irq domain

2019-07-10 Thread Bartosz Golaszewski
śr., 10 lip 2019 o 11:37 Phil Reid napisał(a): > > G'day Bartosz, > > One comment below > > On 10/07/2019 17:08, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > In commit 8764c4ca5049 ("gpio: em: use the managed version of > > gpiochip_add_data()") we implicitly altered the order

Re: [PATCH 1/2] gpio: em: remove the gpiochip before removing the irq domain

2019-07-10 Thread Phil Reid
G'day Bartosz, One comment below On 10/07/2019 17:08, Bartosz Golaszewski wrote: From: Bartosz Golaszewski In commit 8764c4ca5049 ("gpio: em: use the managed version of gpiochip_add_data()") we implicitly altered the ordering of resource freeing: since gpiochip_remove() calls gpiochip_irqchip

[PATCH 1/2] gpio: em: remove the gpiochip before removing the irq domain

2019-07-10 Thread Bartosz Golaszewski
From: Bartosz Golaszewski In commit 8764c4ca5049 ("gpio: em: use the managed version of gpiochip_add_data()") we implicitly altered the ordering of resource freeing: since gpiochip_remove() calls gpiochip_irqchip_remove() internally, we now can potentially use the irq_domain after it was destroye