On Sun, Jun 02, 2013 at 09:50:11PM +0200, Oleg Nesterov wrote:
> 1. register_wide_hw_breakpoint() can use unregister_ if failure,
>no need to duplicate the code.
>
> 2. "struct perf_event **pevent" adds the unnecesary lever of
>indirection and complication, use per_cpu(*cpu_events, cpu).
On Sun, Jun 02, 2013 at 09:50:11PM +0200, Oleg Nesterov wrote:
1. register_wide_hw_breakpoint() can use unregister_ if failure,
no need to duplicate the code.
2. struct perf_event **pevent adds the unnecesary lever of
indirection and complication, use per_cpu(*cpu_events, cpu).
1. register_wide_hw_breakpoint() can use unregister_ if failure,
no need to duplicate the code.
2. "struct perf_event **pevent" adds the unnecesary lever of
indirection and complication, use per_cpu(*cpu_events, cpu).
Signed-off-by: Oleg Nesterov
---
kernel/events/hw_breakpoint.c | 34
1. register_wide_hw_breakpoint() can use unregister_ if failure,
no need to duplicate the code.
2. struct perf_event **pevent adds the unnecesary lever of
indirection and complication, use per_cpu(*cpu_events, cpu).
Signed-off-by: Oleg Nesterov o...@redhat.com
---
4 matches
Mail list logo