Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C [ver #2]

2014-03-13 Thread Wolfram Sang
On Thu, Mar 06, 2014 at 01:35:59PM +, David Howells wrote: > Add tracepoints into the I2C message transfer function to retrieve the message > sent or received. The following config options must be turned on to make use > of the facility: > > CONFIG_FTRACE >

Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C [ver #2]

2014-03-13 Thread Wolfram Sang
On Thu, Mar 06, 2014 at 01:35:59PM +, David Howells wrote: Add tracepoints into the I2C message transfer function to retrieve the message sent or received. The following config options must be turned on to make use of the facility: CONFIG_FTRACE

[PATCH 1/2] i2c: Add message transfer tracepoints for I2C [ver #2]

2014-03-06 Thread David Howells
Add tracepoints into the I2C message transfer function to retrieve the message sent or received. The following config options must be turned on to make use of the facility: CONFIG_FTRACE CONFIG_ENABLE_DEFAULT_TRACERS The I2C tracepoint can be enabled thusly: echo 1

[PATCH 1/2] i2c: Add message transfer tracepoints for I2C [ver #2]

2014-03-06 Thread David Howells
Add tracepoints into the I2C message transfer function to retrieve the message sent or received. The following config options must be turned on to make use of the facility: CONFIG_FTRACE CONFIG_ENABLE_DEFAULT_TRACERS The I2C tracepoint can be enabled thusly: echo 1

Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C

2014-02-28 Thread David Howells
Wolfram Sang wrote: > > > And for the buffer: %*phN is difficult to read IMO. What about %*ph? Or > > > %*phD at least? > > > > My problem with that is that it increases the length of the output by 50% > > and there's a hard limit on how much output we may produce. > > Is it PAGE_SIZE? How is

Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C

2014-02-28 Thread Wolfram Sang
> > And for the buffer: %*phN is difficult to read IMO. What about %*ph? Or > > %*phD at least? > > My problem with that is that it increases the length of the output by 50% and > there's a hard limit on how much output we may produce. Is it PAGE_SIZE? How is this handled when the buffer is so

Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C

2014-02-28 Thread Wolfram Sang
And for the buffer: %*phN is difficult to read IMO. What about %*ph? Or %*phD at least? My problem with that is that it increases the length of the output by 50% and there's a hard limit on how much output we may produce. Is it PAGE_SIZE? How is this handled when the buffer is so big

Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C

2014-02-28 Thread David Howells
Wolfram Sang w...@the-dreams.de wrote: And for the buffer: %*phN is difficult to read IMO. What about %*ph? Or %*phD at least? My problem with that is that it increases the length of the output by 50% and there's a hard limit on how much output we may produce. Is it PAGE_SIZE? How

Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C

2014-02-27 Thread David Howells
Wolfram Sang wrote: > 'flags' are u16 and the whole range is needed -> %04x Done. Note that %02x does not preclude more digits, but I guess it's better to have things line up. > for the address simply %03x should do. Done. > And for the buffer: %*phN is difficult to read IMO. What about

Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C

2014-02-27 Thread David Howells
Wolfram Sang w...@the-dreams.de wrote: 'flags' are u16 and the whole range is needed - %04x Done. Note that %02x does not preclude more digits, but I guess it's better to have things line up. for the address simply %03x should do. Done. And for the buffer: %*phN is difficult to read IMO.

Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C

2014-02-18 Thread Wolfram Sang
Hi David, On Thu, Jan 09, 2014 at 09:49:54PM +, David Howells wrote: > Add tracepoints into the I2C message transfer function to retrieve the message > sent or received. The following config options must be turned on to make use > of the facility: > > CONFIG_FTRACE >

Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C

2014-02-18 Thread Wolfram Sang
Hi David, On Thu, Jan 09, 2014 at 09:49:54PM +, David Howells wrote: Add tracepoints into the I2C message transfer function to retrieve the message sent or received. The following config options must be turned on to make use of the facility: CONFIG_FTRACE

Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C

2014-01-22 Thread Wolfram Sang
On Thu, Jan 09, 2014 at 09:49:54PM +, David Howells wrote: > Add tracepoints into the I2C message transfer function to retrieve the message > sent or received. The following config options must be turned on to make use > of the facility: > > CONFIG_FTRACE >

Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C

2014-01-22 Thread Wolfram Sang
On Thu, Jan 09, 2014 at 09:49:54PM +, David Howells wrote: Add tracepoints into the I2C message transfer function to retrieve the message sent or received. The following config options must be turned on to make use of the facility: CONFIG_FTRACE

[PATCH 1/2] i2c: Add message transfer tracepoints for I2C

2014-01-09 Thread David Howells
Add tracepoints into the I2C message transfer function to retrieve the message sent or received. The following config options must be turned on to make use of the facility: CONFIG_FTRACE CONFIG_ENABLE_DEFAULT_TRACERS The I2C tracepoint can be enabled thusly: echo 1

[PATCH 1/2] i2c: Add message transfer tracepoints for I2C

2014-01-09 Thread David Howells
Add tracepoints into the I2C message transfer function to retrieve the message sent or received. The following config options must be turned on to make use of the facility: CONFIG_FTRACE CONFIG_ENABLE_DEFAULT_TRACERS The I2C tracepoint can be enabled thusly: echo 1