Re: [RESEND PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

2016-08-14 Thread Wolfram Sang
On Wed, Aug 10, 2016 at 01:37:18PM -0700, Brian Norris wrote: > cros_ec_cmd_xfer returns success status if the command transport > completes successfully, but the execution result is incorrectly ignored. > In many cases, the execution result is assumed to be successful, leading > to ignored errors

Re: [RESEND PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

2016-08-10 Thread Guenter Roeck
On Wed, Aug 10, 2016 at 01:37:18PM -0700, Brian Norris wrote: > cros_ec_cmd_xfer returns success status if the command transport > completes successfully, but the execution result is incorrectly ignored. > In many cases, the execution result is assumed to be successful, leading > to ignored errors

[RESEND PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

2016-08-10 Thread Brian Norris
cros_ec_cmd_xfer returns success status if the command transport completes successfully, but the execution result is incorrectly ignored. In many cases, the execution result is assumed to be successful, leading to ignored errors and operating on uninitialized data. We've recently introduced the cr

Re: [PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

2016-07-28 Thread Thierry Reding
On Tue, Jul 26, 2016 at 11:38:20AM -0700, Brian Norris wrote: > Hi Thierry, > > On Tue, Jul 26, 2016 at 11:14:33AM +0200, Thierry Reding wrote: > > On Mon, Jul 25, 2016 at 01:48:25PM -0700, Brian Norris wrote: > > > On Mon, Jul 25, 2016 at 10:43:13PM +0200, Wolfram Sang wrote: > > > > On Mon, Jul

Re: [PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

2016-07-26 Thread Brian Norris
Hi Thierry, On Tue, Jul 26, 2016 at 11:14:33AM +0200, Thierry Reding wrote: > On Mon, Jul 25, 2016 at 01:48:25PM -0700, Brian Norris wrote: > > On Mon, Jul 25, 2016 at 10:43:13PM +0200, Wolfram Sang wrote: > > > On Mon, Jul 25, 2016 at 11:14:10AM -0700, Brian Norris wrote: > > > > cros_ec_cmd_xfer

Re: [PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

2016-07-26 Thread Thierry Reding
On Mon, Jul 25, 2016 at 01:48:25PM -0700, Brian Norris wrote: > On Mon, Jul 25, 2016 at 10:43:13PM +0200, Wolfram Sang wrote: > > On Mon, Jul 25, 2016 at 11:14:10AM -0700, Brian Norris wrote: > > > cros_ec_cmd_xfer returns success status if the command transport > > > completes successfully, but th

Re: [PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

2016-07-25 Thread Brian Norris
On Mon, Jul 25, 2016 at 10:43:13PM +0200, Wolfram Sang wrote: > On Mon, Jul 25, 2016 at 11:14:10AM -0700, Brian Norris wrote: > > cros_ec_cmd_xfer returns success status if the command transport > > completes successfully, but the execution result is incorrectly ignored. > > In many cases, the exec

Re: [PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

2016-07-25 Thread Wolfram Sang
On Mon, Jul 25, 2016 at 11:14:10AM -0700, Brian Norris wrote: > cros_ec_cmd_xfer returns success status if the command transport > completes successfully, but the execution result is incorrectly ignored. > In many cases, the execution result is assumed to be successful, leading > to ignored errors

Re: [PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

2016-07-25 Thread Javier Martinez Canillas
Hello Brian, On 07/25/2016 02:14 PM, Brian Norris wrote: > cros_ec_cmd_xfer returns success status if the command transport > completes successfully, but the execution result is incorrectly ignored. > In many cases, the execution result is assumed to be successful, leading > to ignored errors and

Re: [PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

2016-07-25 Thread kbuild test robot
Hi, [auto build test ERROR on wsa/i2c/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Brian-Norris/cros_ec-utilize-cros_ec_cmd_xfer_status/20160726-021919 base: https://git.kernel.org

[PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

2016-07-25 Thread Brian Norris
cros_ec_cmd_xfer returns success status if the command transport completes successfully, but the execution result is incorrectly ignored. In many cases, the execution result is assumed to be successful, leading to ignored errors and operating on uninitialized data. We've recently introduced the cr