Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-26 Thread Dmitry Osipenko
26.01.2015 19:03, Wolfram Sang пишет: Gaahh! I'm sure it wasn't working before! I'll make more testing and send v3 without "val = 0", if all will be fine. Please either send V3 or explicitly say V2 is OK. No need to hurry, just saying that I am waiting for updates here... Sure! -- Dmitry

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-26 Thread Wolfram Sang
> Gaahh! I'm sure it wasn't working before! I'll make more testing and send v3 > without "val = 0", if all will be fine. Please either send V3 or explicitly say V2 is OK. No need to hurry, just saying that I am waiting for updates here... signature.asc Description: Digital signature

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-26 Thread Dmitry Osipenko
26.01.2015 19:03, Wolfram Sang пишет: Gaahh! I'm sure it wasn't working before! I'll make more testing and send v3 without val = 0, if all will be fine. Please either send V3 or explicitly say V2 is OK. No need to hurry, just saying that I am waiting for updates here... Sure! -- Dmitry --

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-26 Thread Wolfram Sang
Gaahh! I'm sure it wasn't working before! I'll make more testing and send v3 without val = 0, if all will be fine. Please either send V3 or explicitly say V2 is OK. No need to hurry, just saying that I am waiting for updates here... signature.asc Description: Digital signature

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-23 Thread Dmitry Osipenko
23.01.2015 16:27, Dmitry Osipenko пишет: 23.01.2015 12:45, Thierry Reding пишет: On Thu, Jan 22, 2015 at 08:18:34PM +0300, Dmitry Osipenko wrote: 22.01.2015 19:06, Dmitry Osipenko пишет: 22.01.2015 18:22, Dmitry Osipenko пишет: 22.01.2015 10:55, Alexandre Courbot пишет: On Thu, Jan 22, 2015

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-23 Thread Dmitry Osipenko
23.01.2015 12:45, Thierry Reding пишет: On Thu, Jan 22, 2015 at 08:18:34PM +0300, Dmitry Osipenko wrote: 22.01.2015 19:06, Dmitry Osipenko пишет: 22.01.2015 18:22, Dmitry Osipenko пишет: 22.01.2015 10:55, Alexandre Courbot пишет: On Thu, Jan 22, 2015 at 4:40 PM, Thierry Reding wrote:

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-23 Thread Thierry Reding
On Thu, Jan 22, 2015 at 08:18:34PM +0300, Dmitry Osipenko wrote: > 22.01.2015 19:06, Dmitry Osipenko пишет: > >22.01.2015 18:22, Dmitry Osipenko пишет: > >>22.01.2015 10:55, Alexandre Courbot пишет: > >>>On Thu, Jan 22, 2015 at 4:40 PM, Thierry Reding > >>> wrote: > > Should this not

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-23 Thread Thierry Reding
On Thu, Jan 22, 2015 at 08:18:34PM +0300, Dmitry Osipenko wrote: 22.01.2015 19:06, Dmitry Osipenko пишет: 22.01.2015 18:22, Dmitry Osipenko пишет: 22.01.2015 10:55, Alexandre Courbot пишет: On Thu, Jan 22, 2015 at 4:40 PM, Thierry Reding thierry.red...@gmail.com wrote: Should this not

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-23 Thread Dmitry Osipenko
23.01.2015 12:45, Thierry Reding пишет: On Thu, Jan 22, 2015 at 08:18:34PM +0300, Dmitry Osipenko wrote: 22.01.2015 19:06, Dmitry Osipenko пишет: 22.01.2015 18:22, Dmitry Osipenko пишет: 22.01.2015 10:55, Alexandre Courbot пишет: On Thu, Jan 22, 2015 at 4:40 PM, Thierry Reding

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-23 Thread Dmitry Osipenko
23.01.2015 16:27, Dmitry Osipenko пишет: 23.01.2015 12:45, Thierry Reding пишет: On Thu, Jan 22, 2015 at 08:18:34PM +0300, Dmitry Osipenko wrote: 22.01.2015 19:06, Dmitry Osipenko пишет: 22.01.2015 18:22, Dmitry Osipenko пишет: 22.01.2015 10:55, Alexandre Courbot пишет: On Thu, Jan 22, 2015

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-22 Thread Dmitry Osipenko
22.01.2015 19:06, Dmitry Osipenko пишет: 22.01.2015 18:22, Dmitry Osipenko пишет: 22.01.2015 10:55, Alexandre Courbot пишет: On Thu, Jan 22, 2015 at 4:40 PM, Thierry Reding wrote: Should this not technically be le32_to_cpu() since the data originates from the I2C controller? No, i2c_readl

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-22 Thread Dmitry Osipenko
22.01.2015 18:22, Dmitry Osipenko пишет: 22.01.2015 10:55, Alexandre Courbot пишет: On Thu, Jan 22, 2015 at 4:40 PM, Thierry Reding wrote: Should this not technically be le32_to_cpu() since the data originates from the I2C controller? No, i2c_readl returns value in CPU endianness, so it's

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-22 Thread Dmitry Osipenko
22.01.2015 10:55, Alexandre Courbot пишет: On Thu, Jan 22, 2015 at 4:40 PM, Thierry Reding wrote: Should this not technically be le32_to_cpu() since the data originates from the I2C controller? No, i2c_readl returns value in CPU endianness, so it's correct. But for i2c_writel should be

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-22 Thread Dmitry Osipenko
22.01.2015 18:22, Dmitry Osipenko пишет: 22.01.2015 10:55, Alexandre Courbot пишет: On Thu, Jan 22, 2015 at 4:40 PM, Thierry Reding thierry.red...@gmail.com wrote: Should this not technically be le32_to_cpu() since the data originates from the I2C controller? No, i2c_readl returns value in

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-22 Thread Dmitry Osipenko
22.01.2015 10:55, Alexandre Courbot пишет: On Thu, Jan 22, 2015 at 4:40 PM, Thierry Reding thierry.red...@gmail.com wrote: Should this not technically be le32_to_cpu() since the data originates from the I2C controller? No, i2c_readl returns value in CPU endianness, so it's correct. But for

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-22 Thread Dmitry Osipenko
22.01.2015 19:06, Dmitry Osipenko пишет: 22.01.2015 18:22, Dmitry Osipenko пишет: 22.01.2015 10:55, Alexandre Courbot пишет: On Thu, Jan 22, 2015 at 4:40 PM, Thierry Reding thierry.red...@gmail.com wrote: Should this not technically be le32_to_cpu() since the data originates from the I2C

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-21 Thread Alexandre Courbot
On Thu, Jan 22, 2015 at 4:40 PM, Thierry Reding wrote: > On Tue, Jan 20, 2015 at 03:22:25PM +0300, Dmitry Osipenko wrote: >> Support CPU BE mode by adding endianness conversion for memcpy interactions. >> >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/i2c/busses/i2c-tegra.c | 3 +++ >> 1

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-21 Thread Thierry Reding
On Tue, Jan 20, 2015 at 03:22:25PM +0300, Dmitry Osipenko wrote: > Support CPU BE mode by adding endianness conversion for memcpy interactions. > > Signed-off-by: Dmitry Osipenko > --- > drivers/i2c/busses/i2c-tegra.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-21 Thread Thierry Reding
On Tue, Jan 20, 2015 at 03:22:25PM +0300, Dmitry Osipenko wrote: Support CPU BE mode by adding endianness conversion for memcpy interactions. Signed-off-by: Dmitry Osipenko dig...@gmail.com --- drivers/i2c/busses/i2c-tegra.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-21 Thread Alexandre Courbot
On Thu, Jan 22, 2015 at 4:40 PM, Thierry Reding thierry.red...@gmail.com wrote: On Tue, Jan 20, 2015 at 03:22:25PM +0300, Dmitry Osipenko wrote: Support CPU BE mode by adding endianness conversion for memcpy interactions. Signed-off-by: Dmitry Osipenko dig...@gmail.com ---

[PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-20 Thread Dmitry Osipenko
Support CPU BE mode by adding endianness conversion for memcpy interactions. Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 28b87e6..e0d3ef1 100644 ---

[PATCH 1/2] i2c: tegra: Maintain CPU endianness

2015-01-20 Thread Dmitry Osipenko
Support CPU BE mode by adding endianness conversion for memcpy interactions. Signed-off-by: Dmitry Osipenko dig...@gmail.com --- drivers/i2c/busses/i2c-tegra.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index