On Tue, 3 Jul 2018 15:35:05 +0200
Parthiban Nallathambi wrote:
> Hello Jonathan,
Hi Parthiban,
Comments inline.
...
> >> +static irqreturn_t vcnl4035_drdy_irq_handler(int irq, void *private)
> >> +{
> >> + struct iio_dev *indio_dev = private;
> >> + struct vcnl4035_data *data =
On Tue, 3 Jul 2018 15:35:05 +0200
Parthiban Nallathambi wrote:
> Hello Jonathan,
Hi Parthiban,
Comments inline.
...
> >> +static irqreturn_t vcnl4035_drdy_irq_handler(int irq, void *private)
> >> +{
> >> + struct iio_dev *indio_dev = private;
> >> + struct vcnl4035_data *data =
Hello Jonathan,
Thanks for your comments. Will send fixed v3 patch.
On 06/29/2018 07:59 PM, Jonathan Cameron wrote:
On Thu, 28 Jun 2018 14:30:20 +0200
Parthiban Nallathambi wrote:
Add support for VCNL4035, which is capable of Ambient light
sensing (ALS) and proximity function. This patch
Hello Jonathan,
Thanks for your comments. Will send fixed v3 patch.
On 06/29/2018 07:59 PM, Jonathan Cameron wrote:
On Thu, 28 Jun 2018 14:30:20 +0200
Parthiban Nallathambi wrote:
Add support for VCNL4035, which is capable of Ambient light
sensing (ALS) and proximity function. This patch
On Thu, 28 Jun 2018 14:30:20 +0200
Parthiban Nallathambi wrote:
> Add support for VCNL4035, which is capable of Ambient light
> sensing (ALS) and proximity function. This patch adds support
> only for ALS function
>
> Signed-off-by: Parthiban Nallathambi
Hi,
Looks fairly clean in general,
On Thu, 28 Jun 2018 14:30:20 +0200
Parthiban Nallathambi wrote:
> Add support for VCNL4035, which is capable of Ambient light
> sensing (ALS) and proximity function. This patch adds support
> only for ALS function
>
> Signed-off-by: Parthiban Nallathambi
Hi,
Looks fairly clean in general,
Hi Parthiban,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on iio/togreg]
[also build test WARNING on v4.18-rc2 next-20180628]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
Hi Parthiban,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on iio/togreg]
[also build test WARNING on v4.18-rc2 next-20180628]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
Add support for VCNL4035, which is capable of Ambient light
sensing (ALS) and proximity function. This patch adds support
only for ALS function
Signed-off-by: Parthiban Nallathambi
---
drivers/iio/light/Kconfig| 12 +
drivers/iio/light/Makefile | 1 +
drivers/iio/light/vcnl4035.c | 684
Add support for VCNL4035, which is capable of Ambient light
sensing (ALS) and proximity function. This patch adds support
only for ALS function
Signed-off-by: Parthiban Nallathambi
---
drivers/iio/light/Kconfig| 12 +
drivers/iio/light/Makefile | 1 +
drivers/iio/light/vcnl4035.c | 684
10 matches
Mail list logo