Re: [PATCH 1/2] iio: light: Add support for vishay vcnl4035

2018-07-07 Thread Jonathan Cameron
On Tue, 3 Jul 2018 15:35:05 +0200 Parthiban Nallathambi wrote: > Hello Jonathan, Hi Parthiban, Comments inline. ... > >> +static irqreturn_t vcnl4035_drdy_irq_handler(int irq, void *private) > >> +{ > >> + struct iio_dev *indio_dev = private; > >> + struct vcnl4035_data *data =

Re: [PATCH 1/2] iio: light: Add support for vishay vcnl4035

2018-07-07 Thread Jonathan Cameron
On Tue, 3 Jul 2018 15:35:05 +0200 Parthiban Nallathambi wrote: > Hello Jonathan, Hi Parthiban, Comments inline. ... > >> +static irqreturn_t vcnl4035_drdy_irq_handler(int irq, void *private) > >> +{ > >> + struct iio_dev *indio_dev = private; > >> + struct vcnl4035_data *data =

Re: [PATCH 1/2] iio: light: Add support for vishay vcnl4035

2018-07-03 Thread Parthiban Nallathambi
Hello Jonathan, Thanks for your comments. Will send fixed v3 patch. On 06/29/2018 07:59 PM, Jonathan Cameron wrote: On Thu, 28 Jun 2018 14:30:20 +0200 Parthiban Nallathambi wrote: Add support for VCNL4035, which is capable of Ambient light sensing (ALS) and proximity function. This patch

Re: [PATCH 1/2] iio: light: Add support for vishay vcnl4035

2018-07-03 Thread Parthiban Nallathambi
Hello Jonathan, Thanks for your comments. Will send fixed v3 patch. On 06/29/2018 07:59 PM, Jonathan Cameron wrote: On Thu, 28 Jun 2018 14:30:20 +0200 Parthiban Nallathambi wrote: Add support for VCNL4035, which is capable of Ambient light sensing (ALS) and proximity function. This patch

Re: [PATCH 1/2] iio: light: Add support for vishay vcnl4035

2018-06-29 Thread Jonathan Cameron
On Thu, 28 Jun 2018 14:30:20 +0200 Parthiban Nallathambi wrote: > Add support for VCNL4035, which is capable of Ambient light > sensing (ALS) and proximity function. This patch adds support > only for ALS function > > Signed-off-by: Parthiban Nallathambi Hi, Looks fairly clean in general,

Re: [PATCH 1/2] iio: light: Add support for vishay vcnl4035

2018-06-29 Thread Jonathan Cameron
On Thu, 28 Jun 2018 14:30:20 +0200 Parthiban Nallathambi wrote: > Add support for VCNL4035, which is capable of Ambient light > sensing (ALS) and proximity function. This patch adds support > only for ALS function > > Signed-off-by: Parthiban Nallathambi Hi, Looks fairly clean in general,

Re: [PATCH 1/2] iio: light: Add support for vishay vcnl4035

2018-06-28 Thread kbuild test robot
Hi Parthiban, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on iio/togreg] [also build test WARNING on v4.18-rc2 next-20180628] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 1/2] iio: light: Add support for vishay vcnl4035

2018-06-28 Thread kbuild test robot
Hi Parthiban, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on iio/togreg] [also build test WARNING on v4.18-rc2 next-20180628] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 1/2] iio: light: Add support for vishay vcnl4035

2018-06-28 Thread Parthiban Nallathambi
Add support for VCNL4035, which is capable of Ambient light sensing (ALS) and proximity function. This patch adds support only for ALS function Signed-off-by: Parthiban Nallathambi --- drivers/iio/light/Kconfig| 12 + drivers/iio/light/Makefile | 1 + drivers/iio/light/vcnl4035.c | 684

[PATCH 1/2] iio: light: Add support for vishay vcnl4035

2018-06-28 Thread Parthiban Nallathambi
Add support for VCNL4035, which is capable of Ambient light sensing (ALS) and proximity function. This patch adds support only for ALS function Signed-off-by: Parthiban Nallathambi --- drivers/iio/light/Kconfig| 12 + drivers/iio/light/Makefile | 1 + drivers/iio/light/vcnl4035.c | 684