Re: [PATCH 1/2] iommu/amd - Update the PASID information printed to the system log

2018-05-03 Thread Joerg Roedel
On Thu, May 03, 2018 at 01:09:18PM -0500, Gary R Hook wrote: > Yes, I didn't quite get this right. Both values should be passed along. Or > perhaps the entire event could be passed in and decoded by > amd_iommu_report_page_fault()? You already pass in the flags, you can chose the correct message

Re: [PATCH 1/2] iommu/amd - Update the PASID information printed to the system log

2018-05-03 Thread Joerg Roedel
On Thu, May 03, 2018 at 01:09:18PM -0500, Gary R Hook wrote: > Yes, I didn't quite get this right. Both values should be passed along. Or > perhaps the entire event could be passed in and decoded by > amd_iommu_report_page_fault()? You already pass in the flags, you can chose the correct message

Re: [PATCH 1/2] iommu/amd - Update the PASID information printed to the system log

2018-05-03 Thread Gary R Hook
On 05/03/2018 08:57 AM, Joerg Roedel wrote: On Tue, May 01, 2018 at 02:52:52PM -0500, Gary R Hook wrote: @@ -567,7 +567,7 @@ static void iommu_print_event(struct amd_iommu *iommu, void *__evt) } if (type == EVENT_TYPE_IO_FAULT) { -

Re: [PATCH 1/2] iommu/amd - Update the PASID information printed to the system log

2018-05-03 Thread Gary R Hook
On 05/03/2018 08:57 AM, Joerg Roedel wrote: On Tue, May 01, 2018 at 02:52:52PM -0500, Gary R Hook wrote: @@ -567,7 +567,7 @@ static void iommu_print_event(struct amd_iommu *iommu, void *__evt) } if (type == EVENT_TYPE_IO_FAULT) { -

Re: [PATCH 1/2] iommu/amd - Update the PASID information printed to the system log

2018-05-03 Thread Joerg Roedel
On Tue, May 01, 2018 at 02:52:52PM -0500, Gary R Hook wrote: > @@ -567,7 +567,7 @@ static void iommu_print_event(struct amd_iommu *iommu, > void *__evt) > } > > if (type == EVENT_TYPE_IO_FAULT) { > - amd_iommu_report_page_fault(devid, domid, address, flags); > +

Re: [PATCH 1/2] iommu/amd - Update the PASID information printed to the system log

2018-05-03 Thread Joerg Roedel
On Tue, May 01, 2018 at 02:52:52PM -0500, Gary R Hook wrote: > @@ -567,7 +567,7 @@ static void iommu_print_event(struct amd_iommu *iommu, > void *__evt) > } > > if (type == EVENT_TYPE_IO_FAULT) { > - amd_iommu_report_page_fault(devid, domid, address, flags); > +

[PATCH 1/2] iommu/amd - Update the PASID information printed to the system log

2018-05-01 Thread Gary R Hook
Provide detailed data for each event, as appropriate. Signed-off-by: Gary R Hook --- drivers/iommu/amd_iommu.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c index

[PATCH 1/2] iommu/amd - Update the PASID information printed to the system log

2018-05-01 Thread Gary R Hook
Provide detailed data for each event, as appropriate. Signed-off-by: Gary R Hook --- drivers/iommu/amd_iommu.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c index