Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-26 Thread Nicolas Pitre
On Wed, 23 Nov 2016, Russell King - ARM Linux wrote: > On Wed, Nov 23, 2016 at 09:33:32AM +, Russell King - ARM Linux wrote: > > So, I still think the whole approach is wrong - it's added extra > > fragility that wasn't there with the armksyms.c approach. > > Here's what the diffstat and

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-26 Thread Nicolas Pitre
On Wed, 23 Nov 2016, Russell King - ARM Linux wrote: > On Wed, Nov 23, 2016 at 09:33:32AM +, Russell King - ARM Linux wrote: > > So, I still think the whole approach is wrong - it's added extra > > fragility that wasn't there with the armksyms.c approach. > > Here's what the diffstat and

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-23 Thread Russell King - ARM Linux
On Wed, Nov 23, 2016 at 09:33:32AM +, Russell King - ARM Linux wrote: > I don't see it makes any difference - the armksyms.c originally had > the same: > > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > - >

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-23 Thread Russell King - ARM Linux
On Wed, Nov 23, 2016 at 09:33:32AM +, Russell King - ARM Linux wrote: > I don't see it makes any difference - the armksyms.c originally had > the same: > > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > - >

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-23 Thread Russell King - ARM Linux
On Tue, Nov 22, 2016 at 08:35:48PM -0500, Nicolas Pitre wrote: > On Wed, 23 Nov 2016, Nicholas Piggin wrote: > > > On Tue, 22 Nov 2016 11:34:48 -0500 (EST) > > Nicolas Pitre wrote: > > > > > On Tue, 22 Nov 2016, Arnd Bergmann wrote: > > > > > > > This adds an

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-23 Thread Russell King - ARM Linux
On Tue, Nov 22, 2016 at 08:35:48PM -0500, Nicolas Pitre wrote: > On Wed, 23 Nov 2016, Nicholas Piggin wrote: > > > On Tue, 22 Nov 2016 11:34:48 -0500 (EST) > > Nicolas Pitre wrote: > > > > > On Tue, 22 Nov 2016, Arnd Bergmann wrote: > > > > > > > This adds an asm/asm-prototypes.h header for

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-22 Thread Nicholas Piggin
On Wed, 23 Nov 2016 00:41:07 + Russell King - ARM Linux wrote: > On Tue, Nov 22, 2016 at 11:34:48AM -0500, Nicolas Pitre wrote: > > On Tue, 22 Nov 2016, Arnd Bergmann wrote: > > > This adds an asm/asm-prototypes.h header for ARM to fix the broken symbol > > >

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-22 Thread Nicholas Piggin
On Wed, 23 Nov 2016 00:41:07 + Russell King - ARM Linux wrote: > On Tue, Nov 22, 2016 at 11:34:48AM -0500, Nicolas Pitre wrote: > > On Tue, 22 Nov 2016, Arnd Bergmann wrote: > > > This adds an asm/asm-prototypes.h header for ARM to fix the broken symbol > > > versioning for symbols

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-22 Thread Nicolas Pitre
On Wed, 23 Nov 2016, Nicholas Piggin wrote: > On Tue, 22 Nov 2016 11:34:48 -0500 (EST) > Nicolas Pitre wrote: > > > On Tue, 22 Nov 2016, Arnd Bergmann wrote: > > > > > This adds an asm/asm-prototypes.h header for ARM to fix the broken symbol > > > versioning for

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-22 Thread Nicolas Pitre
On Wed, 23 Nov 2016, Nicholas Piggin wrote: > On Tue, 22 Nov 2016 11:34:48 -0500 (EST) > Nicolas Pitre wrote: > > > On Tue, 22 Nov 2016, Arnd Bergmann wrote: > > > > > This adds an asm/asm-prototypes.h header for ARM to fix the broken symbol > > > versioning for symbols exported from assembler

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-22 Thread Nicholas Piggin
On Tue, 22 Nov 2016 11:34:48 -0500 (EST) Nicolas Pitre wrote: > On Tue, 22 Nov 2016, Arnd Bergmann wrote: > > > This adds an asm/asm-prototypes.h header for ARM to fix the broken symbol > > versioning for symbols exported from assembler files. > > > > I couldn't find

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-22 Thread Nicholas Piggin
On Tue, 22 Nov 2016 11:34:48 -0500 (EST) Nicolas Pitre wrote: > On Tue, 22 Nov 2016, Arnd Bergmann wrote: > > > This adds an asm/asm-prototypes.h header for ARM to fix the broken symbol > > versioning for symbols exported from assembler files. > > > > I couldn't find the correct prototypes for

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-22 Thread Russell King - ARM Linux
On Tue, Nov 22, 2016 at 11:34:48AM -0500, Nicolas Pitre wrote: > On Tue, 22 Nov 2016, Arnd Bergmann wrote: > > This adds an asm/asm-prototypes.h header for ARM to fix the broken symbol > > versioning for symbols exported from assembler files. > > > > I couldn't find the correct prototypes for the

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-22 Thread Russell King - ARM Linux
On Tue, Nov 22, 2016 at 11:34:48AM -0500, Nicolas Pitre wrote: > On Tue, 22 Nov 2016, Arnd Bergmann wrote: > > This adds an asm/asm-prototypes.h header for ARM to fix the broken symbol > > versioning for symbols exported from assembler files. > > > > I couldn't find the correct prototypes for the

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-22 Thread Nicolas Pitre
On Tue, 22 Nov 2016, Arnd Bergmann wrote: > This adds an asm/asm-prototypes.h header for ARM to fix the broken symbol > versioning for symbols exported from assembler files. > > I couldn't find the correct prototypes for the compiler builtins, > so I went with the fake 'void f(void)' prototypes

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-22 Thread Nicolas Pitre
On Tue, 22 Nov 2016, Arnd Bergmann wrote: > This adds an asm/asm-prototypes.h header for ARM to fix the broken symbol > versioning for symbols exported from assembler files. > > I couldn't find the correct prototypes for the compiler builtins, > so I went with the fake 'void f(void)' prototypes

[PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-22 Thread Arnd Bergmann
This adds an asm/asm-prototypes.h header for ARM to fix the broken symbol versioning for symbols exported from assembler files. I couldn't find the correct prototypes for the compiler builtins, so I went with the fake 'void f(void)' prototypes that we had before, restoring the state before they

[PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-22 Thread Arnd Bergmann
This adds an asm/asm-prototypes.h header for ARM to fix the broken symbol versioning for symbols exported from assembler files. I couldn't find the correct prototypes for the compiler builtins, so I went with the fake 'void f(void)' prototypes that we had before, restoring the state before they

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-20 Thread Nicholas Piggin
On Sun, 20 Nov 2016 19:12:57 + Russell King - ARM Linux wrote: > On Sun, Nov 20, 2016 at 10:32:50AM -0800, Linus Torvalds wrote: > > On Sun, Nov 20, 2016 at 5:21 AM, Russell King - ARM Linux > > wrote: > > > On Tue, Oct 25, 2016 at 07:32:00PM

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-20 Thread Nicholas Piggin
On Sun, 20 Nov 2016 19:12:57 + Russell King - ARM Linux wrote: > On Sun, Nov 20, 2016 at 10:32:50AM -0800, Linus Torvalds wrote: > > On Sun, Nov 20, 2016 at 5:21 AM, Russell King - ARM Linux > > wrote: > > > On Tue, Oct 25, 2016 at 07:32:00PM +1100, Nicholas Piggin wrote: > > >> > > >>

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-20 Thread Russell King - ARM Linux
On Sun, Nov 20, 2016 at 10:32:50AM -0800, Linus Torvalds wrote: > On Sun, Nov 20, 2016 at 5:21 AM, Russell King - ARM Linux > wrote: > > On Tue, Oct 25, 2016 at 07:32:00PM +1100, Nicholas Piggin wrote: > >> > >> Michal, what's your thoughts? If you merge my patch 2/2 and

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-20 Thread Russell King - ARM Linux
On Sun, Nov 20, 2016 at 10:32:50AM -0800, Linus Torvalds wrote: > On Sun, Nov 20, 2016 at 5:21 AM, Russell King - ARM Linux > wrote: > > On Tue, Oct 25, 2016 at 07:32:00PM +1100, Nicholas Piggin wrote: > >> > >> Michal, what's your thoughts? If you merge my patch 2/2 and skip 1/2, it > >> should

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-20 Thread Linus Torvalds
On Sun, Nov 20, 2016 at 5:21 AM, Russell King - ARM Linux wrote: > On Tue, Oct 25, 2016 at 07:32:00PM +1100, Nicholas Piggin wrote: >> >> Michal, what's your thoughts? If you merge my patch 2/2 and skip 1/2, it >> should not give any new build warnings or errors, so then

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-20 Thread Linus Torvalds
On Sun, Nov 20, 2016 at 5:21 AM, Russell King - ARM Linux wrote: > On Tue, Oct 25, 2016 at 07:32:00PM +1100, Nicholas Piggin wrote: >> >> Michal, what's your thoughts? If you merge my patch 2/2 and skip 1/2, it >> should not give any new build warnings or errors, so then arch patches can >> go

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-20 Thread Russell King - ARM Linux
On Tue, Oct 25, 2016 at 07:32:00PM +1100, Nicholas Piggin wrote: > On Mon, 24 Oct 2016 17:05:26 +0200 > Arnd Bergmann wrote: > > > This adds an asm/asm-prototypes.h header for ARM to fix the > > broken symbol versioning for symbols exported from assembler > > files. > > > > In

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-11-20 Thread Russell King - ARM Linux
On Tue, Oct 25, 2016 at 07:32:00PM +1100, Nicholas Piggin wrote: > On Mon, 24 Oct 2016 17:05:26 +0200 > Arnd Bergmann wrote: > > > This adds an asm/asm-prototypes.h header for ARM to fix the > > broken symbol versioning for symbols exported from assembler > > files. > > > > In addition to the

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-25 Thread Nicholas Piggin
On Mon, 24 Oct 2016 17:05:26 +0200 Arnd Bergmann wrote: > This adds an asm/asm-prototypes.h header for ARM to fix the > broken symbol versioning for symbols exported from assembler > files. > > In addition to the header, we have to do these other small > changes: > > - move the

Re: [PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-25 Thread Nicholas Piggin
On Mon, 24 Oct 2016 17:05:26 +0200 Arnd Bergmann wrote: > This adds an asm/asm-prototypes.h header for ARM to fix the > broken symbol versioning for symbols exported from assembler > files. > > In addition to the header, we have to do these other small > changes: > > - move the exports from

[PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-24 Thread Arnd Bergmann
This adds an asm/asm-prototypes.h header for ARM to fix the broken symbol versioning for symbols exported from assembler files. In addition to the header, we have to do these other small changes: - move the exports from bitops.h to {change,clear,set,...}bit.S - move the exports from

[PATCH 1/2] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-24 Thread Arnd Bergmann
This adds an asm/asm-prototypes.h header for ARM to fix the broken symbol versioning for symbols exported from assembler files. In addition to the header, we have to do these other small changes: - move the exports from bitops.h to {change,clear,set,...}bit.S - move the exports from