Re: [PATCH 1/2] loop: use filp_close() rather than fput()

2017-06-17 Thread NeilBrown
On Sat, Jun 17 2017, Al Viro wrote: > On Fri, Jun 16, 2017 at 03:02:09PM +1000, NeilBrown wrote: >> When a loop device is being shutdown the backing file is >> closed with fput(). This is different from how close(2) >> closes files - it uses filp_close(). >> >> The difference is important for

Re: [PATCH 1/2] loop: use filp_close() rather than fput()

2017-06-17 Thread NeilBrown
On Sat, Jun 17 2017, Al Viro wrote: > On Fri, Jun 16, 2017 at 03:02:09PM +1000, NeilBrown wrote: >> When a loop device is being shutdown the backing file is >> closed with fput(). This is different from how close(2) >> closes files - it uses filp_close(). >> >> The difference is important for

Re: [PATCH 1/2] loop: use filp_close() rather than fput()

2017-06-16 Thread Al Viro
On Fri, Jun 16, 2017 at 03:02:09PM +1000, NeilBrown wrote: > When a loop device is being shutdown the backing file is > closed with fput(). This is different from how close(2) > closes files - it uses filp_close(). > > The difference is important for filesystems which provide a ->flush > file

Re: [PATCH 1/2] loop: use filp_close() rather than fput()

2017-06-16 Thread Al Viro
On Fri, Jun 16, 2017 at 03:02:09PM +1000, NeilBrown wrote: > When a loop device is being shutdown the backing file is > closed with fput(). This is different from how close(2) > closes files - it uses filp_close(). > > The difference is important for filesystems which provide a ->flush > file

Re: [PATCH 1/2] loop: use filp_close() rather than fput()

2017-06-16 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH 1/2] loop: use filp_close() rather than fput()

2017-06-16 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

[PATCH 1/2] loop: use filp_close() rather than fput()

2017-06-15 Thread NeilBrown
When a loop device is being shutdown the backing file is closed with fput(). This is different from how close(2) closes files - it uses filp_close(). The difference is important for filesystems which provide a ->flush file operation such as NFS. NFS assumes a flush will always be called on last

[PATCH 1/2] loop: use filp_close() rather than fput()

2017-06-15 Thread NeilBrown
When a loop device is being shutdown the backing file is closed with fput(). This is different from how close(2) closes files - it uses filp_close(). The difference is important for filesystems which provide a ->flush file operation such as NFS. NFS assumes a flush will always be called on last