Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-15 Thread Kalle Valo
Maxim Altshul writes: > - The variable is added to allow the driver an easy access > to it's own hw->priv when the op is invoked. > > - Change wlcore op accordingly. > > Signed-off-by: Maxim Altshul You didn't CC linux-wireless, adding it now. Others

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-15 Thread Kalle Valo
Maxim Altshul writes: > - The variable is added to allow the driver an easy access > to it's own hw->priv when the op is invoked. > > - Change wlcore op accordingly. > > Signed-off-by: Maxim Altshul You didn't CC linux-wireless, adding it now. Others can find the full discussion here:

RE: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-10 Thread Altshul, Maxim
On Tue, Aug 09, 2016 at 10:58:30, Johannes Berg wrote: > Subject: Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to > get_expected_throughput > > > > If you approve the mesh patch, then I will send two patches: > > 1. Check for sta->uploaded in the drv w

RE: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-10 Thread Altshul, Maxim
On Tue, Aug 09, 2016 at 10:58:30, Johannes Berg wrote: > Subject: Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to > get_expected_throughput > > > > If you approve the mesh patch, then I will send two patches: > > 1. Check for sta->uploaded in the drv w

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-09 Thread Johannes Berg
On Mon, 2016-08-08 at 10:42 +, Altshul, Maxim wrote: > Yes, exactly! Should I send the patch then so that we protect > get_expected_throughput? Yes please. > If so, then please have a look at my previous mesh patch (not yet > applied) "[PATCH v3] mac80211: mesh: Add support for HW RC >

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-09 Thread Johannes Berg
On Mon, 2016-08-08 at 10:42 +, Altshul, Maxim wrote: > Yes, exactly! Should I send the patch then so that we protect > get_expected_throughput? Yes please. > If so, then please have a look at my previous mesh patch (not yet > applied) "[PATCH v3] mac80211: mesh: Add support for HW RC >

RE: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-08 Thread Altshul, Maxim
2016 9:11 AM To: Altshul, Maxim; linux-kernel@vger.kernel.org Cc: john.stu...@linaro.org; Kalle Valo; Eliad Peller; Machani, Yaniv Subject: Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput On Sun, 2016-08-07 at 13:42 +, Altshul, Maxim wrote: > Hi Johaness, &

RE: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-08 Thread Altshul, Maxim
2016 9:11 AM To: Altshul, Maxim; linux-kernel@vger.kernel.org Cc: john.stu...@linaro.org; Kalle Valo; Eliad Peller; Machani, Yaniv Subject: Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput On Sun, 2016-08-07 at 13:42 +, Altshul, Maxim wrote: > Hi Johaness, &

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-08 Thread Johannes Berg
On Sun, 2016-08-07 at 13:42 +, Altshul, Maxim wrote: > Hi Johaness, > I have prepared a patch for the issue and it is waiting for me to > send it, but I feel that maybe I have not explained the previous > issue well enough or I did not understand your request fully. > I would like to clarify

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-08 Thread Johannes Berg
On Sun, 2016-08-07 at 13:42 +, Altshul, Maxim wrote: > Hi Johaness, > I have prepared a patch for the issue and it is waiting for me to > send it, but I feel that maybe I have not explained the previous > issue well enough or I did not understand your request fully. > I would like to clarify

RE: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-07 Thread Altshul, Maxim
alle Valo; Eliad Peller; Machani, Yaniv Subject: Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput On Fri, 2016-08-05 at 13:25 +, Altshul, Maxim wrote: > Hi, > 1) Sorry about the change log, I will try to be clearer next time. Just mention something ab

RE: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-07 Thread Altshul, Maxim
alle Valo; Eliad Peller; Machani, Yaniv Subject: Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput On Fri, 2016-08-05 at 13:25 +, Altshul, Maxim wrote: > Hi, > 1) Sorry about the change log, I will try to be clearer next time. Just mention something ab

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-05 Thread Johannes Berg
On Fri, 2016-08-05 at 13:25 +, Altshul, Maxim wrote: > Hi, > 1) Sorry about the change log, I will try to be clearer next time. Just mention something about how the bug happens please, at least. > 2+3) The issue is not that the station is not known, it's that > wl_sta->wl was null.  > wl

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-05 Thread Johannes Berg
On Fri, 2016-08-05 at 13:25 +, Altshul, Maxim wrote: > Hi, > 1) Sorry about the change log, I will try to be clearer next time. Just mention something about how the bug happens please, at least. > 2+3) The issue is not that the station is not known, it's that > wl_sta->wl was null.  > wl

RE: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-05 Thread Altshul, Maxim
Maxim; linux-kernel@vger.kernel.org Cc: john.stu...@linaro.org; Kalle Valo; Eliad Peller; Machani, Yaniv Subject: Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput On Fri, 2016-08-05 at 14:22 +0200, Johannes Berg wrote: > On Thu, 2016-08-04 at 15:43 +0300, Maxi

RE: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-05 Thread Altshul, Maxim
Maxim; linux-kernel@vger.kernel.org Cc: john.stu...@linaro.org; Kalle Valo; Eliad Peller; Machani, Yaniv Subject: Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput On Fri, 2016-08-05 at 14:22 +0200, Johannes Berg wrote: > On Thu, 2016-08-04 at 15:43 +0300, Maxi

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-05 Thread Johannes Berg
On Fri, 2016-08-05 at 14:22 +0200, Johannes Berg wrote: > On Thu, 2016-08-04 at 15:43 +0300, Maxim Altshul wrote: > > - The variable is added to allow the driver an easy access > > to it's own hw->priv when the op is invoked. > > > > - Change wlcore op accordingly. > > > I'm applying this now,

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-05 Thread Johannes Berg
On Fri, 2016-08-05 at 14:22 +0200, Johannes Berg wrote: > On Thu, 2016-08-04 at 15:43 +0300, Maxim Altshul wrote: > > - The variable is added to allow the driver an easy access > > to it's own hw->priv when the op is invoked. > > > > - Change wlcore op accordingly. > > > I'm applying this now,

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-05 Thread Johannes Berg
On Thu, 2016-08-04 at 15:43 +0300, Maxim Altshul wrote: > - The variable is added to allow the driver an easy access > to it's own hw->priv when the op is invoked. > > - Change wlcore op accordingly. > I'm applying this now, with a big BUT: 1) your changelog is crap - I've rewritten it to

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-05 Thread Johannes Berg
On Thu, 2016-08-04 at 15:43 +0300, Maxim Altshul wrote: > - The variable is added to allow the driver an easy access > to it's own hw->priv when the op is invoked. > > - Change wlcore op accordingly. > I'm applying this now, with a big BUT: 1) your changelog is crap - I've rewritten it to

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-05 Thread John Stultz
On Thu, Aug 4, 2016 at 10:40 PM, Johannes Berg wrote: > On Thu, 2016-08-04 at 14:31 -0700, John Stultz wrote: >> On Thu, Aug 4, 2016 at 5:43 AM, Maxim Altshul >> wrote: >> > - The variable is added to allow the driver an easy access >> > to it's

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-05 Thread John Stultz
On Thu, Aug 4, 2016 at 10:40 PM, Johannes Berg wrote: > On Thu, 2016-08-04 at 14:31 -0700, John Stultz wrote: >> On Thu, Aug 4, 2016 at 5:43 AM, Maxim Altshul >> wrote: >> > - The variable is added to allow the driver an easy access >> > to it's own hw->priv when the op is invoked. >> > >> > -

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-04 Thread Johannes Berg
On Thu, 2016-08-04 at 14:31 -0700, John Stultz wrote: > On Thu, Aug 4, 2016 at 5:43 AM, Maxim Altshul > wrote: > > - The variable is added to allow the driver an easy access > > to it's own hw->priv when the op is invoked. > > > > - Change wlcore op accordingly. > > > >

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-04 Thread Johannes Berg
On Thu, 2016-08-04 at 14:31 -0700, John Stultz wrote: > On Thu, Aug 4, 2016 at 5:43 AM, Maxim Altshul > wrote: > > - The variable is added to allow the driver an easy access > > to it's own hw->priv when the op is invoked. > > > > - Change wlcore op accordingly. > > > > Signed-off-by: Maxim

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-04 Thread John Stultz
On Thu, Aug 4, 2016 at 5:43 AM, Maxim Altshul wrote: > - The variable is added to allow the driver an easy access > to it's own hw->priv when the op is invoked. > > - Change wlcore op accordingly. > > Signed-off-by: Maxim Altshul These two patches

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-04 Thread John Stultz
On Thu, Aug 4, 2016 at 5:43 AM, Maxim Altshul wrote: > - The variable is added to allow the driver an easy access > to it's own hw->priv when the op is invoked. > > - Change wlcore op accordingly. > > Signed-off-by: Maxim Altshul These two patches solve the regression I was seeing with

[PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-04 Thread Maxim Altshul
- The variable is added to allow the driver an easy access to it's own hw->priv when the op is invoked. - Change wlcore op accordingly. Signed-off-by: Maxim Altshul --- drivers/net/wireless/ti/wlcore/main.c | 5 +++-- include/net/mac80211.h| 3 ++-

[PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

2016-08-04 Thread Maxim Altshul
- The variable is added to allow the driver an easy access to it's own hw->priv when the op is invoked. - Change wlcore op accordingly. Signed-off-by: Maxim Altshul --- drivers/net/wireless/ti/wlcore/main.c | 5 +++-- include/net/mac80211.h| 3 ++- net/mac80211/driver-ops.h