Re: [PATCH 1/2] megaraid: fix BUG_ON() from incorrect use of delayed work

2012-12-05 Thread Daniel Vacek
On Wed, Dec 5, 2012 at 12:02 PM, Daniel Vacek wrote: > On Tue, Dec 4, 2012 at 4:54 PM, Tejun Heo wrote: >> @@ -5190,7 +5188,7 @@ static void >> megasas_aen_polling(struct work_struct *work) >> { >> struct megasas_aen_event *ev = >> - container_of(work, struct

Re: [PATCH 1/2] megaraid: fix BUG_ON() from incorrect use of delayed work

2012-12-05 Thread Daniel Vacek
On Tue, Dec 4, 2012 at 4:54 PM, Tejun Heo wrote: > @@ -5190,7 +5188,7 @@ static void > megasas_aen_polling(struct work_struct *work) > { > struct megasas_aen_event *ev = > - container_of(work, struct megasas_aen_event, hotplug_work); > + container_of(work,

Re: [PATCH 1/2] megaraid: fix BUG_ON() from incorrect use of delayed work

2012-12-05 Thread Daniel Vacek
On Tue, Dec 4, 2012 at 4:54 PM, Tejun Heo t...@kernel.org wrote: @@ -5190,7 +5188,7 @@ static void megasas_aen_polling(struct work_struct *work) { struct megasas_aen_event *ev = - container_of(work, struct megasas_aen_event, hotplug_work); +

Re: [PATCH 1/2] megaraid: fix BUG_ON() from incorrect use of delayed work

2012-12-05 Thread Daniel Vacek
On Wed, Dec 5, 2012 at 12:02 PM, Daniel Vacek neel...@gmail.com wrote: On Tue, Dec 4, 2012 at 4:54 PM, Tejun Heo t...@kernel.org wrote: @@ -5190,7 +5188,7 @@ static void megasas_aen_polling(struct work_struct *work) { struct megasas_aen_event *ev = -

[PATCH 1/2] megaraid: fix BUG_ON() from incorrect use of delayed work

2012-12-04 Thread Tejun Heo
>From c1d390d8e6128b050f0f66b1c33d390760deb3f4 Mon Sep 17 00:00:00 2001 From: Xiaotian Feng Date: Tue, 4 Dec 2012 19:33:54 +0800 megaraid use INIT_WORK to declare a hotplug_work, but cast the hotplug_work from work_struct to delayed_work and schedule_delayed_work on it. This is very dangerous,

[PATCH 1/2] megaraid: fix BUG_ON() from incorrect use of delayed work

2012-12-04 Thread Tejun Heo
From c1d390d8e6128b050f0f66b1c33d390760deb3f4 Mon Sep 17 00:00:00 2001 From: Xiaotian Feng xtf...@gmail.com Date: Tue, 4 Dec 2012 19:33:54 +0800 megaraid use INIT_WORK to declare a hotplug_work, but cast the hotplug_work from work_struct to delayed_work and schedule_delayed_work on it. This is