Re: [PATCH 1/2] misc: add nirtfeatures driver

2016-03-19 Thread Kyle Roeschley
Hi Lee, On Wed, Mar 16, 2016 at 07:48:24AM +, Lee Jones wrote: > Is there any reason why the functionality can't be split up into > different source files? Create an LED driver, a Switch (whatever that > is) driver and a Watchdog driver, place them in drivers/{appropriate}, > then register fr

Re: [PATCH 1/2] misc: add nirtfeatures driver

2016-03-16 Thread Lee Jones
On Mon, 14 Mar 2016, Josh Cartwright wrote: > On Mon, Mar 14, 2016 at 03:05:59PM -0700, Greg KH wrote: > > On Mon, Mar 14, 2016 at 04:54:32PM -0500, Kyle Roeschley wrote: > > > From: Jeff Westfahl > > > > > > This driver introduces support for hardware features of National > > > Instruments real

Re: [PATCH 1/2] misc: add nirtfeatures driver

2016-03-14 Thread Kyle Roeschley
On Mon, Mar 14, 2016 at 05:30:22PM -0500, Josh Cartwright wrote: > On Mon, Mar 14, 2016 at 03:05:59PM -0700, Greg KH wrote: > > On Mon, Mar 14, 2016 at 04:54:32PM -0500, Kyle Roeschley wrote: > > > From: Jeff Westfahl > > > > > > This driver introduces support for hardware features of National >

Re: [PATCH 1/2] misc: add nirtfeatures driver

2016-03-14 Thread Josh Cartwright
On Mon, Mar 14, 2016 at 03:05:59PM -0700, Greg KH wrote: > On Mon, Mar 14, 2016 at 04:54:32PM -0500, Kyle Roeschley wrote: > > From: Jeff Westfahl > > > > This driver introduces support for hardware features of National > > Instruments real-time controllers. This is an ACPI device that exposes >

Re: [PATCH 1/2] misc: add nirtfeatures driver

2016-03-14 Thread Greg KH
On Mon, Mar 14, 2016 at 04:54:32PM -0500, Kyle Roeschley wrote: > From: Jeff Westfahl > > This driver introduces support for hardware features of National > Instruments real-time controllers. This is an ACPI device that exposes > LEDs, switches, and watchdogs. If it's an acpi driver, why not put

[PATCH 1/2] misc: add nirtfeatures driver

2016-03-14 Thread Kyle Roeschley
From: Jeff Westfahl This driver introduces support for hardware features of National Instruments real-time controllers. This is an ACPI device that exposes LEDs, switches, and watchdogs. Signed-off-by: Jeff Westfahl Signed-off-by: Kyle Roeschley --- drivers/misc/Kconfig| 9 + driver