Re: [PATCH 1/2] mm/hmm: a few more C style and comment clean ups

2019-07-23 Thread Christoph Hellwig
On Tue, Jul 23, 2019 at 11:57:52PM +, Jason Gunthorpe wrote: > diff --git a/mm/hmm.c b/mm/hmm.c > index 16b6731a34db79..3d8cdfb67a6ab8 100644 > --- a/mm/hmm.c > +++ b/mm/hmm.c > @@ -285,8 +285,9 @@ struct hmm_vma_walk { > struct hmm_range*range; > struct dev_pagemap

Re: [PATCH 1/2] mm/hmm: a few more C style and comment clean ups

2019-07-23 Thread Jason Gunthorpe
On Tue, Jul 23, 2019 at 04:30:15PM -0700, Ralph Campbell wrote: > - if (pmd_huge(pmd) && (range->vma->vm_flags & VM_HUGETLB)) > + if (pmd_huge(pmd) && is_vm_hugetlb_page(vma)) > return hmm_pfns_bad(start, end, walk); This one is not a minor cleanup.. I think it should be

[PATCH 1/2] mm/hmm: a few more C style and comment clean ups

2019-07-23 Thread Ralph Campbell
A few more comments and minor programming style clean ups. There should be no functional changes. Signed-off-by: Ralph Campbell Cc: "Jérôme Glisse" Cc: Jason Gunthorpe Cc: Christoph Hellwig --- mm/hmm.c | 34 -- 1 file changed, 16 insertions(+), 18