Re: [PATCH 1/2] mm/page_alloc.c: use list_{first,last}_entry instead of list_entry

2015-12-02 Thread David Rientjes
On Wed, 2 Dec 2015, Geliang Tang wrote: > To make the intention clearer, use list_{first,last}_entry instead > of list_entry. > > Signed-off-by: Geliang Tang Acked-by: David Rientjes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord..

Re: [PATCH 1/2] mm/page_alloc.c: use list_{first,last}_entry instead of list_entry

2015-12-02 Thread Mel Gorman
On Wed, Dec 02, 2015 at 11:12:40PM +0800, Geliang Tang wrote: > To make the intention clearer, use list_{first,last}_entry instead > of list_entry. > > Signed-off-by: Geliang Tang Acked-by: Mel Gorman -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [PATCH 1/2] mm/page_alloc.c: use list_{first,last}_entry instead of list_entry

2015-12-02 Thread Michal Hocko
On Wed 02-12-15 23:12:40, Geliang Tang wrote: > To make the intention clearer, use list_{first,last}_entry instead > of list_entry. I like list_{first,last}_entry that indeed helps readability, the _or_null is less clear from the name, though. Previous check for an empty list was easier to read, a

[PATCH 1/2] mm/page_alloc.c: use list_{first,last}_entry instead of list_entry

2015-12-02 Thread Geliang Tang
To make the intention clearer, use list_{first,last}_entry instead of list_entry. Signed-off-by: Geliang Tang --- mm/page_alloc.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index d6d7c97..0d38185 100644 --- a/mm