Re: [PATCH 1/2] mm: move common segment checks to separate helper function (v6)

2007-03-15 Thread Christoph Hellwig
Actually thinking about this a little more I don't think we should put this in. Instead this loop should be moved up to fs/read_write.c because these are checks that we want for all filesystems/drivers that use vectored I/O. We'll still need tiny loops to calculate the total I/O length for now

Re: [PATCH 1/2] mm: move common segment checks to separate helper function (v6)

2007-03-15 Thread Christoph Hellwig
Actually thinking about this a little more I don't think we should put this in. Instead this loop should be moved up to fs/read_write.c because these are checks that we want for all filesystems/drivers that use vectored I/O. We'll still need tiny loops to calculate the total I/O length for now

Re: [PATCH 1/2] mm: move common segment checks to separate helper function (v6)

2007-03-12 Thread Dmitriy Monakhov
Nick Piggin <[EMAIL PROTECTED]> writes: > On Mon, Mar 12, 2007 at 10:57:53AM +0300, Dmitriy Monakhov wrote: >> I realy don't want to be annoying by sending this patcheset over and over >> again. If anyone think this patch is realy cappy, please comment what >> exectly is bad. Thank you. > >

Re: [PATCH 1/2] mm: move common segment checks to separate helper function (v6)

2007-03-12 Thread Nick Piggin
On Mon, Mar 12, 2007 at 10:57:53AM +0300, Dmitriy Monakhov wrote: > I realy don't want to be annoying by sending this patcheset over and over > again. If anyone think this patch is realy cappy, please comment what > exectly is bad. Thank you. Doesn't seem like a bad idea. > > Changes: > -

Re: [PATCH 1/2] mm: move common segment checks to separate helper function (v6)

2007-03-12 Thread Christoph Hellwig
On Mon, Mar 12, 2007 at 10:57:53AM +0300, Dmitriy Monakhov wrote: > +/* > + * Performs necessary checks before doing a write > + * > + * Adjust number of segments and amount of bytes to write. > + * Returns appropriate error code that caller should return or > + * zero in case that write should be

[PATCH 1/2] mm: move common segment checks to separate helper function (v6)

2007-03-12 Thread Dmitriy Monakhov
I realy don't want to be annoying by sending this patcheset over and over again. If anyone think this patch is realy cappy, please comment what exectly is bad. Thank you. Changes: - patch was split in two patches. - comments added. I think now it is clearly describe things. - make

[PATCH 1/2] mm: move common segment checks to separate helper function (v6)

2007-03-12 Thread Dmitriy Monakhov
I realy don't want to be annoying by sending this patcheset over and over again. If anyone think this patch is realy cappy, please comment what exectly is bad. Thank you. Changes: - patch was split in two patches. - comments added. I think now it is clearly describe things. - make

Re: [PATCH 1/2] mm: move common segment checks to separate helper function (v6)

2007-03-12 Thread Christoph Hellwig
On Mon, Mar 12, 2007 at 10:57:53AM +0300, Dmitriy Monakhov wrote: +/* + * Performs necessary checks before doing a write + * + * Adjust number of segments and amount of bytes to write. + * Returns appropriate error code that caller should return or + * zero in case that write should be

Re: [PATCH 1/2] mm: move common segment checks to separate helper function (v6)

2007-03-12 Thread Nick Piggin
On Mon, Mar 12, 2007 at 10:57:53AM +0300, Dmitriy Monakhov wrote: I realy don't want to be annoying by sending this patcheset over and over again. If anyone think this patch is realy cappy, please comment what exectly is bad. Thank you. Doesn't seem like a bad idea. Changes: - patch

Re: [PATCH 1/2] mm: move common segment checks to separate helper function (v6)

2007-03-12 Thread Dmitriy Monakhov
Nick Piggin [EMAIL PROTECTED] writes: On Mon, Mar 12, 2007 at 10:57:53AM +0300, Dmitriy Monakhov wrote: I realy don't want to be annoying by sending this patcheset over and over again. If anyone think this patch is realy cappy, please comment what exectly is bad. Thank you. Doesn't seem