Re: [PATCH 1/2] mm: page_counter: relayout structure to reduce false sharing

2021-01-04 Thread Michal Hocko
On Mon 04-01-21 22:44:02, Feng Tang wrote: > On Mon, Jan 04, 2021 at 03:11:40PM +0100, Michal Hocko wrote: > > On Mon 04-01-21 21:34:45, Feng Tang wrote: > > > Hi Michal, > > > > > > On Mon, Jan 04, 2021 at 02:03:57PM +0100, Michal Hocko wrote: > > > > On Tue 29-12-20 22:35:13, Feng Tang wrote: >

Re: [PATCH 1/2] mm: page_counter: relayout structure to reduce false sharing

2021-01-04 Thread Feng Tang
On Mon, Jan 04, 2021 at 03:11:40PM +0100, Michal Hocko wrote: > On Mon 04-01-21 21:34:45, Feng Tang wrote: > > Hi Michal, > > > > On Mon, Jan 04, 2021 at 02:03:57PM +0100, Michal Hocko wrote: > > > On Tue 29-12-20 22:35:13, Feng Tang wrote: > > > > When checking a memory cgroup related

Re: [PATCH 1/2] mm: page_counter: relayout structure to reduce false sharing

2021-01-04 Thread Michal Hocko
On Mon 04-01-21 21:34:45, Feng Tang wrote: > Hi Michal, > > On Mon, Jan 04, 2021 at 02:03:57PM +0100, Michal Hocko wrote: > > On Tue 29-12-20 22:35:13, Feng Tang wrote: > > > When checking a memory cgroup related performance regression [1], > > > from the perf c2c profiling data, we found high

Re: [PATCH 1/2] mm: page_counter: relayout structure to reduce false sharing

2021-01-04 Thread Feng Tang
Hi Michal, On Mon, Jan 04, 2021 at 02:03:57PM +0100, Michal Hocko wrote: > On Tue 29-12-20 22:35:13, Feng Tang wrote: > > When checking a memory cgroup related performance regression [1], > > from the perf c2c profiling data, we found high false sharing for > > accessing 'usage' and 'parent'. > >

Re: [PATCH 1/2] mm: page_counter: relayout structure to reduce false sharing

2021-01-04 Thread Michal Hocko
On Tue 29-12-20 22:35:13, Feng Tang wrote: > When checking a memory cgroup related performance regression [1], > from the perf c2c profiling data, we found high false sharing for > accessing 'usage' and 'parent'. > > On 64 bit system, the 'usage' and 'parent' are close to each other, > and easy

Re: [PATCH 1/2] mm: page_counter: relayout structure to reduce false sharing

2020-12-30 Thread Feng Tang
On Tue, Dec 29, 2020 at 08:56:42AM -0800, Roman Gushchin wrote: > On Tue, Dec 29, 2020 at 10:35:13PM +0800, Feng Tang wrote: > > When checking a memory cgroup related performance regression [1], > > from the perf c2c profiling data, we found high false sharing for > > accessing 'usage' and

Re: [PATCH 1/2] mm: page_counter: relayout structure to reduce false sharing

2020-12-29 Thread Roman Gushchin
On Tue, Dec 29, 2020 at 10:35:13PM +0800, Feng Tang wrote: > When checking a memory cgroup related performance regression [1], > from the perf c2c profiling data, we found high false sharing for > accessing 'usage' and 'parent'. > > On 64 bit system, the 'usage' and 'parent' are close to each

[PATCH 1/2] mm: page_counter: relayout structure to reduce false sharing

2020-12-29 Thread Feng Tang
When checking a memory cgroup related performance regression [1], from the perf c2c profiling data, we found high false sharing for accessing 'usage' and 'parent'. On 64 bit system, the 'usage' and 'parent' are close to each other, and easy to be in one cacheline (for cacheline size == 64+ B).