Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ulf Hansson
[...] >> > This one to not write an invalid voltage in the power control register >> > even if we have an external regulator for vmmc. >> > >> >> As I stated earlier, according to the SDHCI spec in the section for >> the Power Control Register. Bit 0 needs to be set when communicating >> with the

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ludovic Desroches
On Tue, Nov 24, 2015 at 02:56:21PM +0100, Ulf Hansson wrote: > On 24 November 2015 at 14:12, Ludovic Desroches > wrote: > > On Tue, Nov 24, 2015 at 12:01:53PM +0100, Ulf Hansson wrote: > >> On 24 November 2015 at 10:23, Ludovic Desroches > >> wrote: > >> > Hi Ulf, > >> > > >> > On Mon, Nov 09,

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ulf Hansson
On 24 November 2015 at 14:12, Ludovic Desroches wrote: > On Tue, Nov 24, 2015 at 12:01:53PM +0100, Ulf Hansson wrote: >> On 24 November 2015 at 10:23, Ludovic Desroches >> wrote: >> > Hi Ulf, >> > >> > On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: >> >> On Mon, Nov 09, 2015

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ludovic Desroches
On Tue, Nov 24, 2015 at 12:01:53PM +0100, Ulf Hansson wrote: > On 24 November 2015 at 10:23, Ludovic Desroches > wrote: > > Hi Ulf, > > > > On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: > >> On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: > > > > [...] > > > >> >

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ulf Hansson
On 24 November 2015 at 10:23, Ludovic Desroches wrote: > Hi Ulf, > > On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: >> On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: > > [...] > >> > Now, this discussion was interesting, but I forgot what problem you >> >

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ludovic Desroches
Hi Ulf, On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: > On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: [...] > > Now, this discussion was interesting, but I forgot what problem you > > actually where trying to solve? :-) > > There is this discussion because

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ludovic Desroches
Hi Ulf, On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: > On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: [...] > > Now, this discussion was interesting, but I forgot what problem you > > actually where trying to solve? :-) > > There is this discussion because

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ulf Hansson
On 24 November 2015 at 10:23, Ludovic Desroches wrote: > Hi Ulf, > > On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: >> On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: > > [...] > >> > Now, this discussion was interesting, but I forgot

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ludovic Desroches
On Tue, Nov 24, 2015 at 02:56:21PM +0100, Ulf Hansson wrote: > On 24 November 2015 at 14:12, Ludovic Desroches > wrote: > > On Tue, Nov 24, 2015 at 12:01:53PM +0100, Ulf Hansson wrote: > >> On 24 November 2015 at 10:23, Ludovic Desroches > >>

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ulf Hansson
[...] >> > This one to not write an invalid voltage in the power control register >> > even if we have an external regulator for vmmc. >> > >> >> As I stated earlier, according to the SDHCI spec in the section for >> the Power Control Register. Bit 0 needs to be set when communicating >> with the

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ludovic Desroches
On Tue, Nov 24, 2015 at 12:01:53PM +0100, Ulf Hansson wrote: > On 24 November 2015 at 10:23, Ludovic Desroches > wrote: > > Hi Ulf, > > > > On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: > >> On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ulf Hansson
On 24 November 2015 at 14:12, Ludovic Desroches wrote: > On Tue, Nov 24, 2015 at 12:01:53PM +0100, Ulf Hansson wrote: >> On 24 November 2015 at 10:23, Ludovic Desroches >> wrote: >> > Hi Ulf, >> > >> > On Mon, Nov 09, 2015 at 05:30:26PM

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: > On 9 November 2015 at 15:40, Ludovic Desroches > wrote: > > On Mon, Nov 09, 2015 at 03:12:46PM +0100, Ulf Hansson wrote: > >> On 9 November 2015 at 14:23, Ludovic Desroches > >> wrote: > >> > On Fri, Nov 06, 2015 at 04:59:29PM +0100,

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ulf Hansson
On 9 November 2015 at 15:40, Ludovic Desroches wrote: > On Mon, Nov 09, 2015 at 03:12:46PM +0100, Ulf Hansson wrote: >> On 9 November 2015 at 14:23, Ludovic Desroches >> wrote: >> > On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: >> >> When there is a vmmc regulator, only SD

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 03:12:46PM +0100, Ulf Hansson wrote: > On 9 November 2015 at 14:23, Ludovic Desroches > wrote: > > On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: > >> When there is a vmmc regulator, only SD Bus Power is set to 1 in the > >> Power Control Register. It

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ulf Hansson
On 9 November 2015 at 14:23, Ludovic Desroches wrote: > On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: >> When there is a vmmc regulator, only SD Bus Power is set to 1 in the >> Power Control Register. It means SD Bus Voltage Select field is set to 0 >> that is a reserved

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ludovic Desroches
On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: > When there is a vmmc regulator, only SD Bus Power is set to 1 in the > Power Control Register. It means SD Bus Voltage Select field is set to 0 > that is a reserved value. The SD Host Controller specification says: > 'SD Bus

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ulf Hansson
On 9 November 2015 at 14:23, Ludovic Desroches wrote: > On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: >> When there is a vmmc regulator, only SD Bus Power is set to 1 in the >> Power Control Register. It means SD Bus Voltage Select field is set to

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ludovic Desroches
On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: > When there is a vmmc regulator, only SD Bus Power is set to 1 in the > Power Control Register. It means SD Bus Voltage Select field is set to 0 > that is a reserved value. The SD Host Controller specification says: > 'SD Bus

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 03:12:46PM +0100, Ulf Hansson wrote: > On 9 November 2015 at 14:23, Ludovic Desroches > wrote: > > On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: > >> When there is a vmmc regulator, only SD Bus Power is set to 1 in the > >>

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: > On 9 November 2015 at 15:40, Ludovic Desroches > wrote: > > On Mon, Nov 09, 2015 at 03:12:46PM +0100, Ulf Hansson wrote: > >> On 9 November 2015 at 14:23, Ludovic Desroches > >>

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ulf Hansson
On 9 November 2015 at 15:40, Ludovic Desroches wrote: > On Mon, Nov 09, 2015 at 03:12:46PM +0100, Ulf Hansson wrote: >> On 9 November 2015 at 14:23, Ludovic Desroches >> wrote: >> > On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic

[PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-06 Thread Ludovic Desroches
When there is a vmmc regulator, only SD Bus Power is set to 1 in the Power Control Register. It means SD Bus Voltage Select field is set to 0 that is a reserved value. The SD Host Controller specification says: 'SD Bus Power: Before setting this bit, the SD Host Driver shall set SD Bus Voltage

[PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-06 Thread Ludovic Desroches
When there is a vmmc regulator, only SD Bus Power is set to 1 in the Power Control Register. It means SD Bus Voltage Select field is set to 0 that is a reserved value. The SD Host Controller specification says: 'SD Bus Power: Before setting this bit, the SD Host Driver shall set SD Bus Voltage