Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-23 Thread Dave Martin
On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent Whitchurch wrote: > st_info is currently overwritten after relocation and used to store the > elf_type(). However, we're going to need it fix kallsyms on ARM's > Thumb-2 kernels, so preserve st_info and overwrite the st_size field > instead.

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-23 Thread Dave Martin
On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent Whitchurch wrote: > st_info is currently overwritten after relocation and used to store the > elf_type(). However, we're going to need it fix kallsyms on ARM's > Thumb-2 kernels, so preserve st_info and overwrite the st_size field > instead.

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-23 Thread Dave Martin
On Thu, Nov 22, 2018 at 05:49:23PM +, Russell King - ARM Linux wrote: > On Thu, Nov 22, 2018 at 06:40:45PM +0100, Ard Biesheuvel wrote: > > On Thu, 22 Nov 2018 at 17:29, Jessica Yu wrote: > > > > > > +++ Vincent Whitchurch [22/11/18 13:24 +0100]: > > > >On Thu, Nov 22, 2018 at 12:01:54PM

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-23 Thread Dave Martin
On Thu, Nov 22, 2018 at 05:49:23PM +, Russell King - ARM Linux wrote: > On Thu, Nov 22, 2018 at 06:40:45PM +0100, Ard Biesheuvel wrote: > > On Thu, 22 Nov 2018 at 17:29, Jessica Yu wrote: > > > > > > +++ Vincent Whitchurch [22/11/18 13:24 +0100]: > > > >On Thu, Nov 22, 2018 at 12:01:54PM

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-23 Thread Miroslav Benes
On Thu, 22 Nov 2018, Jessica Yu wrote: > +++ Vincent Whitchurch [22/11/18 13:24 +0100]: > >On Thu, Nov 22, 2018 at 12:01:54PM +, Dave Martin wrote: > >> On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent Whitchurch wrote: > >> > st_info is currently overwritten after relocation and used to

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-23 Thread Miroslav Benes
On Thu, 22 Nov 2018, Jessica Yu wrote: > +++ Vincent Whitchurch [22/11/18 13:24 +0100]: > >On Thu, Nov 22, 2018 at 12:01:54PM +, Dave Martin wrote: > >> On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent Whitchurch wrote: > >> > st_info is currently overwritten after relocation and used to

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-22 Thread Russell King - ARM Linux
On Thu, Nov 22, 2018 at 06:40:45PM +0100, Ard Biesheuvel wrote: > On Thu, 22 Nov 2018 at 17:29, Jessica Yu wrote: > > > > +++ Vincent Whitchurch [22/11/18 13:24 +0100]: > > >On Thu, Nov 22, 2018 at 12:01:54PM +, Dave Martin wrote: > > >> On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-22 Thread Russell King - ARM Linux
On Thu, Nov 22, 2018 at 06:40:45PM +0100, Ard Biesheuvel wrote: > On Thu, 22 Nov 2018 at 17:29, Jessica Yu wrote: > > > > +++ Vincent Whitchurch [22/11/18 13:24 +0100]: > > >On Thu, Nov 22, 2018 at 12:01:54PM +, Dave Martin wrote: > > >> On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-22 Thread Ard Biesheuvel
On Thu, 22 Nov 2018 at 17:29, Jessica Yu wrote: > > +++ Vincent Whitchurch [22/11/18 13:24 +0100]: > >On Thu, Nov 22, 2018 at 12:01:54PM +, Dave Martin wrote: > >> On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent Whitchurch wrote: > >> > st_info is currently overwritten after relocation and

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-22 Thread Ard Biesheuvel
On Thu, 22 Nov 2018 at 17:29, Jessica Yu wrote: > > +++ Vincent Whitchurch [22/11/18 13:24 +0100]: > >On Thu, Nov 22, 2018 at 12:01:54PM +, Dave Martin wrote: > >> On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent Whitchurch wrote: > >> > st_info is currently overwritten after relocation and

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-22 Thread Jessica Yu
+++ Vincent Whitchurch [22/11/18 13:24 +0100]: On Thu, Nov 22, 2018 at 12:01:54PM +, Dave Martin wrote: On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent Whitchurch wrote: > st_info is currently overwritten after relocation and used to store the > elf_type(). However, we're going to need

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-22 Thread Jessica Yu
+++ Vincent Whitchurch [22/11/18 13:24 +0100]: On Thu, Nov 22, 2018 at 12:01:54PM +, Dave Martin wrote: On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent Whitchurch wrote: > st_info is currently overwritten after relocation and used to store the > elf_type(). However, we're going to need

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-22 Thread Vincent Whitchurch
On Thu, Nov 22, 2018 at 12:01:54PM +, Dave Martin wrote: > On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent Whitchurch wrote: > > st_info is currently overwritten after relocation and used to store the > > elf_type(). However, we're going to need it fix kallsyms on ARM's > > Thumb-2 kernels,

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-22 Thread Vincent Whitchurch
On Thu, Nov 22, 2018 at 12:01:54PM +, Dave Martin wrote: > On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent Whitchurch wrote: > > st_info is currently overwritten after relocation and used to store the > > elf_type(). However, we're going to need it fix kallsyms on ARM's > > Thumb-2 kernels,

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-22 Thread Dave Martin
On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent Whitchurch wrote: > st_info is currently overwritten after relocation and used to store the > elf_type(). However, we're going to need it fix kallsyms on ARM's > Thumb-2 kernels, so preserve st_info and overwrite the st_size field > instead.

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-22 Thread Dave Martin
On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent Whitchurch wrote: > st_info is currently overwritten after relocation and used to store the > elf_type(). However, we're going to need it fix kallsyms on ARM's > Thumb-2 kernels, so preserve st_info and overwrite the st_size field > instead.

[PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-19 Thread Vincent Whitchurch
st_info is currently overwritten after relocation and used to store the elf_type(). However, we're going to need it fix kallsyms on ARM's Thumb-2 kernels, so preserve st_info and overwrite the st_size field instead. st_size is neither used by the module core nor by any architecture.

[PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-19 Thread Vincent Whitchurch
st_info is currently overwritten after relocation and used to store the elf_type(). However, we're going to need it fix kallsyms on ARM's Thumb-2 kernels, so preserve st_info and overwrite the st_size field instead. st_size is neither used by the module core nor by any architecture.