Re: [PATCH 1/2] module: Prepare for addition of new ro_after_init sections

2019-04-10 Thread Steven Rostedt
On Wed, 10 Apr 2019 11:21:23 -0700 Kees Cook wrote: > On Wed, Apr 10, 2019 at 10:48 AM Joel Fernandes > wrote: > > Thanks, if you are Ok with it, I will add your Reviewed-by tag as well. > > With those fixes, absolutely. :) Thanks! > I'll wait for v2 before adding my reviewed-by. ;-) --

Re: [PATCH 1/2] module: Prepare for addition of new ro_after_init sections

2019-04-10 Thread Kees Cook
On Wed, Apr 10, 2019 at 10:48 AM Joel Fernandes wrote: > Thanks, if you are Ok with it, I will add your Reviewed-by tag as well. With those fixes, absolutely. :) Thanks! -- Kees Cook

Re: [PATCH 1/2] module: Prepare for addition of new ro_after_init sections

2019-04-10 Thread Joel Fernandes
On Wed, Apr 10, 2019 at 09:26:44AM -0700, Kees Cook wrote: > On Tue, Apr 9, 2019 at 6:14 PM Joel Fernandes (Google) > wrote: > > > > For the purposes of hardening modules by adding sections to > > ro_after_init sections, prepare for addition of new ro_after_init > > entries which we do in future

Re: [PATCH 1/2] module: Prepare for addition of new ro_after_init sections

2019-04-10 Thread Kees Cook
On Tue, Apr 9, 2019 at 6:14 PM Joel Fernandes (Google) wrote: > > For the purposes of hardening modules by adding sections to > ro_after_init sections, prepare for addition of new ro_after_init > entries which we do in future patches. Create a table to which new > entries could be added later.

[PATCH 1/2] module: Prepare for addition of new ro_after_init sections

2019-04-09 Thread Joel Fernandes (Google)
For the purposes of hardening modules by adding sections to ro_after_init sections, prepare for addition of new ro_after_init entries which we do in future patches. Create a table to which new entries could be added later. This makes it less error prone and reduce code duplication. Cc: