Re: [PATCH 1/2] moxa: make functions static

2008-02-20 Thread Harvey Harrison
On Thu, 2008-02-21 at 00:12 +0100, Jiri Slaby wrote: > On 02/20/2008 11:14 PM, Harvey Harrison wrote: > > All were forward declared static already. > > > Thanks, but I have similar fixes for both issues you address in my tree. I'll > post it in few days. Great. Harvey -- To unsubscribe from

Re: [PATCH 1/2] moxa: make functions static

2008-02-20 Thread Jiri Slaby
On 02/20/2008 11:14 PM, Harvey Harrison wrote: All were forward declared static already. Fixes sparse warnings: drivers/char/moxa.c:1421:6: warning: symbol 'MoxaDriverInit' was not declared. Should it be static? drivers/char/moxa.c:1464:6: warning: symbol 'MoxaPortFlushData' was not declared.

[PATCH 1/2] moxa: make functions static

2008-02-20 Thread Harvey Harrison
All were forward declared static already. Fixes sparse warnings: drivers/char/moxa.c:1421:6: warning: symbol 'MoxaDriverInit' was not declared. Should it be static? drivers/char/moxa.c:1464:6: warning: symbol 'MoxaPortFlushData' was not declared. Should it be static? drivers/char/moxa.c:1477:5:

[PATCH 1/2] moxa: make functions static

2008-02-20 Thread Harvey Harrison
All were forward declared static already. Fixes sparse warnings: drivers/char/moxa.c:1421:6: warning: symbol 'MoxaDriverInit' was not declared. Should it be static? drivers/char/moxa.c:1464:6: warning: symbol 'MoxaPortFlushData' was not declared. Should it be static? drivers/char/moxa.c:1477:5:

Re: [PATCH 1/2] moxa: make functions static

2008-02-20 Thread Jiri Slaby
On 02/20/2008 11:14 PM, Harvey Harrison wrote: All were forward declared static already. Fixes sparse warnings: drivers/char/moxa.c:1421:6: warning: symbol 'MoxaDriverInit' was not declared. Should it be static? drivers/char/moxa.c:1464:6: warning: symbol 'MoxaPortFlushData' was not declared.

Re: [PATCH 1/2] moxa: make functions static

2008-02-20 Thread Harvey Harrison
On Thu, 2008-02-21 at 00:12 +0100, Jiri Slaby wrote: On 02/20/2008 11:14 PM, Harvey Harrison wrote: All were forward declared static already. Thanks, but I have similar fixes for both issues you address in my tree. I'll post it in few days. Great. Harvey -- To unsubscribe from this