On Mon, Jun 24, 2019 at 9:45 PM Kalle Valo wrote:
> New warning:
>
> drivers/net/wireless/marvell/mwifiex/wmm.c: In function
> 'mwifiex_wmm_process_tx':
> drivers/net/wireless/marvell/mwifiex/wmm.c:1438:4: warning: 'flags' may be
> used uninitialized in this function [-Wmaybe-uninitialized]
>
Brian Norris wrote:
> mwifiex_11n_scan_and_dispatch() and
> mwifiex_11n_dispatch_pkt_until_start_win() share similar patterns, where
> they perform a few different actions on the same table, using the same
> lock, but non-atomically. There have been other attempts to clean up
> this sort of
Hi Brian,
> (1) iterating / clearing the mwifiex reordering table
> (2) dispatching received packets to upper layers
>
> This makes it much harder to make lock recursion mistakes, as these two
> steps no longer need to hold the same locks.
Yes, this is clean;
>
> Testing: I've played with a
mwifiex_11n_scan_and_dispatch() and
mwifiex_11n_dispatch_pkt_until_start_win() share similar patterns, where
they perform a few different actions on the same table, using the same
lock, but non-atomically. There have been other attempts to clean up
this sort of behavior, but they have had problems
4 matches
Mail list logo
