Re: [PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable

On 7/19/07, rae l <[EMAIL PROTECTED]> wrote: On 7/19/07, Paul Clements <[EMAIL PROTECTED]> wrote: > Could you name "n" as "tmp" (as in the previous code) so that it's clear > that's only a temporary variable. Other than that, this looks good. Sure. I just use the name "n" as in the declaration

Re: [PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable

On 7/19/07, Paul Clements <[EMAIL PROTECTED]> wrote: Could you name "n" as "tmp" (as in the previous code) so that it's clear that's only a temporary variable. Other than that, this looks good. Sure. I just use the name "n" as in the declaration of list_for_each_entry_safe in the header file

Re: [PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable

Denis Cheng wrote: Thus the traverse of the loop may delete nodes, use the safe version. Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- drivers/block/nbd.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index

[PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable

Thus the traverse of the loop may delete nodes, use the safe version. Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- drivers/block/nbd.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index c129510..86639c0 100644 ---

[PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable

Thus the traverse of the loop may delete nodes, use the safe version. Signed-off-by: Denis Cheng [EMAIL PROTECTED] --- drivers/block/nbd.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index c129510..86639c0 100644 ---

Re: [PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable

Denis Cheng wrote: Thus the traverse of the loop may delete nodes, use the safe version. Signed-off-by: Denis Cheng [EMAIL PROTECTED] --- drivers/block/nbd.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index

Re: [PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable

On 7/19/07, Paul Clements [EMAIL PROTECTED] wrote: Could you name n as tmp (as in the previous code) so that it's clear that's only a temporary variable. Other than that, this looks good. Sure. I just use the name n as in the declaration of list_for_each_entry_safe in the header file

Re: [PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable

On 7/19/07, rae l [EMAIL PROTECTED] wrote: On 7/19/07, Paul Clements [EMAIL PROTECTED] wrote: Could you name n as tmp (as in the previous code) so that it's clear that's only a temporary variable. Other than that, this looks good. Sure. I just use the name n as in the declaration of