Re: [v7, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

2018-12-13 Thread biao huang
Dear Florian, Thanks for your comments. On Thu, 2018-12-13 at 21:11 -0800, Florian Fainelli wrote: > Le 12/13/18 à 7:01 PM, biao huang a écrit : > > Dear Andrew, > > Thanks for your comments. > > > > On Thu, 2018-12-13 at 13:33 +0100, Andrew Lunn wrote: > >> Hi Biao > >> > >>> + case

Re: [v7, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

2018-12-13 Thread Florian Fainelli
Le 12/13/18 à 7:01 PM, biao huang a écrit : > Dear Andrew, > Thanks for your comments. > > On Thu, 2018-12-13 at 13:33 +0100, Andrew Lunn wrote: >> Hi Biao >> >>> + case PHY_INTERFACE_MODE_RGMII: >>> + /* the PHY is not responsible for inserting any internal >>> +* de

Re: [v7, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

2018-12-13 Thread biao huang
Dear Andrew, Thanks for your comments. On Thu, 2018-12-13 at 13:33 +0100, Andrew Lunn wrote: > Hi Biao > > > + case PHY_INTERFACE_MODE_RGMII: > > + /* the PHY is not responsible for inserting any internal > > +* delay by itself in PHY_INTERFACE_MODE_RGMII case, > >

Re: [v7, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

2018-12-13 Thread Andrew Lunn
Hi Biao > + case PHY_INTERFACE_MODE_RGMII: > + /* the PHY is not responsible for inserting any internal > + * delay by itself in PHY_INTERFACE_MODE_RGMII case, > + * so Ethernet MAC will insert delays for both transmit > + * and receive path h

[v7, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

2018-12-12 Thread Biao Huang
Add Ethernet support for MediaTek SoCs from the mt2712 family Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/Kconfig|8 + drivers/net/ethernet/stmicro/stmmac/Makefile |1 + .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 413 3

[v6, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

2018-12-12 Thread Biao Huang
Add Ethernet support for MediaTek SoCs from the mt2712 family Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/Kconfig|8 + drivers/net/ethernet/stmicro/stmmac/Makefile |1 + .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 408 3

Re: [v5, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

2018-11-22 Thread Sean Wang
< ... > > > > + /* select phy interface in top control domain */ > > > + switch (plat->phy_mode) { > > > + case PHY_INTERFACE_MODE_MII: > > > + intf_val |= PHY_INTF_MII_GMII; > > > + break; > > > + case PHY_INTERFACE_MODE_RMII: > > > +

Re: [PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

2018-10-30 Thread Andrew Lunn
> > > + plat_dat->interface = priv_plat->phy_mode; > > > + /* clk_csr_i = 250-300MHz & MDC = clk_csr_i/124 */ > > > + plat_dat->clk_csr = 5; > > > + plat_dat->has_gmac4 = 1; > > > + plat_dat->has_gmac = 0; > > > + plat_dat->pmt = 0; > > > + plat_dat->maxmtu = 1500; > > > > ETH_DATA_LEN ? > how abo

[PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

2018-10-28 Thread Biao Huang
Add Ethernet support for MediaTek SoCs from the mt2712 family Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/Kconfig|8 + drivers/net/ethernet/stmicro/stmmac/Makefile |1 + .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 364 3