Re: [PATCH 1/2] nfsd: fix sparse warnings

2008-02-20 Thread J. Bruce Fields
On Wed, Feb 20, 2008 at 12:49:00PM -0800, Harvey Harrison wrote: > Add extern to nfsd/nfsd.h > fs/nfsd/nfssvc.c:146:5: warning: symbol 'nfsd_nrthreads' was not declared. > Should it be static? > fs/nfsd/nfssvc.c:261:5: warning: symbol 'nfsd_nrpools' was not declared. > Should it be static? >

[PATCH 1/2] nfsd: fix sparse warnings

2008-02-20 Thread Harvey Harrison
Add extern to nfsd/nfsd.h fs/nfsd/nfssvc.c:146:5: warning: symbol 'nfsd_nrthreads' was not declared. Should it be static? fs/nfsd/nfssvc.c:261:5: warning: symbol 'nfsd_nrpools' was not declared. Should it be static? fs/nfsd/nfssvc.c:269:5: warning: symbol 'nfsd_get_nrthreads' was not declared.

[PATCH 1/2] nfsd: fix sparse warnings

2008-02-20 Thread Harvey Harrison
Add extern to nfsd/nfsd.h fs/nfsd/nfssvc.c:146:5: warning: symbol 'nfsd_nrthreads' was not declared. Should it be static? fs/nfsd/nfssvc.c:261:5: warning: symbol 'nfsd_nrpools' was not declared. Should it be static? fs/nfsd/nfssvc.c:269:5: warning: symbol 'nfsd_get_nrthreads' was not declared.

Re: [PATCH 1/2] nfsd: fix sparse warnings

2008-02-20 Thread J. Bruce Fields
On Wed, Feb 20, 2008 at 12:49:00PM -0800, Harvey Harrison wrote: Add extern to nfsd/nfsd.h fs/nfsd/nfssvc.c:146:5: warning: symbol 'nfsd_nrthreads' was not declared. Should it be static? fs/nfsd/nfssvc.c:261:5: warning: symbol 'nfsd_nrpools' was not declared. Should it be static?