Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-16 Thread Linus Walleij
On Fri, Jun 14, 2013 at 4:52 PM, Laurent Pinchart wrote: > On Friday 14 June 2013 11:18:22 Heiko Stübner wrote: >> > What's the expected way to disable pull-ups in DT ? Should it be >> > 'bias-pull-up = <0>;' or 'bias-disable;' ? >> >> According to the kernedoc I think both are valid and should b

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-14 Thread Laurent Pinchart
Hi Heiko, On Friday 14 June 2013 11:18:22 Heiko Stübner wrote: > Am Freitag, 14. Juni 2013, 01:53:49 schrieb Laurent Pinchart: > > On Thursday 13 June 2013 17:36:00 Linus Walleij wrote: > > > On Thu, Jun 13, 2013 at 5:23 PM, Heiko Stübner wrote: > > > >> Ok, I'll see that I get this fixed :-) > >

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-14 Thread Laurent Pinchart
Hi Heiko, On Friday 14 June 2013 09:34:14 Heiko Stübner wrote: > Am Freitag, 14. Juni 2013, 02:27:01 schrieb Laurent Pinchart: > > Hi Heiko, > > > > Thank you for the patch. I've tested it on an sh73a0 KZM9G board with the > > sh- pfc driver and it seems to work fine. Please see the code below fo

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-14 Thread Heiko Stübner
Am Freitag, 14. Juni 2013, 01:53:49 schrieb Laurent Pinchart: > Hi Linus, > > On Thursday 13 June 2013 17:36:00 Linus Walleij wrote: > > On Thu, Jun 13, 2013 at 5:23 PM, Heiko Stübner wrote: > > >> Ok, I'll see that I get this fixed :-) > > > > > > Hmm ... what is the meaning of the argument of

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-14 Thread Heiko Stübner
Hi Laurent, Am Freitag, 14. Juni 2013, 02:27:01 schrieb Laurent Pinchart: > Hi Heiko, > > Thank you for the patch. I've tested it on an sh73a0 KZM9G board with the > sh- pfc driver and it seems to work fine. Please see the code below for > comments. > > On Monday 10 June 2013 21:40:29 Heiko Stüb

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-13 Thread Laurent Pinchart
Hi Heiko, Thank you for the patch. I've tested it on an sh73a0 KZM9G board with the sh- pfc driver and it seems to work fine. Please see the code below for comments. On Monday 10 June 2013 21:40:29 Heiko Stübner wrote: > pinconf_generic_parse_dt_config() takes a node as input and generates an > a

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-13 Thread Laurent Pinchart
Hi Linus, On Thursday 13 June 2013 17:36:00 Linus Walleij wrote: > On Thu, Jun 13, 2013 at 5:23 PM, Heiko Stübner wrote: > >> Ok, I'll see that I get this fixed :-) > > > > Hmm ... what is the meaning of the argument of bias-disable and bias-high- > > impedance, as the kernel-doc in pinconf-gene

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-13 Thread Linus Walleij
On Thu, Jun 13, 2013 at 5:23 PM, Heiko Stübner wrote: >> Ok, I'll see that I get this fixed :-) > > Hmm ... what is the meaning of the argument of bias-disable and bias-high- > impedance, as the kernel-doc in pinconf-generic.h does not tell? I think those arguments are N/A, ignored, doesn't matt

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-13 Thread Linus Walleij
On Thu, Jun 13, 2013 at 4:35 PM, Heiko Stübner wrote: > Am Donnerstag, 13. Juni 2013, 10:11:28 schrieb Linus Walleij: >> Tisdagen den 13:e Juni 2013 klock 12:22 AM, skrev Heiko Stübner >> > The only other candidate I could find was low-power-mode which really >> > could use a "1" as default. All

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-13 Thread Heiko Stübner
Am Donnerstag, 13. Juni 2013, 16:35:20 schrieb Heiko Stübner: > Am Donnerstag, 13. Juni 2013, 10:11:28 schrieb Linus Walleij: > > Tisdagen den 13:e Juni 2013 klock 12:22 AM, skrev Heiko Stübner > > > > : > > > Am Mittwoch, 12. Juni 2013, 16:55:12 schrieb James Hogan: > > >> > +static struct pincon

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-13 Thread Heiko Stübner
Am Donnerstag, 13. Juni 2013, 10:11:28 schrieb Linus Walleij: > Tisdagen den 13:e Juni 2013 klock 12:22 AM, skrev Heiko Stübner > > : > > Am Mittwoch, 12. Juni 2013, 16:55:12 schrieb James Hogan: > >> > +static struct pinconf_generic_dt_params dt_params[] = { > >> > + { "bias-disable", PIN_CONFI

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-13 Thread Linus Walleij
Tisdagen den 13:e Juni 2013 klock 12:22 AM, skrev Heiko Stübner : > Am Mittwoch, 12. Juni 2013, 16:55:12 schrieb James Hogan: >> > +static struct pinconf_generic_dt_params dt_params[] = { >> > + { "bias-disable", PIN_CONFIG_BIAS_DISABLE, 0 }, >> > + { "bias-high-impedance", PIN_CONFIG_BIAS_HIG

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-12 Thread Heiko Stübner
Hi James, Am Mittwoch, 12. Juni 2013, 16:55:12 schrieb James Hogan: > Hi Heiko, > > On 10/06/13 20:40, Heiko Stübner wrote: > > pinconf_generic_parse_dt_config() takes a node as input and generates an > > array of generic pinconfig values from the properties of this node. > > > > As I couldn't f

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-12 Thread James Hogan
Hi Heiko, On 10/06/13 20:40, Heiko Stübner wrote: > pinconf_generic_parse_dt_config() takes a node as input and generates an > array of generic pinconfig values from the properties of this node. > > As I couldn't find a mechanism to count the number of properties of a node > the function uses int

Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-11 Thread Linus Walleij
On Mon, Jun 10, 2013 at 9:40 PM, Heiko Stübner wrote: > pinconf_generic_parse_dt_config() takes a node as input and generates an > array of generic pinconfig values from the properties of this node. > > As I couldn't find a mechanism to count the number of properties of a node > the function uses

[PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node

2013-06-10 Thread Heiko Stübner
pinconf_generic_parse_dt_config() takes a node as input and generates an array of generic pinconfig values from the properties of this node. As I couldn't find a mechanism to count the number of properties of a node the function uses internally an array to accept one of parameter and copies the re