Re: [PATCH 1/2] pinctrl: mediatek: Add mtk_eint_pm_ops to common-v2

2019-05-08 Thread Nicolas Boichat
On Sat, May 4, 2019 at 2:09 AM Sean Wang wrote: > > Hi, Nicolas > > On Thu, May 2, 2019 at 5:53 PM Nicolas Boichat wrote: > > > > On Thu, May 2, 2019 at 9:48 PM Yingjoe Chen > > wrote: > > > > > > On Mon, 2019-04-29 at 11:25 +0800, Nicolas Boichat wrote: > > > > pinctrl variants that include

Re: [PATCH 1/2] pinctrl: mediatek: Add mtk_eint_pm_ops to common-v2

2019-05-03 Thread Sean Wang
Hi, Nicolas On Thu, May 2, 2019 at 5:53 PM Nicolas Boichat wrote: > > On Thu, May 2, 2019 at 9:48 PM Yingjoe Chen wrote: > > > > On Mon, 2019-04-29 at 11:25 +0800, Nicolas Boichat wrote: > > > pinctrl variants that include pinctrl-mtk-common-v2.h (and not > > > pinctrl-mtk-common.h) also need

Re: [PATCH 1/2] pinctrl: mediatek: Add mtk_eint_pm_ops to common-v2

2019-05-02 Thread Nicolas Boichat
On Thu, May 2, 2019 at 9:48 PM Yingjoe Chen wrote: > > On Mon, 2019-04-29 at 11:25 +0800, Nicolas Boichat wrote: > > pinctrl variants that include pinctrl-mtk-common-v2.h (and not > > pinctrl-mtk-common.h) also need to use mtk_eint_pm_ops to setup > > wake mask properly, so copy over the pm_ops

Re: [PATCH 1/2] pinctrl: mediatek: Add mtk_eint_pm_ops to common-v2

2019-05-02 Thread Yingjoe Chen
On Mon, 2019-04-29 at 11:25 +0800, Nicolas Boichat wrote: > pinctrl variants that include pinctrl-mtk-common-v2.h (and not > pinctrl-mtk-common.h) also need to use mtk_eint_pm_ops to setup > wake mask properly, so copy over the pm_ops to v2. > > It is not easy to merge the 2 copies (or move >

[PATCH 1/2] pinctrl: mediatek: Add mtk_eint_pm_ops to common-v2

2019-04-28 Thread Nicolas Boichat
pinctrl variants that include pinctrl-mtk-common-v2.h (and not pinctrl-mtk-common.h) also need to use mtk_eint_pm_ops to setup wake mask properly, so copy over the pm_ops to v2. It is not easy to merge the 2 copies (or move mtk_eint_suspend/resume to mtk-eint.c), as we need to dereference