Re: [PATCH 1/2] pinctrl: remove unneeded #ifdef around declarations

2019-06-26 Thread Masahiro Yamada
On Tue, Jun 25, 2019 at 5:52 PM Linus Walleij wrote: > > Hi Masahiro, > > thanks for your patch. For some reason I managed to pick up > patch 2 before patch 1. I applied this now with some fuzzing. > (Please check the result.) > > On Thu, Jun 13, 2019 at 3:55 AM Masahiro Yamada > wrote: > > > Wha

Re: [PATCH 1/2] pinctrl: remove unneeded #ifdef around declarations

2019-06-25 Thread Linus Walleij
Hi Masahiro, thanks for your patch. For some reason I managed to pick up patch 2 before patch 1. I applied this now with some fuzzing. (Please check the result.) On Thu, Jun 13, 2019 at 3:55 AM Masahiro Yamada wrote: > What is the point in surrounding the whole of declarations with > ifdef like

Re: [PATCH 1/2] pinctrl: remove unneeded #ifdef around declarations

2019-06-14 Thread Masahiro Yamada
On Fri, Jun 14, 2019 at 10:21 PM Enrico Weigelt, metux IT consult wrote: > > On 13.06.19 03:55, Masahiro Yamada wrote: > > What is the point in surrounding the whole of declarations with > > ifdef like this? > > > > #ifdef CONFIG_FOO > > int foo(void); > > #endif > > > > If CONFIG_FOO is not

Re: [PATCH 1/2] pinctrl: remove unneeded #ifdef around declarations

2019-06-14 Thread Enrico Weigelt, metux IT consult
On 13.06.19 03:55, Masahiro Yamada wrote: > What is the point in surrounding the whole of declarations with > ifdef like this? > > #ifdef CONFIG_FOO > int foo(void); > #endif > > If CONFIG_FOO is not defined, all callers of foo() will fail > with implicit declaration errors since the top Ma

[PATCH 1/2] pinctrl: remove unneeded #ifdef around declarations

2019-06-13 Thread Masahiro Yamada
What is the point in surrounding the whole of declarations with ifdef like this? #ifdef CONFIG_FOO int foo(void); #endif If CONFIG_FOO is not defined, all callers of foo() will fail with implicit declaration errors since the top Makefile adds -Werror-implicit-function-declaration to KBUILD_