Hi,
On 09-06-18 02:33, Darren Hart wrote:
On Wed, Jun 06, 2018 at 05:32:52PM +0200, Hans de Goede wrote:
If we are adding hwdb entries anyway to control the userspace
interpretation of the TOGGLE key, then we could also add the new CYCLE
key and explicitly re-map it to TOGGLE. That requires
Hi,
On 09-06-18 02:33, Darren Hart wrote:
On Wed, Jun 06, 2018 at 05:32:52PM +0200, Hans de Goede wrote:
If we are adding hwdb entries anyway to control the userspace
interpretation of the TOGGLE key, then we could also add the new CYCLE
key and explicitly re-map it to TOGGLE. That requires
On Wed, Jun 06, 2018 at 05:32:52PM +0200, Hans de Goede wrote:
> > > > > If we are adding hwdb entries anyway to control the userspace
> > > > > interpretation of the TOGGLE key, then we could also add the new CYCLE
> > > > > key and explicitly re-map it to TOGGLE. That requires slightly more
> >
On Wed, Jun 06, 2018 at 05:32:52PM +0200, Hans de Goede wrote:
> > > > > If we are adding hwdb entries anyway to control the userspace
> > > > > interpretation of the TOGGLE key, then we could also add the new CYCLE
> > > > > key and explicitly re-map it to TOGGLE. That requires slightly more
> >
Hi,
On 06-06-18 16:27, Benjamin Berg wrote:
Hi,
On Wed, 2018-06-06 at 10:50 +0800, Chris Chiu wrote:
On Tue, Jun 5, 2018 at 7:06 PM, Hans de Goede
wrote:
Hi,
On 05-06-18 12:46, Benjamin Berg wrote:
Hey,
On Tue, 2018-06-05 at 12:31 +0200, Hans de Goede wrote:
On 05-06-18 12:14,
Hi,
On 06-06-18 16:27, Benjamin Berg wrote:
Hi,
On Wed, 2018-06-06 at 10:50 +0800, Chris Chiu wrote:
On Tue, Jun 5, 2018 at 7:06 PM, Hans de Goede
wrote:
Hi,
On 05-06-18 12:46, Benjamin Berg wrote:
Hey,
On Tue, 2018-06-05 at 12:31 +0200, Hans de Goede wrote:
On 05-06-18 12:14,
Hi,
On Wed, 2018-06-06 at 10:50 +0800, Chris Chiu wrote:
> On Tue, Jun 5, 2018 at 7:06 PM, Hans de Goede
> wrote:
> > Hi,
> >
> >
> > On 05-06-18 12:46, Benjamin Berg wrote:
> > >
> > > Hey,
> > >
> > > On Tue, 2018-06-05 at 12:31 +0200, Hans de Goede wrote:
> > > >
> > > > On 05-06-18
Hi,
On Wed, 2018-06-06 at 10:50 +0800, Chris Chiu wrote:
> On Tue, Jun 5, 2018 at 7:06 PM, Hans de Goede
> wrote:
> > Hi,
> >
> >
> > On 05-06-18 12:46, Benjamin Berg wrote:
> > >
> > > Hey,
> > >
> > > On Tue, 2018-06-05 at 12:31 +0200, Hans de Goede wrote:
> > > >
> > > > On 05-06-18
On Tue, Jun 5, 2018 at 7:06 PM, Hans de Goede wrote:
> Hi,
>
>
> On 05-06-18 12:46, Benjamin Berg wrote:
>>
>> Hey,
>>
>> On Tue, 2018-06-05 at 12:31 +0200, Hans de Goede wrote:
>>>
>>> On 05-06-18 12:14, Bastien Nocera wrote:
On Tue, 2018-06-05 at 12:05 +0200, Hans de Goede wrote:
On Tue, Jun 5, 2018 at 7:06 PM, Hans de Goede wrote:
> Hi,
>
>
> On 05-06-18 12:46, Benjamin Berg wrote:
>>
>> Hey,
>>
>> On Tue, 2018-06-05 at 12:31 +0200, Hans de Goede wrote:
>>>
>>> On 05-06-18 12:14, Bastien Nocera wrote:
On Tue, 2018-06-05 at 12:05 +0200, Hans de Goede wrote:
Hi,
On 05-06-18 12:46, Benjamin Berg wrote:
Hey,
On Tue, 2018-06-05 at 12:31 +0200, Hans de Goede wrote:
On 05-06-18 12:14, Bastien Nocera wrote:
On Tue, 2018-06-05 at 12:05 +0200, Hans de Goede wrote:
On 05-06-18 11:58, Bastien Nocera wrote:
[SNIP]
Ok, so what are you suggestion, do you
Hi,
On 05-06-18 12:46, Benjamin Berg wrote:
Hey,
On Tue, 2018-06-05 at 12:31 +0200, Hans de Goede wrote:
On 05-06-18 12:14, Bastien Nocera wrote:
On Tue, 2018-06-05 at 12:05 +0200, Hans de Goede wrote:
On 05-06-18 11:58, Bastien Nocera wrote:
[SNIP]
Ok, so what are you suggestion, do you
Hey,
On Tue, 2018-06-05 at 12:31 +0200, Hans de Goede wrote:
> On 05-06-18 12:14, Bastien Nocera wrote:
> > On Tue, 2018-06-05 at 12:05 +0200, Hans de Goede wrote:
> > > On 05-06-18 11:58, Bastien Nocera wrote:
> > > > [SNIP]
> > >
> > > Ok, so what are you suggestion, do you really want to
Hey,
On Tue, 2018-06-05 at 12:31 +0200, Hans de Goede wrote:
> On 05-06-18 12:14, Bastien Nocera wrote:
> > On Tue, 2018-06-05 at 12:05 +0200, Hans de Goede wrote:
> > > On 05-06-18 11:58, Bastien Nocera wrote:
> > > > [SNIP]
> > >
> > > Ok, so what are you suggestion, do you really want to
Hi,
On 05-06-18 12:14, Bastien Nocera wrote:
On Tue, 2018-06-05 at 12:05 +0200, Hans de Goede wrote:
Hi,
On 05-06-18 11:58, Bastien Nocera wrote:
On Tue, 2018-06-05 at 09:37 +0200, Hans de Goede wrote:
Hi,
On 05-06-18 05:18, Chris Chiu wrote:
On Tue, Jun 5, 2018 at 10:31 AM, Darren Hart
Hi,
On 05-06-18 12:14, Bastien Nocera wrote:
On Tue, 2018-06-05 at 12:05 +0200, Hans de Goede wrote:
Hi,
On 05-06-18 11:58, Bastien Nocera wrote:
On Tue, 2018-06-05 at 09:37 +0200, Hans de Goede wrote:
Hi,
On 05-06-18 05:18, Chris Chiu wrote:
On Tue, Jun 5, 2018 at 10:31 AM, Darren Hart
On Tue, 2018-06-05 at 12:05 +0200, Hans de Goede wrote:
> Hi,
>
> On 05-06-18 11:58, Bastien Nocera wrote:
> > On Tue, 2018-06-05 at 09:37 +0200, Hans de Goede wrote:
> > > Hi,
> > >
> > > On 05-06-18 05:18, Chris Chiu wrote:
> > > > On Tue, Jun 5, 2018 at 10:31 AM, Darren Hart > > > org>
> > >
On Tue, 2018-06-05 at 12:05 +0200, Hans de Goede wrote:
> Hi,
>
> On 05-06-18 11:58, Bastien Nocera wrote:
> > On Tue, 2018-06-05 at 09:37 +0200, Hans de Goede wrote:
> > > Hi,
> > >
> > > On 05-06-18 05:18, Chris Chiu wrote:
> > > > On Tue, Jun 5, 2018 at 10:31 AM, Darren Hart > > > org>
> > >
On Tue, 2018-06-05 at 09:37 +0200, Hans de Goede wrote:
> Hi,
>
> On 05-06-18 05:18, Chris Chiu wrote:
> > On Tue, Jun 5, 2018 at 10:31 AM, Darren Hart
> > wrote:
> > > On Mon, Jun 04, 2018 at 04:23:04PM +0200, Hans de Goede wrote:
> > > > Hi,
> > > >
> > > > On 04-06-18 15:51, Daniel Drake
On Tue, 2018-06-05 at 09:37 +0200, Hans de Goede wrote:
> Hi,
>
> On 05-06-18 05:18, Chris Chiu wrote:
> > On Tue, Jun 5, 2018 at 10:31 AM, Darren Hart
> > wrote:
> > > On Mon, Jun 04, 2018 at 04:23:04PM +0200, Hans de Goede wrote:
> > > > Hi,
> > > >
> > > > On 04-06-18 15:51, Daniel Drake
Hi,
On 05-06-18 11:58, Bastien Nocera wrote:
On Tue, 2018-06-05 at 09:37 +0200, Hans de Goede wrote:
Hi,
On 05-06-18 05:18, Chris Chiu wrote:
On Tue, Jun 5, 2018 at 10:31 AM, Darren Hart
wrote:
On Mon, Jun 04, 2018 at 04:23:04PM +0200, Hans de Goede wrote:
Hi,
On 04-06-18 15:51, Daniel
Hi,
On 05-06-18 11:58, Bastien Nocera wrote:
On Tue, 2018-06-05 at 09:37 +0200, Hans de Goede wrote:
Hi,
On 05-06-18 05:18, Chris Chiu wrote:
On Tue, Jun 5, 2018 at 10:31 AM, Darren Hart
wrote:
On Mon, Jun 04, 2018 at 04:23:04PM +0200, Hans de Goede wrote:
Hi,
On 04-06-18 15:51, Daniel
Hi,
On 05-06-18 05:18, Chris Chiu wrote:
On Tue, Jun 5, 2018 at 10:31 AM, Darren Hart wrote:
On Mon, Jun 04, 2018 at 04:23:04PM +0200, Hans de Goede wrote:
Hi,
On 04-06-18 15:51, Daniel Drake wrote:
On Mon, Jun 4, 2018 at 7:22 AM, Hans de Goede wrote:
Is this really a case of the
Hi,
On 05-06-18 05:18, Chris Chiu wrote:
On Tue, Jun 5, 2018 at 10:31 AM, Darren Hart wrote:
On Mon, Jun 04, 2018 at 04:23:04PM +0200, Hans de Goede wrote:
Hi,
On 04-06-18 15:51, Daniel Drake wrote:
On Mon, Jun 4, 2018 at 7:22 AM, Hans de Goede wrote:
Is this really a case of the
Hi,
On 05-06-18 04:31, Darren Hart wrote:
On Mon, Jun 04, 2018 at 04:23:04PM +0200, Hans de Goede wrote:
Hi,
On 04-06-18 15:51, Daniel Drake wrote:
On Mon, Jun 4, 2018 at 7:22 AM, Hans de Goede wrote:
Is this really a case of the hardware itself processing the
keypress and then changing
Hi,
On 05-06-18 04:31, Darren Hart wrote:
On Mon, Jun 04, 2018 at 04:23:04PM +0200, Hans de Goede wrote:
Hi,
On 04-06-18 15:51, Daniel Drake wrote:
On Mon, Jun 4, 2018 at 7:22 AM, Hans de Goede wrote:
Is this really a case of the hardware itself processing the
keypress and then changing
On Tue, Jun 5, 2018 at 10:31 AM, Darren Hart wrote:
> On Mon, Jun 04, 2018 at 04:23:04PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 04-06-18 15:51, Daniel Drake wrote:
>> > On Mon, Jun 4, 2018 at 7:22 AM, Hans de Goede wrote:
>> > > Is this really a case of the hardware itself processing the
>>
On Tue, Jun 5, 2018 at 10:31 AM, Darren Hart wrote:
> On Mon, Jun 04, 2018 at 04:23:04PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 04-06-18 15:51, Daniel Drake wrote:
>> > On Mon, Jun 4, 2018 at 7:22 AM, Hans de Goede wrote:
>> > > Is this really a case of the hardware itself processing the
>>
On Mon, Jun 04, 2018 at 04:23:04PM +0200, Hans de Goede wrote:
> Hi,
>
> On 04-06-18 15:51, Daniel Drake wrote:
> > On Mon, Jun 4, 2018 at 7:22 AM, Hans de Goede wrote:
> > > Is this really a case of the hardware itself processing the
> > > keypress and then changing the brightness *itself* ?
>
On Mon, Jun 04, 2018 at 04:23:04PM +0200, Hans de Goede wrote:
> Hi,
>
> On 04-06-18 15:51, Daniel Drake wrote:
> > On Mon, Jun 4, 2018 at 7:22 AM, Hans de Goede wrote:
> > > Is this really a case of the hardware itself processing the
> > > keypress and then changing the brightness *itself* ?
>
On Mon, Jun 04, 2018 at 08:32:37PM +0800, Chris Chiu wrote:
> Make asus-wmi notify on hotkey kbd brightness changes, listen for
> brightness events and update the brightness directly in the driver.
> For this purpose, bound check on brightness in kbd_led_set must be
> based on the same data type
On Mon, Jun 04, 2018 at 08:32:37PM +0800, Chris Chiu wrote:
> Make asus-wmi notify on hotkey kbd brightness changes, listen for
> brightness events and update the brightness directly in the driver.
> For this purpose, bound check on brightness in kbd_led_set must be
> based on the same data type
Hi there
Let me add my two cents on the Toshiba side.
2018-06-04 8:23 GMT-06:00 Hans de Goede :
>
> 1) drivers/platform/x86/toshiba_acpi.c
>
> I don't know how the key on Toshiba's behaves on models where
> it is hardwired / under Windows
With Toshiba we have two types of hardware
Hi there
Let me add my two cents on the Toshiba side.
2018-06-04 8:23 GMT-06:00 Hans de Goede :
>
> 1) drivers/platform/x86/toshiba_acpi.c
>
> I don't know how the key on Toshiba's behaves on models where
> it is hardwired / under Windows
With Toshiba we have two types of hardware
Hi,
On 04-06-18 15:51, Daniel Drake wrote:
On Mon, Jun 4, 2018 at 7:22 AM, Hans de Goede wrote:
Is this really a case of the hardware itself processing the
keypress and then changing the brightness *itself* ?
From the "[PATCH 2/2] platform/x86: asus-wmi: Add keyboard backlight
toggle
Hi,
On 04-06-18 15:51, Daniel Drake wrote:
On Mon, Jun 4, 2018 at 7:22 AM, Hans de Goede wrote:
Is this really a case of the hardware itself processing the
keypress and then changing the brightness *itself* ?
From the "[PATCH 2/2] platform/x86: asus-wmi: Add keyboard backlight
toggle
On Mon, Jun 4, 2018 at 7:22 AM, Hans de Goede wrote:
> Is this really a case of the hardware itself processing the
> keypress and then changing the brightness *itself* ?
>
> From the "[PATCH 2/2] platform/x86: asus-wmi: Add keyboard backlight
> toggle support" patch I get the impression that the
On Mon, Jun 4, 2018 at 7:22 AM, Hans de Goede wrote:
> Is this really a case of the hardware itself processing the
> keypress and then changing the brightness *itself* ?
>
> From the "[PATCH 2/2] platform/x86: asus-wmi: Add keyboard backlight
> toggle support" patch I get the impression that the
Hi Chris.
On 04-06-18 14:32, Chris Chiu wrote:
Make asus-wmi notify on hotkey kbd brightness changes, listen for
brightness events and update the brightness directly in the driver.
For this purpose, bound check on brightness in kbd_led_set must be
based on the same data type to prevent illegal
Hi Chris.
On 04-06-18 14:32, Chris Chiu wrote:
Make asus-wmi notify on hotkey kbd brightness changes, listen for
brightness events and update the brightness directly in the driver.
For this purpose, bound check on brightness in kbd_led_set must be
based on the same data type to prevent illegal
Make asus-wmi notify on hotkey kbd brightness changes, listen for
brightness events and update the brightness directly in the driver.
For this purpose, bound check on brightness in kbd_led_set must be
based on the same data type to prevent illegal value been set.
Update the brightness by
Make asus-wmi notify on hotkey kbd brightness changes, listen for
brightness events and update the brightness directly in the driver.
For this purpose, bound check on brightness in kbd_led_set must be
based on the same data type to prevent illegal value been set.
Update the brightness by
42 matches
Mail list logo
