Re: [PATCH 1/2] rtc: max77686: convert to devm_i2c_new_dummy_device()

2019-08-30 Thread Wolfram Sang
> > Nope, they should be incremental, aren't they? > > > No, your patches don't apply on top of rtc-next Looks like you edited some whitespaces to match opening parens before applying? I'll resend to match these. signature.asc Description: PGP signature

Re: [PATCH 1/2] rtc: max77686: convert to devm_i2c_new_dummy_device()

2019-08-30 Thread Alexandre Belloni
On 30/08/2019 15:00:35+0200, Wolfram Sang wrote: > > > > > I'm confused because I already applied: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next=7150710f3084de8d35ce3221eeae2caee8813f92 > > > > > > The above was a mass conversion to

Re: [PATCH 1/2] rtc: max77686: convert to devm_i2c_new_dummy_device()

2019-08-30 Thread Wolfram Sang
> > > I'm confused because I already applied: > > > https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next=7150710f3084de8d35ce3221eeae2caee8813f92 > > > > The above was a mass conversion to i2c_new_dummy_device() to make sure > > all in-kernel users use the API

Re: [PATCH 1/2] rtc: max77686: convert to devm_i2c_new_dummy_device()

2019-08-30 Thread Alexandre Belloni
On 30/08/2019 14:45:54+0200, Wolfram Sang wrote: > On Thu, Aug 29, 2019 at 10:57:52PM +0200, Alexandre Belloni wrote: > > On 20/08/2019 17:42:37+0200, Wolfram Sang wrote: > > > I was about to simplify the call to i2c_unregister_device() when I > > > realized that converting to

Re: [PATCH 1/2] rtc: max77686: convert to devm_i2c_new_dummy_device()

2019-08-30 Thread Wolfram Sang
On Thu, Aug 29, 2019 at 10:57:52PM +0200, Alexandre Belloni wrote: > On 20/08/2019 17:42:37+0200, Wolfram Sang wrote: > > I was about to simplify the call to i2c_unregister_device() when I > > realized that converting to devm_i2c_new_dummy_device() will simplify > > the driver a lot. So I took

Re: [PATCH 1/2] rtc: max77686: convert to devm_i2c_new_dummy_device()

2019-08-29 Thread Alexandre Belloni
On 20/08/2019 17:42:37+0200, Wolfram Sang wrote: > I was about to simplify the call to i2c_unregister_device() when I > realized that converting to devm_i2c_new_dummy_device() will simplify > the driver a lot. So I took this approach. > > Signed-off-by: Wolfram Sang > --- > Build tested only,

[PATCH 1/2] rtc: max77686: convert to devm_i2c_new_dummy_device()

2019-08-20 Thread Wolfram Sang
I was about to simplify the call to i2c_unregister_device() when I realized that converting to devm_i2c_new_dummy_device() will simplify the driver a lot. So I took this approach. Signed-off-by: Wolfram Sang --- Build tested only, buildbot is happy, too. Please apply to your tree.