Re: [PATCH 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-24 Thread Mimi Zohar
On Tue, 2018-07-24 at 12:31 +, Udit Agarwal wrote: > Yes the secure keys and CAAM are correlated. Secure keys depends on > NXP CAAM crypto HW accelerator.  Secure key is a random data of > length X (passed using keyctl command) & derived using CAAM. Blob of > this data is also created using

Re: [PATCH 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-24 Thread Mimi Zohar
On Tue, 2018-07-24 at 12:31 +, Udit Agarwal wrote: > Yes the secure keys and CAAM are correlated. Secure keys depends on > NXP CAAM crypto HW accelerator.  Secure key is a random data of > length X (passed using keyctl command) & derived using CAAM. Blob of > this data is also created using

RE: [PATCH 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-24 Thread Udit Agarwal
> On Fri, 2018-07-20 at 11:16 +0530, Udit Agarwal wrote: > > Secure keys are derieved using CAAM crypto block. > > > > Secure keys derieved are the random number symmetric keys from CAAM. > > Blobs corresponding to the key are formed using CAAM. User space will > > only be able to view the blob of

RE: [PATCH 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-24 Thread Udit Agarwal
> On Fri, 2018-07-20 at 11:16 +0530, Udit Agarwal wrote: > > Secure keys are derieved using CAAM crypto block. > > > > Secure keys derieved are the random number symmetric keys from CAAM. > > Blobs corresponding to the key are formed using CAAM. User space will > > only be able to view the blob of

Re: [PATCH 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-23 Thread Jan Lübbe
Hi, On Sat, 2018-07-21 at 14:44 +, Udit Agarwal wrote: > Thanks for sharing the documentation changes and feedback. > > Below are the answers to the questions: > > 1. Currently the secure key patch series has been added to support > only data blobs. > It is not supporting key blobs as of

Re: [PATCH 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-23 Thread Jan Lübbe
Hi, On Sat, 2018-07-21 at 14:44 +, Udit Agarwal wrote: > Thanks for sharing the documentation changes and feedback. > > Below are the answers to the questions: > > 1. Currently the secure key patch series has been added to support > only data blobs. > It is not supporting key blobs as of

Re: [PATCH 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-22 Thread Mimi Zohar
On Fri, 2018-07-20 at 11:16 +0530, Udit Agarwal wrote: > Secure keys are derieved using CAAM crypto block. > > Secure keys derieved are the random number symmetric keys from CAAM. > Blobs corresponding to the key are formed using CAAM. User space > will only be able to view the blob of the key.

Re: [PATCH 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-22 Thread Mimi Zohar
On Fri, 2018-07-20 at 11:16 +0530, Udit Agarwal wrote: > Secure keys are derieved using CAAM crypto block. > > Secure keys derieved are the random number symmetric keys from CAAM. > Blobs corresponding to the key are formed using CAAM. User space > will only be able to view the blob of the key.

RE: [PATCH 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-21 Thread Udit Agarwal
at.com; > zo...@linux.vnet.ibm.com; jmor...@namei.org; se...@hallyn.com; linux- > integr...@vger.kernel.org; keyri...@vger.kernel.org; linux-security- > mod...@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: Sahil Malhotra > Subject: Re: [PATCH 1/2] security/keys/secure_key: Adds the

RE: [PATCH 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-21 Thread Udit Agarwal
at.com; > zo...@linux.vnet.ibm.com; jmor...@namei.org; se...@hallyn.com; linux- > integr...@vger.kernel.org; keyri...@vger.kernel.org; linux-security- > mod...@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: Sahil Malhotra > Subject: Re: [PATCH 1/2] security/keys/secure_key: Adds the

Re: [PATCH 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-20 Thread kbuild test robot
Hi Udit, I love your patch! Yet something to improve: [auto build test ERROR on security/next] [also build test ERROR on v4.18-rc5 next-20180720] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-20 Thread kbuild test robot
Hi Udit, I love your patch! Yet something to improve: [auto build test ERROR on security/next] [also build test ERROR on v4.18-rc5 next-20180720] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-20 Thread Jan Lübbe
On Fri, 2018-07-20 at 11:16 +0530, Udit Agarwal wrote: > +== > +Secure Key > +== > + > +Secure key is the new type added to kernel key ring service. > +Secure key is a symmetric type key of minimum length 32 bytes > +and with maximum possible length to be 128 bytes. It is produced

Re: [PATCH 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-20 Thread Jan Lübbe
On Fri, 2018-07-20 at 11:16 +0530, Udit Agarwal wrote: > +== > +Secure Key > +== > + > +Secure key is the new type added to kernel key ring service. > +Secure key is a symmetric type key of minimum length 32 bytes > +and with maximum possible length to be 128 bytes. It is produced

[PATCH 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-20 Thread Udit Agarwal
Secure keys are derieved using CAAM crypto block. Secure keys derieved are the random number symmetric keys from CAAM. Blobs corresponding to the key are formed using CAAM. User space will only be able to view the blob of the key. Signed-off-by: Udit Agarwal Reviewed-by: Sahil Malhotra ---

[PATCH 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-20 Thread Udit Agarwal
Secure keys are derieved using CAAM crypto block. Secure keys derieved are the random number symmetric keys from CAAM. Blobs corresponding to the key are formed using CAAM. User space will only be able to view the blob of the key. Signed-off-by: Udit Agarwal Reviewed-by: Sahil Malhotra ---