Re: [PATCH 1/2] selftests: watchdog: Validate optional file argument

2019-09-17 Thread Eugeniu Rosca
(For LKML readability) Superseded by: - https://patchwork.kernel.org/patch/11149287/ ("[v3,1/2] selftests: watchdog: Validate optional file argument") -- Best Regards, Eugeniu.

Re: [PATCH 1/2] selftests: watchdog: Validate optional file argument

2019-09-16 Thread shuah
On 9/16/19 6:08 AM, Eugeniu Rosca wrote: Hi Shuah, On Sat, Sep 07, 2019 at 10:58:32AM +0200, Eugeniu Rosca wrote: From: "George G. Davis" As reported by Eugeniu Rosca, the newly added optional file argument does not validate if the file is indeed a watchdog, e.g.: ./watchdog-test -f

Re: [PATCH 1/2] selftests: watchdog: Validate optional file argument

2019-09-16 Thread shuah
On 9/7/19 2:58 AM, Eugeniu Rosca wrote: From: "George G. Davis" As reported by Eugeniu Rosca, the newly added optional file argument does not validate if the file is indeed a watchdog, e.g.: ./watchdog-test -f /dev/zero Watchdog Ticking Away! Fix it by confirming that the WDIOC_GETSUPPORT

Re: [PATCH 1/2] selftests: watchdog: Validate optional file argument

2019-09-16 Thread Eugeniu Rosca
Hi Shuah, On Sat, Sep 07, 2019 at 10:58:32AM +0200, Eugeniu Rosca wrote: > From: "George G. Davis" > > As reported by Eugeniu Rosca, the newly added optional file > argument does not validate if the file is indeed a watchdog, e.g.: > > ./watchdog-test -f /dev/zero > Watchdog Ticking Away! >

[PATCH 1/2] selftests: watchdog: Validate optional file argument

2019-09-07 Thread Eugeniu Rosca
From: "George G. Davis" As reported by Eugeniu Rosca, the newly added optional file argument does not validate if the file is indeed a watchdog, e.g.: ./watchdog-test -f /dev/zero Watchdog Ticking Away! Fix it by confirming that the WDIOC_GETSUPPORT ioctl succeeds. Reported-by: Eugeniu Rosca