Re: [PATCH 1/2] sparc: Fix handling of page table constructor failure

2020-11-25 Thread David Hildenbrand
On 25.11.20 13:10, Matthew Wilcox wrote: > On Wed, Nov 25, 2020 at 09:43:15AM +0100, David Hildenbrand wrote: >> On 25.11.20 04:46, Matthew Wilcox (Oracle) wrote: >>> The page has just been allocated, so its refcount is 1. free_unref_page() >>> is for use on pages which have a zero refcount. Use

Re: [PATCH 1/2] sparc: Fix handling of page table constructor failure

2020-11-25 Thread Vlastimil Babka
On 11/25/20 4:46 AM, Matthew Wilcox (Oracle) wrote: The page has just been allocated, so its refcount is 1. free_unref_page() is for use on pages which have a zero refcount. Use __free_page() like the other implementations of pte_alloc_one(). Fixes: 1ae9ae5f7df7 ("sparc: handle

Re: [PATCH 1/2] sparc: Fix handling of page table constructor failure

2020-11-25 Thread Matthew Wilcox
On Wed, Nov 25, 2020 at 09:43:15AM +0100, David Hildenbrand wrote: > On 25.11.20 04:46, Matthew Wilcox (Oracle) wrote: > > The page has just been allocated, so its refcount is 1. free_unref_page() > > is for use on pages which have a zero refcount. Use __free_page() > > like the other

Re: [PATCH 1/2] sparc: Fix handling of page table constructor failure

2020-11-25 Thread Mike Rapoport
On Wed, Nov 25, 2020 at 03:46:54AM +, Matthew Wilcox (Oracle) wrote: > The page has just been allocated, so its refcount is 1. free_unref_page() > is for use on pages which have a zero refcount. Use __free_page() > like the other implementations of pte_alloc_one(). > > Fixes: 1ae9ae5f7df7

Re: [PATCH 1/2] sparc: Fix handling of page table constructor failure

2020-11-25 Thread David Hildenbrand
On 25.11.20 04:46, Matthew Wilcox (Oracle) wrote: > The page has just been allocated, so its refcount is 1. free_unref_page() > is for use on pages which have a zero refcount. Use __free_page() > like the other implementations of pte_alloc_one(). > > Fixes: 1ae9ae5f7df7 ("sparc: handle

[PATCH 1/2] sparc: Fix handling of page table constructor failure

2020-11-24 Thread Matthew Wilcox (Oracle)
The page has just been allocated, so its refcount is 1. free_unref_page() is for use on pages which have a zero refcount. Use __free_page() like the other implementations of pte_alloc_one(). Fixes: 1ae9ae5f7df7 ("sparc: handle pgtable_page_ctor() fail") Signed-off-by: Matthew Wilcox (Oracle)