Re: [PATCH 1/2] staging: ft1000: remove unused variables

2015-03-17 Thread Sudip Mukherjee
On Mon, Mar 16, 2015 at 04:33:02PM +0100, Greg KH wrote: > On Sat, Mar 07, 2015 at 10:56:52AM +0530, Sudip Mukherjee wrote: > > these variables were assigned some values but they were never being > > reused again. > > But some of them should have been checked, right? Or, if no one cares, > fix up

Re: [PATCH 1/2] staging: ft1000: remove unused variables

2015-03-16 Thread Greg KH
On Sat, Mar 07, 2015 at 10:56:52AM +0530, Sudip Mukherjee wrote: > these variables were assigned some values but they were never being > reused again. But some of them should have been checked, right? Or, if no one cares, fix up the function to not return anything, like for all of the read_regist

[PATCH 1/2] staging: ft1000: remove unused variables

2015-03-06 Thread Sudip Mukherjee
these variables were assigned some values but they were never being reused again. Signed-off-by: Sudip Mukherjee --- this patch will generate some checkpatch warning about line being above 80char, but the code is so much indented that it is difficult to break the line. drivers/staging/ft1000/f