Re: [PATCH 1/2] staging: rtl8188eu: fix usage of uninit scalar in rtw_drv_init()

2014-05-17 Thread Dan Carpenter
On Sat, May 17, 2014 at 08:56:35PM +0200, Christian Engelmayer wrote: > On Sat, 17 May 2014 17:44:23 +0300, Dan Carpenter > wrote: > > On Sat, May 17, 2014 at 12:38:57PM +0200, Christian Engelmayer wrote: > > > Function rtw_drv_init() is written in a way that assumes 'status' != > > > _SUCCESS

Re: [PATCH 1/2] staging: rtl8188eu: fix usage of uninit scalar in rtw_drv_init()

2014-05-17 Thread Christian Engelmayer
On Sat, 17 May 2014 17:44:23 +0300, Dan Carpenter wrote: > On Sat, May 17, 2014 at 12:38:57PM +0200, Christian Engelmayer wrote: > > Function rtw_drv_init() is written in a way that assumes 'status' != > > _SUCCESS > > as long as not explicitly set. Thus initialize 'status' to FAIL, in order to

Re: [PATCH 1/2] staging: rtl8188eu: fix usage of uninit scalar in rtw_drv_init()

2014-05-17 Thread Dan Carpenter
On Sat, May 17, 2014 at 12:38:57PM +0200, Christian Engelmayer wrote: > Function rtw_drv_init() is written in a way that assumes 'status' != _SUCCESS > as long as not explicitly set. Thus initialize 'status' to FAIL, in order to > prevent undefined behaviour if going through the exit paths.

[PATCH 1/2] staging: rtl8188eu: fix usage of uninit scalar in rtw_drv_init()

2014-05-17 Thread Christian Engelmayer
Function rtw_drv_init() is written in a way that assumes 'status' != _SUCCESS as long as not explicitly set. Thus initialize 'status' to FAIL, in order to prevent undefined behaviour if going through the exit paths. Detected by Coverity - CID 1077832. Signed-off-by: Christian Engelmayer ---

[PATCH 1/2] staging: rtl8188eu: fix usage of uninit scalar in rtw_drv_init()

2014-05-17 Thread Christian Engelmayer
Function rtw_drv_init() is written in a way that assumes 'status' != _SUCCESS as long as not explicitly set. Thus initialize 'status' to FAIL, in order to prevent undefined behaviour if going through the exit paths. Detected by Coverity - CID 1077832. Signed-off-by: Christian Engelmayer

Re: [PATCH 1/2] staging: rtl8188eu: fix usage of uninit scalar in rtw_drv_init()

2014-05-17 Thread Dan Carpenter
On Sat, May 17, 2014 at 12:38:57PM +0200, Christian Engelmayer wrote: Function rtw_drv_init() is written in a way that assumes 'status' != _SUCCESS as long as not explicitly set. Thus initialize 'status' to FAIL, in order to prevent undefined behaviour if going through the exit paths. Detected

Re: [PATCH 1/2] staging: rtl8188eu: fix usage of uninit scalar in rtw_drv_init()

2014-05-17 Thread Christian Engelmayer
On Sat, 17 May 2014 17:44:23 +0300, Dan Carpenter dan.carpen...@oracle.com wrote: On Sat, May 17, 2014 at 12:38:57PM +0200, Christian Engelmayer wrote: Function rtw_drv_init() is written in a way that assumes 'status' != _SUCCESS as long as not explicitly set. Thus initialize 'status' to

Re: [PATCH 1/2] staging: rtl8188eu: fix usage of uninit scalar in rtw_drv_init()

2014-05-17 Thread Dan Carpenter
On Sat, May 17, 2014 at 08:56:35PM +0200, Christian Engelmayer wrote: On Sat, 17 May 2014 17:44:23 +0300, Dan Carpenter dan.carpen...@oracle.com wrote: On Sat, May 17, 2014 at 12:38:57PM +0200, Christian Engelmayer wrote: Function rtw_drv_init() is written in a way that assumes 'status' !=