Re: [PATCH 1/2] tracing: Move enabling tracepoints to just after rcu_init()

2015-01-14 Thread Steven Rostedt
On Wed, 14 Jan 2015 10:09:05 +0900 Namhyung Kim wrote: > > >> + > > >> +void __init trace_event_init(void) > > >> +{ > > >> +event_trace_memsetup(); > > >> +init_ftrace_syscalls(); > > >> +event_trace_enable(); > > >> +} > > >> + > > > > > > init_ftrace_syscalls() get

Re: [PATCH 1/2] tracing: Move enabling tracepoints to just after rcu_init()

2015-01-14 Thread Steven Rostedt
On Wed, 14 Jan 2015 10:09:05 +0900 Namhyung Kim namhy...@kernel.org wrote: + +void __init trace_event_init(void) +{ +event_trace_memsetup(); +init_ftrace_syscalls(); +event_trace_enable(); +} + init_ftrace_syscalls() get called twice by

Re: [PATCH 1/2] tracing: Move enabling tracepoints to just after rcu_init()

2015-01-13 Thread Namhyung Kim
On Wed, Jan 14, 2015 at 08:12:40AM +0800, Wang Nan wrote: > Ping... > > On 2015/1/9 12:06, Wang Nan wrote: > > Hi Steven Rostedt, > > > > During studying your code we find a problem, please see below. > > > >> > >> From: "Steven Rostedt (Red Hat)" > >> > >> Enabling tracepoints at boot up can

Re: [PATCH 1/2] tracing: Move enabling tracepoints to just after rcu_init()

2015-01-13 Thread Wang Nan
Ping... On 2015/1/9 12:06, Wang Nan wrote: > Hi Steven Rostedt, > > During studying your code we find a problem, please see below. > >> >> From: "Steven Rostedt (Red Hat)" >> >> Enabling tracepoints at boot up can be very useful. The tracepoint >> can be initialized right after RCU has been.

Re: [PATCH 1/2] tracing: Move enabling tracepoints to just after rcu_init()

2015-01-13 Thread Namhyung Kim
On Wed, Jan 14, 2015 at 08:12:40AM +0800, Wang Nan wrote: Ping... On 2015/1/9 12:06, Wang Nan wrote: Hi Steven Rostedt, During studying your code we find a problem, please see below. From: Steven Rostedt (Red Hat) rost...@goodmis.org Enabling tracepoints at boot up can be

Re: [PATCH 1/2] tracing: Move enabling tracepoints to just after rcu_init()

2015-01-13 Thread Wang Nan
Ping... On 2015/1/9 12:06, Wang Nan wrote: Hi Steven Rostedt, During studying your code we find a problem, please see below. From: Steven Rostedt (Red Hat) rost...@goodmis.org Enabling tracepoints at boot up can be very useful. The tracepoint can be initialized right after RCU has

Re: [PATCH 1/2] tracing: Move enabling tracepoints to just after rcu_init()

2015-01-08 Thread Wang Nan
Hi Steven Rostedt, During studying your code we find a problem, please see below. > > From: "Steven Rostedt (Red Hat)" > > Enabling tracepoints at boot up can be very useful. The tracepoint > can be initialized right after RCU has been. There's no need to > wait for the early_initcall() to be

Re: [PATCH 1/2] tracing: Move enabling tracepoints to just after rcu_init()

2015-01-08 Thread Wang Nan
Hi Steven Rostedt, During studying your code we find a problem, please see below. From: Steven Rostedt (Red Hat) rost...@goodmis.org Enabling tracepoints at boot up can be very useful. The tracepoint can be initialized right after RCU has been. There's no need to wait for the

[PATCH 1/2] tracing: Move enabling tracepoints to just after rcu_init()

2014-12-15 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" Enabling tracepoints at boot up can be very useful. The tracepoint can be initialized right after RCU has been. There's no need to wait for the early_initcall() to be called. That's too late for some things that can use tracepoints for debugging. Move the logic

[PATCH 1/2] tracing: Move enabling tracepoints to just after rcu_init()

2014-12-15 Thread Steven Rostedt
From: Steven Rostedt (Red Hat) rost...@goodmis.org Enabling tracepoints at boot up can be very useful. The tracepoint can be initialized right after RCU has been. There's no need to wait for the early_initcall() to be called. That's too late for some things that can use tracepoints for debugging.