Re: [PATCH 1/2] units: Add the HZ_PER_KHZ macro

2021-03-04 Thread Andrew Morton
On Thu, 4 Mar 2021 13:41:27 +0100 Daniel Lezcano wrote: > > Also, why make them signed types? Negative Hz is physically > > nonsensical. If that upsets some code somewhere because it was dealing > > with signed types then, well, that code needed fixing anyway. > > > > Ditto

Re: [PATCH 1/2] units: Add the HZ_PER_KHZ macro

2021-03-04 Thread Daniel Lezcano
Hi Andrew, On 04/03/2021 01:31, Andrew Morton wrote: > On Wed, 24 Feb 2021 10:39:36 +0200 Andy Shevchenko > wrote: > >> On Wednesday, February 24, 2021, Andy Shevchenko >> wrote: >> >>> >>> >>> On Tuesday, February 23, 2021, Daniel Lezcano >>> wrote: >>> The macro for the unit

Re: [PATCH 1/2] units: Add the HZ_PER_KHZ macro

2021-03-04 Thread Andy Shevchenko
On Thu, Mar 4, 2021 at 2:31 AM Andrew Morton wrote: > On Wed, 24 Feb 2021 10:39:36 +0200 Andy Shevchenko > wrote: ... > Also, why make them signed types? Negative Hz is physically > nonsensical. If that upsets some code somewhere because it was dealing > with signed types then, well, that

Re: [PATCH 1/2] units: Add the HZ_PER_KHZ macro

2021-03-03 Thread Andrew Morton
On Wed, 24 Feb 2021 10:39:36 +0200 Andy Shevchenko wrote: > On Wednesday, February 24, 2021, Andy Shevchenko > wrote: > > > > > > > On Tuesday, February 23, 2021, Daniel Lezcano > > wrote: > > > >> The macro for the unit conversion for frequency is duplicated in > >> different places. > >> >

[PATCH 1/2] units: Add the HZ_PER_KHZ macro

2021-02-23 Thread Daniel Lezcano
The macro for the unit conversion for frequency is duplicated in different places. Provide this macro in the 'units' header, so it can be reused. Signed-off-by: Daniel Lezcano --- include/linux/units.h | 4 1 file changed, 4 insertions(+) diff --git a/include/linux/units.h