Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-07-05 Thread Peter Zijlstra
On Tue, Jun 27, 2017 at 08:07:10PM +0700, Suravee Suthikulpanit wrote: > As I have described in the cover letter, this patch series changes how Which you didn't send to me... thanks for that. > kernel derives cpu "package" from package-as-socket to package-as-die in > order to fix following

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-07-05 Thread Peter Zijlstra
On Tue, Jun 27, 2017 at 08:07:10PM +0700, Suravee Suthikulpanit wrote: > As I have described in the cover letter, this patch series changes how Which you didn't send to me... thanks for that. > kernel derives cpu "package" from package-as-socket to package-as-die in > order to fix following

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-28 Thread Borislav Petkov
+ Matt and Mel. On Wed, Jun 28, 2017 at 03:26:10AM +0700, Suravee Suthikulpanit wrote: > So, from the definition above, we would like all those 16 threads to be in > the same sched-domain, where threads from C0,1,2,3 are in the same > sched-group, and threads in C4,5,6,7 are in another

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-28 Thread Borislav Petkov
+ Matt and Mel. On Wed, Jun 28, 2017 at 03:26:10AM +0700, Suravee Suthikulpanit wrote: > So, from the definition above, we would like all those 16 threads to be in > the same sched-domain, where threads from C0,1,2,3 are in the same > sched-group, and threads in C4,5,6,7 are in another

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Suravee Suthikulpanit
On 6/28/17 00:44, Borislav Petkov wrote: So let's try to discuss this without using DIE sched-domain, CCX, etc, and let's start simple. So in that die graphic: C0 | T0 T1 |||| T0 T1 | C4 ||||

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Suravee Suthikulpanit
On 6/28/17 00:44, Borislav Petkov wrote: So let's try to discuss this without using DIE sched-domain, CCX, etc, and let's start simple. So in that die graphic: C0 | T0 T1 |||| T0 T1 | C4 ||||

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Borislav Petkov
On Tue, Jun 27, 2017 at 06:32:34PM +, Ghannam, Yazen wrote: > > you want all those threads to belong to a single scheduling group. > > Correct? > > > > Now that thing has a memory controller attached to it, correct? > > > > If so, why is this thing not a logical NUMA node, as described in

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Borislav Petkov
On Tue, Jun 27, 2017 at 06:32:34PM +, Ghannam, Yazen wrote: > > you want all those threads to belong to a single scheduling group. > > Correct? > > > > Now that thing has a memory controller attached to it, correct? > > > > If so, why is this thing not a logical NUMA node, as described in

RE: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Ghannam, Yazen
kernel.org; linux-kernel@vger.kernel.org; Duran, Leo > <leo.du...@amd.com>; Ghannam, Yazen <yazen.ghan...@amd.com>; > Peter Zijlstra <pet...@infradead.org> > Subject: Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of > socket > > On Tue, Jun 27, 2017 at 11:5

RE: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Ghannam, Yazen
n, Leo > ; Ghannam, Yazen ; > Peter Zijlstra > Subject: Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of > socket > > On Tue, Jun 27, 2017 at 11:54:12PM +0700, Suravee Suthikulpanit wrote: > > The 8 threads sharing each L3 are already in the same sched-domain1 &

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Borislav Petkov
On Tue, Jun 27, 2017 at 11:54:12PM +0700, Suravee Suthikulpanit wrote: > The 8 threads sharing each L3 are already in the same sched-domain1 (MC > CCX). So, cpu0 is in the same sched-domain1 as cpu1,2,3,64,65,66,67. Here, > we need the DIE sched-domain because it represents all cpus that are in

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Borislav Petkov
On Tue, Jun 27, 2017 at 11:54:12PM +0700, Suravee Suthikulpanit wrote: > The 8 threads sharing each L3 are already in the same sched-domain1 (MC > CCX). So, cpu0 is in the same sched-domain1 as cpu1,2,3,64,65,66,67. Here, > we need the DIE sched-domain because it represents all cpus that are in

RE: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Duran, Leo
m>; x...@kernel.org; linux- > ker...@vger.kernel.org; Ghannam, Yazen <yazen.ghan...@amd.com>; > Peter Zijlstra <pet...@infradead.org> > Subject: Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of > socket > > On Tue, Jun 27, 2017 at 04:42:32PM +, Duran, Le

RE: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Duran, Leo
> Subject: Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of > socket > > On Tue, Jun 27, 2017 at 04:42:32PM +, Duran, Leo wrote: > > First of all, please do not top-post. > > > Are you saying that "amd.c' should be scheduler-aware?.. Really? &

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Suravee Suthikulpanit
Boris, On 6/27/17 20:42, Borislav Petkov wrote: On Tue, Jun 27, 2017 at 08:07:10PM +0700, Suravee Suthikulpanit wrote: What we are trying point out here is that (NUMA) "node" and "die" are the same thing in most of AMD processors, not necessary trying to introduce another term here. So don't

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Suravee Suthikulpanit
Boris, On 6/27/17 20:42, Borislav Petkov wrote: On Tue, Jun 27, 2017 at 08:07:10PM +0700, Suravee Suthikulpanit wrote: What we are trying point out here is that (NUMA) "node" and "die" are the same thing in most of AMD processors, not necessary trying to introduce another term here. So don't

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Borislav Petkov
On Tue, Jun 27, 2017 at 04:42:32PM +, Duran, Leo wrote: First of all, please do not top-post. > Are you saying that "amd.c' should be scheduler-aware?.. Really? Please read again what I said. > If so, are you saying that information returned by kernel-defined > terms like 'Package',

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Borislav Petkov
On Tue, Jun 27, 2017 at 04:42:32PM +, Duran, Leo wrote: First of all, please do not top-post. > Are you saying that "amd.c' should be scheduler-aware?.. Really? Please read again what I said. > If so, are you saying that information returned by kernel-defined > terms like 'Package',

RE: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Duran, Leo
vger.kernel.org; Ghannam, Yazen <yazen.ghan...@amd.com>; > Peter Zijlstra <pet...@infradead.org> > Subject: Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of > socket > > On Tue, Jun 27, 2017 at 04:23:16PM +, Duran, Leo wrote: > > My understating is

RE: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Duran, Leo
- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Tuesday, June 27, 2017 11:32 AM > To: Duran, Leo > Cc: 'Thomas Gleixner' ; Suthikulpanit, Suravee > ; x...@kernel.org; linux- > ker...@vger.kernel.org; Ghannam, Yazen ; > Peter Zijlstra > Subject: Re: [PATCH 1/2] x

RE: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Duran, Leo
d.com>; Borislav > Petkov <b...@alien8.de>; x...@kernel.org; linux-kernel@vger.kernel.org; > Ghannam, Yazen <yazen.ghan...@amd.com>; Peter Zijlstra > <pet...@infradead.org> > Subject: RE: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of > socket > &

RE: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Duran, Leo
kernel@vger.kernel.org; > Ghannam, Yazen ; Peter Zijlstra > > Subject: RE: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of > socket > > On Tue, 27 Jun 2017, Duran, Leo wrote: > > > From: Thomas Gleixner [mailto:t...@linutronix.de] On Tue, 27 Jun > > > 2

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Borislav Petkov
On Tue, Jun 27, 2017 at 04:23:16PM +, Duran, Leo wrote: > My understating is that it is *not* our job at the "amd.c" level to > return information that influences the scheduler in any prescribed > way. Your understanding is wrong. The abstractions we present to the rest of the kernel is so

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Borislav Petkov
On Tue, Jun 27, 2017 at 04:23:16PM +, Duran, Leo wrote: > My understating is that it is *not* our job at the "amd.c" level to > return information that influences the scheduler in any prescribed > way. Your understanding is wrong. The abstractions we present to the rest of the kernel is so

RE: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Duran, Leo
<suravee.suthikulpa...@amd.com>; x...@kernel.org; linux- > ker...@vger.kernel.org; Ghannam, Yazen <yazen.ghan...@amd.com>; > Peter Zijlstra <pet...@infradead.org> > Subject: Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of > socket > > On Tue,

RE: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Duran, Leo
l.org; Ghannam, Yazen ; > Peter Zijlstra > Subject: Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of > socket > > On Tue, Jun 27, 2017 at 03:48:55PM +, Duran, Leo wrote: > > Basically, in our case a Package may contain more than one L3 (i.e., > > in hardw

RE: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Thomas Gleixner
On Tue, 27 Jun 2017, Duran, Leo wrote: > > From: Thomas Gleixner [mailto:t...@linutronix.de] > > On Tue, 27 Jun 2017, Suravee Suthikulpanit wrote: > > > On 6/27/17 17:48, Borislav Petkov wrote: > > > > On Tue, Jun 27, 2017 at 01:40:52AM -0500, Suravee Suthikulpanit wrote: > > > > > However, this

RE: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Thomas Gleixner
On Tue, 27 Jun 2017, Duran, Leo wrote: > > From: Thomas Gleixner [mailto:t...@linutronix.de] > > On Tue, 27 Jun 2017, Suravee Suthikulpanit wrote: > > > On 6/27/17 17:48, Borislav Petkov wrote: > > > > On Tue, Jun 27, 2017 at 01:40:52AM -0500, Suravee Suthikulpanit wrote: > > > > > However, this

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Borislav Petkov
On Tue, Jun 27, 2017 at 10:55:52PM +0700, Suravee Suthikulpanit wrote: > The reason we are trying to present "package == NUMA node (die)" here is > because the topology.txt defines package to contain a number of cores plus > shared resources (e.g. DRAM controller, shared caches, etc). Since the >

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Borislav Petkov
On Tue, Jun 27, 2017 at 10:55:52PM +0700, Suravee Suthikulpanit wrote: > The reason we are trying to present "package == NUMA node (die)" here is > because the topology.txt defines package to contain a number of cores plus > shared resources (e.g. DRAM controller, shared caches, etc). Since the >

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Borislav Petkov
On Tue, Jun 27, 2017 at 03:48:55PM +, Duran, Leo wrote: > Basically, in our case a Package may contain more than one L3 (i.e., > in hardware terms, there may more than one 'Core complex' in a 'Die'). > The important point is that all logical processors (threads) that > share an L3 have a

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Borislav Petkov
On Tue, Jun 27, 2017 at 03:48:55PM +, Duran, Leo wrote: > Basically, in our case a Package may contain more than one L3 (i.e., > in hardware terms, there may more than one 'Core complex' in a 'Die'). > The important point is that all logical processors (threads) that > share an L3 have a

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Suravee Suthikulpanit
On 6/27/17 21:21, Thomas Gleixner wrote: On Tue, 27 Jun 2017, Suravee Suthikulpanit wrote: On 6/27/17 17:48, Borislav Petkov wrote: On Tue, Jun 27, 2017 at 01:40:52AM -0500, Suravee Suthikulpanit wrote: However, this is not the case on AMD family17h multi-die processor platforms, which can

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Suravee Suthikulpanit
On 6/27/17 21:21, Thomas Gleixner wrote: On Tue, 27 Jun 2017, Suravee Suthikulpanit wrote: On 6/27/17 17:48, Borislav Petkov wrote: On Tue, Jun 27, 2017 at 01:40:52AM -0500, Suravee Suthikulpanit wrote: However, this is not the case on AMD family17h multi-die processor platforms, which can

RE: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Duran, Leo
gt;; x...@kernel.org; linux- > ker...@vger.kernel.org; Duran, Leo <leo.du...@amd.com>; Ghannam, > Yazen <yazen.ghan...@amd.com>; Peter Zijlstra <pet...@infradead.org> > Subject: Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of > socket > > On Tue,

RE: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Duran, Leo
ran, Leo ; Ghannam, > Yazen ; Peter Zijlstra > Subject: Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of > socket > > On Tue, 27 Jun 2017, Suravee Suthikulpanit wrote: > > On 6/27/17 17:48, Borislav Petkov wrote: > > > On Tue, Jun 27, 2017

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Brice Goglin
Le 27/06/2017 16:21, Thomas Gleixner a écrit : > On Tue, 27 Jun 2017, Suravee Suthikulpanit wrote: >> On 6/27/17 17:48, Borislav Petkov wrote: >>> On Tue, Jun 27, 2017 at 01:40:52AM -0500, Suravee Suthikulpanit wrote: However, this is not the case on AMD family17h multi-die processor

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Brice Goglin
Le 27/06/2017 16:21, Thomas Gleixner a écrit : > On Tue, 27 Jun 2017, Suravee Suthikulpanit wrote: >> On 6/27/17 17:48, Borislav Petkov wrote: >>> On Tue, Jun 27, 2017 at 01:40:52AM -0500, Suravee Suthikulpanit wrote: However, this is not the case on AMD family17h multi-die processor

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Thomas Gleixner
On Tue, 27 Jun 2017, Suravee Suthikulpanit wrote: > On 6/27/17 17:48, Borislav Petkov wrote: > > On Tue, Jun 27, 2017 at 01:40:52AM -0500, Suravee Suthikulpanit wrote: > > > However, this is not the case on AMD family17h multi-die processor > > > platforms, which can have up to 4 dies per socket

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Thomas Gleixner
On Tue, 27 Jun 2017, Suravee Suthikulpanit wrote: > On 6/27/17 17:48, Borislav Petkov wrote: > > On Tue, Jun 27, 2017 at 01:40:52AM -0500, Suravee Suthikulpanit wrote: > > > However, this is not the case on AMD family17h multi-die processor > > > platforms, which can have up to 4 dies per socket

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Borislav Petkov
On Tue, Jun 27, 2017 at 08:07:10PM +0700, Suravee Suthikulpanit wrote: > What we are trying point out here is that (NUMA) "node" and "die" are the > same thing in most of AMD processors, not necessary trying to introduce > another term here. So don't use it then. The whole topology topic is

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Borislav Petkov
On Tue, Jun 27, 2017 at 08:07:10PM +0700, Suravee Suthikulpanit wrote: > What we are trying point out here is that (NUMA) "node" and "die" are the > same thing in most of AMD processors, not necessary trying to introduce > another term here. So don't use it then. The whole topology topic is

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Suravee Suthikulpanit
Hi Boris, On 6/27/17 17:48, Borislav Petkov wrote: On Tue, Jun 27, 2017 at 01:40:52AM -0500, Suravee Suthikulpanit wrote: According to the Documentation/x86/topology.txt, AMD nomenclature for package is NUMA node (or die). You guys keep talking about die so you should add the definition of

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Suravee Suthikulpanit
Hi Boris, On 6/27/17 17:48, Borislav Petkov wrote: On Tue, Jun 27, 2017 at 01:40:52AM -0500, Suravee Suthikulpanit wrote: According to the Documentation/x86/topology.txt, AMD nomenclature for package is NUMA node (or die). You guys keep talking about die so you should add the definition of

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Borislav Petkov
Remove stable from CC - this is not how you do a stable submission. See Documentation/process/stable-kernel-rules.rst On Tue, Jun 27, 2017 at 01:40:52AM -0500, Suravee Suthikulpanit wrote: > According to the Documentation/x86/topology.txt, AMD nomenclature for > package is NUMA node (or die).

Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Borislav Petkov
Remove stable from CC - this is not how you do a stable submission. See Documentation/process/stable-kernel-rules.rst On Tue, Jun 27, 2017 at 01:40:52AM -0500, Suravee Suthikulpanit wrote: > According to the Documentation/x86/topology.txt, AMD nomenclature for > package is NUMA node (or die).

[PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Suravee Suthikulpanit
According to the Documentation/x86/topology.txt, AMD nomenclature for package is NUMA node (or die). However, this is not the case on AMD family17h multi-die processor platforms, which can have up to 4 dies per socket as shown in the following system topology. Die (Dx) View :

[PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket

2017-06-27 Thread Suravee Suthikulpanit
According to the Documentation/x86/topology.txt, AMD nomenclature for package is NUMA node (or die). However, this is not the case on AMD family17h multi-die processor platforms, which can have up to 4 dies per socket as shown in the following system topology. Die (Dx) View :